mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-24 18:44:20 +08:00
6c2659886f
I'd like to enable the -Wmissing-declarations warning. However, it
warns for every _initialize function, for example:
CXX dcache.o
/home/smarchi/src/binutils-gdb/gdb/dcache.c: In function ‘void _initialize_dcache()’:
/home/smarchi/src/binutils-gdb/gdb/dcache.c:688:1: error: no previous declaration for ‘void _initialize_dcache()’ [-Werror=missing-declarations]
_initialize_dcache (void)
^~~~~~~~~~~~~~~~~~
The only practical way forward I found is to add back the declarations,
which were removed by this commit:
commit 481695ed5f
Author: John Baldwin <jhb@FreeBSD.org>
Date: Sat Sep 9 11:02:37 2017 -0700
Remove unnecessary function prototypes.
I don't think it's a big problem to have the declarations for these
functions, but if anybody has a better solution for this, I'll be happy
to use it.
gdb/ChangeLog:
* aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
* aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
* aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
* aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
* aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
* ada-exp.y (_initialize_ada_exp): Add declaration.
* ada-lang.c (_initialize_ada_language): Add declaration.
* ada-tasks.c (_initialize_tasks): Add declaration.
* agent.c (_initialize_agent): Add declaration.
* aix-thread.c (_initialize_aix_thread): Add declaration.
* alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
* alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
* alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
* alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
* alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
* alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
* amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
* amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
* amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
* amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
* amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
* amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
* amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
* amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
* amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
* amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
* amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
* amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
* amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
* amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
* annotate.c (_initialize_annotate): Add declaration.
* arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
* arc-tdep.c (_initialize_arc_tdep): Add declaration.
* arch-utils.c (_initialize_gdbarch_utils): Add declaration.
* arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
* arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
* arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
* arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
* arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
* arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
* arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
* arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
* arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
* arm-tdep.c (_initialize_arm_tdep): Add declaration.
* arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
* auto-load.c (_initialize_auto_load): Add declaration.
* auxv.c (_initialize_auxv): Add declaration.
* avr-tdep.c (_initialize_avr_tdep): Add declaration.
* ax-gdb.c (_initialize_ax_gdb): Add declaration.
* bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
* bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
* break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
* break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
* break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
* breakpoint.c (_initialize_breakpoint): Add declaration.
* bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
* btrace.c (_initialize_btrace): Add declaration.
* charset.c (_initialize_charset): Add declaration.
* cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
* cli/cli-dump.c (_initialize_cli_dump): Add declaration.
* cli/cli-interp.c (_initialize_cli_interp): Add declaration.
* cli/cli-logging.c (_initialize_cli_logging): Add declaration.
* cli/cli-script.c (_initialize_cli_script): Add declaration.
* cli/cli-style.c (_initialize_cli_style): Add declaration.
* coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
* coffread.c (_initialize_coffread): Add declaration.
* compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
* compile/compile.c (_initialize_compile): Add declaration.
* complaints.c (_initialize_complaints): Add declaration.
* completer.c (_initialize_completer): Add declaration.
* copying.c (_initialize_copying): Add declaration.
* corefile.c (_initialize_core): Add declaration.
* corelow.c (_initialize_corelow): Add declaration.
* cp-abi.c (_initialize_cp_abi): Add declaration.
* cp-namespace.c (_initialize_cp_namespace): Add declaration.
* cp-support.c (_initialize_cp_support): Add declaration.
* cp-valprint.c (_initialize_cp_valprint): Add declaration.
* cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
* cris-tdep.c (_initialize_cris_tdep): Add declaration.
* csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
* csky-tdep.c (_initialize_csky_tdep): Add declaration.
* ctfread.c (_initialize_ctfread): Add declaration.
* d-lang.c (_initialize_d_language): Add declaration.
* darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
* darwin-nat.c (_initialize_darwin_nat): Add declaration.
* dbxread.c (_initialize_dbxread): Add declaration.
* dcache.c (_initialize_dcache): Add declaration.
* disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
* disasm.c (_initialize_disasm): Add declaration.
* dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
* dummy-frame.c (_initialize_dummy_frame): Add declaration.
* dwarf-index-cache.c (_initialize_index_cache): Add declaration.
* dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
* dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
* dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
* dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
* dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
* dwarf2read.c (_initialize_dwarf2_read): Add declaration.
* elfread.c (_initialize_elfread): Add declaration.
* exec.c (_initialize_exec): Add declaration.
* extension.c (_initialize_extension): Add declaration.
* f-lang.c (_initialize_f_language): Add declaration.
* f-valprint.c (_initialize_f_valprint): Add declaration.
* fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
* fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
* filesystem.c (_initialize_filesystem): Add declaration.
* findcmd.c (_initialize_mem_search): Add declaration.
* findvar.c (_initialize_findvar): Add declaration.
* fork-child.c (_initialize_fork_child): Add declaration.
* frame-base.c (_initialize_frame_base): Add declaration.
* frame-unwind.c (_initialize_frame_unwind): Add declaration.
* frame.c (_initialize_frame): Add declaration.
* frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
* frv-tdep.c (_initialize_frv_tdep): Add declaration.
* ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
* gcore.c (_initialize_gcore): Add declaration.
* gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
* gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
* gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
* gdbarch.c (_initialize_gdbarch): Add declaration.
* gdbtypes.c (_initialize_gdbtypes): Add declaration.
* gnu-nat.c (_initialize_gnu_nat): Add declaration.
* gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
* gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
* go-lang.c (_initialize_go_language): Add declaration.
* go32-nat.c (_initialize_go32_nat): Add declaration.
* guile/guile.c (_initialize_guile): Add declaration.
* h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
* hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
* hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
* hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
* hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
* hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
* hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
* hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
* i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
* i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
* i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
* i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
* i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
* i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
* i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
* i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
* i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
* i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
* i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
* i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
* i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
* i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
* i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
* i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
* i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
* i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
* i386-tdep.c (_initialize_i386_tdep): Add declaration.
* i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
* ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
* ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
* ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
* ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
* ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
* infcall.c (_initialize_infcall): Add declaration.
* infcmd.c (_initialize_infcmd): Add declaration.
* inflow.c (_initialize_inflow): Add declaration.
* infrun.c (_initialize_infrun): Add declaration.
* interps.c (_initialize_interpreter): Add declaration.
* iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
* jit.c (_initialize_jit): Add declaration.
* language.c (_initialize_language): Add declaration.
* linux-fork.c (_initialize_linux_fork): Add declaration.
* linux-nat.c (_initialize_linux_nat): Add declaration.
* linux-tdep.c (_initialize_linux_tdep): Add declaration.
* linux-thread-db.c (_initialize_thread_db): Add declaration.
* lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
* m2-lang.c (_initialize_m2_language): Add declaration.
* m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
* m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
* m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
* m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
* m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
* m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
* m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
* m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
* m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
* m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
* machoread.c (_initialize_machoread): Add declaration.
* macrocmd.c (_initialize_macrocmd): Add declaration.
* macroscope.c (_initialize_macroscope): Add declaration.
* maint-test-options.c (_initialize_maint_test_options): Add declaration.
* maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
* maint.c (_initialize_maint_cmds): Add declaration.
* mdebugread.c (_initialize_mdebugread): Add declaration.
* memattr.c (_initialize_mem): Add declaration.
* mep-tdep.c (_initialize_mep_tdep): Add declaration.
* mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
* mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
* mi/mi-interp.c (_initialize_mi_interp): Add declaration.
* mi/mi-main.c (_initialize_mi_main): Add declaration.
* microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
* microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
* mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
* mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
* mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
* mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
* mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
* mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
* mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
* mips-tdep.c (_initialize_mips_tdep): Add declaration.
* mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
* mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
* mipsread.c (_initialize_mipsread): Add declaration.
* mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
* mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
* moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
* msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
* nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
* nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
* nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
* nto-procfs.c (_initialize_procfs): Add declaration.
* objc-lang.c (_initialize_objc_language): Add declaration.
* observable.c (_initialize_observer): Add declaration.
* opencl-lang.c (_initialize_opencl_language): Add declaration.
* or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
* or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
* osabi.c (_initialize_gdb_osabi): Add declaration.
* osdata.c (_initialize_osdata): Add declaration.
* p-valprint.c (_initialize_pascal_valprint): Add declaration.
* parse.c (_initialize_parse): Add declaration.
* ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
* ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
* ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
* ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
* ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
* ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
* ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
* printcmd.c (_initialize_printcmd): Add declaration.
* probe.c (_initialize_probe): Add declaration.
* proc-api.c (_initialize_proc_api): Add declaration.
* proc-events.c (_initialize_proc_events): Add declaration.
* proc-service.c (_initialize_proc_service): Add declaration.
* procfs.c (_initialize_procfs): Add declaration.
* producer.c (_initialize_producer): Add declaration.
* psymtab.c (_initialize_psymtab): Add declaration.
* python/python.c (_initialize_python): Add declaration.
* ravenscar-thread.c (_initialize_ravenscar): Add declaration.
* record-btrace.c (_initialize_record_btrace): Add declaration.
* record-full.c (_initialize_record_full): Add declaration.
* record.c (_initialize_record): Add declaration.
* regcache-dump.c (_initialize_regcache_dump): Add declaration.
* regcache.c (_initialize_regcache): Add declaration.
* reggroups.c (_initialize_reggroup): Add declaration.
* remote-notif.c (_initialize_notif): Add declaration.
* remote-sim.c (_initialize_remote_sim): Add declaration.
* remote.c (_initialize_remote): Add declaration.
* reverse.c (_initialize_reverse): Add declaration.
* riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
* riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
* riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
* riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
* riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
* rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
* rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
* rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
Add declaration.
* rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
* rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
* run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
* rust-exp.y (_initialize_rust_exp): Add declaration.
* rx-tdep.c (_initialize_rx_tdep): Add declaration.
* s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
* s390-linux-nat.c (_initialize_s390_nat): Add declaration.
* s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
* s390-tdep.c (_initialize_s390_tdep): Add declaration.
* score-tdep.c (_initialize_score_tdep): Add declaration.
* ser-go32.c (_initialize_ser_dos): Add declaration.
* ser-mingw.c (_initialize_ser_windows): Add declaration.
* ser-pipe.c (_initialize_ser_pipe): Add declaration.
* ser-tcp.c (_initialize_ser_tcp): Add declaration.
* ser-uds.c (_initialize_ser_socket): Add declaration.
* ser-unix.c (_initialize_ser_hardwire): Add declaration.
* serial.c (_initialize_serial): Add declaration.
* sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
* sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
* sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
* sh-tdep.c (_initialize_sh_tdep): Add declaration.
* skip.c (_initialize_step_skip): Add declaration.
* sol-thread.c (_initialize_sol_thread): Add declaration.
* solib-aix.c (_initialize_solib_aix): Add declaration.
* solib-darwin.c (_initialize_darwin_solib): Add declaration.
* solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
* solib-frv.c (_initialize_frv_solib): Add declaration.
* solib-svr4.c (_initialize_svr4_solib): Add declaration.
* solib-target.c (_initialize_solib_target): Add declaration.
* solib.c (_initialize_solib): Add declaration.
* source-cache.c (_initialize_source_cache): Add declaration.
* source.c (_initialize_source): Add declaration.
* sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
* sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
* sparc-nat.c (_initialize_sparc_nat): Add declaration.
* sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
* sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
* sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
* sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
* sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
* sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
* sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
* sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
* sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
* sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
* sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
* sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
* sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
* sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
* sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
* sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
* stabsread.c (_initialize_stabsread): Add declaration.
* stack.c (_initialize_stack): Add declaration.
* stap-probe.c (_initialize_stap_probe): Add declaration.
* std-regs.c (_initialize_frame_reg): Add declaration.
* symfile-debug.c (_initialize_symfile_debug): Add declaration.
* symfile-mem.c (_initialize_symfile_mem): Add declaration.
* symfile.c (_initialize_symfile): Add declaration.
* symmisc.c (_initialize_symmisc): Add declaration.
* symtab.c (_initialize_symtab): Add declaration.
* target.c (_initialize_target): Add declaration.
* target-connection.c (_initialize_target_connection): Add
declaration.
* target-dcache.c (_initialize_target_dcache): Add declaration.
* target-descriptions.c (_initialize_target_descriptions): Add declaration.
* thread.c (_initialize_thread): Add declaration.
* tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
* tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
* tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
* tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
* tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
* tracectf.c (_initialize_ctf): Add declaration.
* tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
* tracefile.c (_initialize_tracefile): Add declaration.
* tracepoint.c (_initialize_tracepoint): Add declaration.
* tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
* tui/tui-interp.c (_initialize_tui_interp): Add declaration.
* tui/tui-layout.c (_initialize_tui_layout): Add declaration.
* tui/tui-regs.c (_initialize_tui_regs): Add declaration.
* tui/tui-stack.c (_initialize_tui_stack): Add declaration.
* tui/tui-win.c (_initialize_tui_win): Add declaration.
* tui/tui.c (_initialize_tui): Add declaration.
* typeprint.c (_initialize_typeprint): Add declaration.
* ui-style.c (_initialize_ui_style): Add declaration.
* unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
* unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
* unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
* unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
* unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
* unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
* unittests/filtered_iterator-selftests.c
(_initialize_filtered_iterator_selftests): Add declaration.
* unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
* unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
* unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
* unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
* unittests/main-thread-selftests.c
(_initialize_main_thread_selftests): Add declaration.
* unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
* unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
* unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
* unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
* unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
* unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
* unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
* unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
* unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
* unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
* unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
* unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
* unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
* unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
* unittests/tui-selftests.c (_initialize_tui_selftest): Add
declaration.
* unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
* unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
* unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
* unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
* user-regs.c (_initialize_user_regs): Add declaration.
* utils.c (_initialize_utils): Add declaration.
* v850-tdep.c (_initialize_v850_tdep): Add declaration.
* valops.c (_initialize_valops): Add declaration.
* valprint.c (_initialize_valprint): Add declaration.
* value.c (_initialize_values): Add declaration.
* varobj.c (_initialize_varobj): Add declaration.
* vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
* vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
* vax-tdep.c (_initialize_vax_tdep): Add declaration.
* windows-nat.c (_initialize_windows_nat): Add declaration.
(_initialize_check_for_gdb_ini): Add declaration.
(_initialize_loadable): Add declaration.
* windows-tdep.c (_initialize_windows_tdep): Add declaration.
* x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
* x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
* xcoffread.c (_initialize_xcoffread): Add declaration.
* xml-support.c (_initialize_xml_support): Add declaration.
* xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
* xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
* xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
* xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
Change-Id: I13eec7e0ed2b3c427377a7bdb055cf46da64def9
707 lines
22 KiB
C
707 lines
22 KiB
C
/* Read the export table symbols from a portable executable and
|
||
convert to internal format, for GDB. Used as a last resort if no
|
||
debugging symbols recognized.
|
||
|
||
Copyright (C) 2003-2020 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||
|
||
Contributed by Raoul M. Gough (RaoulGough@yahoo.co.uk). */
|
||
|
||
#include "defs.h"
|
||
|
||
#include "coff-pe-read.h"
|
||
|
||
#include "bfd.h"
|
||
#include "gdbtypes.h"
|
||
|
||
#include "command.h"
|
||
#include "gdbcmd.h"
|
||
#include "symtab.h"
|
||
#include "symfile.h"
|
||
#include "objfiles.h"
|
||
#include "gdbsupport/common-utils.h"
|
||
#include "coff/internal.h"
|
||
|
||
#include <ctype.h>
|
||
|
||
/* Internal section information */
|
||
|
||
/* Coff PE read debugging flag:
|
||
default value is 0,
|
||
value 1 outputs problems encountered while parsing PE file,
|
||
value above 1 also lists all generated minimal symbols. */
|
||
static unsigned int debug_coff_pe_read;
|
||
|
||
struct read_pe_section_data
|
||
{
|
||
CORE_ADDR vma_offset; /* Offset to loaded address of section. */
|
||
unsigned long rva_start; /* Start offset within the pe. */
|
||
unsigned long rva_end; /* End offset within the pe. */
|
||
enum minimal_symbol_type ms_type; /* Type to assign symbols in
|
||
section. */
|
||
unsigned int index; /* BFD section number. */
|
||
std::string section_name; /* Recorded section name. */
|
||
};
|
||
|
||
#define IMAGE_SCN_CNT_CODE 0x20
|
||
#define IMAGE_SCN_CNT_INITIALIZED_DATA 0x40
|
||
#define IMAGE_SCN_CNT_UNINITIALIZED_DATA 0x80
|
||
#define PE_SECTION_INDEX_TEXT 0
|
||
#define PE_SECTION_INDEX_DATA 1
|
||
#define PE_SECTION_INDEX_BSS 2
|
||
#define PE_SECTION_TABLE_SIZE 3
|
||
#define PE_SECTION_INDEX_INVALID -1
|
||
|
||
/* Get the index of the named section in our own array, which contains
|
||
text, data and bss in that order. Return PE_SECTION_INDEX_INVALID
|
||
if passed an unrecognised section name. */
|
||
|
||
static int
|
||
read_pe_section_index (const char *section_name)
|
||
{
|
||
if (strcmp (section_name, ".text") == 0)
|
||
{
|
||
return PE_SECTION_INDEX_TEXT;
|
||
}
|
||
|
||
else if (strcmp (section_name, ".data") == 0)
|
||
{
|
||
return PE_SECTION_INDEX_DATA;
|
||
}
|
||
|
||
else if (strcmp (section_name, ".bss") == 0)
|
||
{
|
||
return PE_SECTION_INDEX_BSS;
|
||
}
|
||
|
||
else
|
||
{
|
||
return PE_SECTION_INDEX_INVALID;
|
||
}
|
||
}
|
||
|
||
/* Get the index of the named section in our own full array.
|
||
text, data and bss in that order. Return PE_SECTION_INDEX_INVALID
|
||
if passed an unrecognised section name. */
|
||
|
||
static int
|
||
get_pe_section_index (const char *section_name,
|
||
struct read_pe_section_data *sections,
|
||
int nb_sections)
|
||
{
|
||
int i;
|
||
|
||
for (i = 0; i < nb_sections; i++)
|
||
if (sections[i].section_name == section_name)
|
||
return i;
|
||
return PE_SECTION_INDEX_INVALID;
|
||
}
|
||
|
||
/* Structure used by get_section_vmas function below
|
||
to access section_data array and the size of the array
|
||
stored in nb_sections field. */
|
||
struct pe_sections_info
|
||
{
|
||
int nb_sections;
|
||
struct read_pe_section_data *sections;
|
||
};
|
||
|
||
/* Record the virtual memory address of a section. */
|
||
|
||
static void
|
||
get_section_vmas (bfd *abfd, asection *sectp, void *context)
|
||
{
|
||
struct pe_sections_info *data = (struct pe_sections_info *) context;
|
||
struct read_pe_section_data *sections = data->sections;
|
||
int sectix = get_pe_section_index (sectp->name, sections,
|
||
data->nb_sections);
|
||
|
||
if (sectix != PE_SECTION_INDEX_INVALID)
|
||
{
|
||
/* Data within the section start at rva_start in the pe and at
|
||
bfd_get_section_vma() within memory. Store the offset. */
|
||
|
||
sections[sectix].vma_offset
|
||
= bfd_section_vma (sectp) - sections[sectix].rva_start;
|
||
}
|
||
}
|
||
|
||
/* Create a minimal symbol entry for an exported symbol.
|
||
SYM_NAME contains the exported name or NULL if exported by ordinal,
|
||
FUNC_RVA contains the Relative Virtual Address of the symbol,
|
||
ORDINAL is the ordinal index value of the symbol,
|
||
SECTION_DATA contains information about the section in which the
|
||
symbol is declared,
|
||
DLL_NAME is the internal name of the DLL file,
|
||
OBJFILE is the objfile struct of DLL_NAME. */
|
||
|
||
static void
|
||
add_pe_exported_sym (minimal_symbol_reader &reader,
|
||
const char *sym_name,
|
||
unsigned long func_rva,
|
||
int ordinal,
|
||
const struct read_pe_section_data *section_data,
|
||
const char *dll_name, struct objfile *objfile)
|
||
{
|
||
/* Add the stored offset to get the loaded address of the symbol. */
|
||
CORE_ADDR vma = func_rva + section_data->vma_offset;
|
||
|
||
/* Generate a (hopefully unique) qualified name using the first part
|
||
of the dll name, e.g. KERNEL32!AddAtomA. This matches the style
|
||
used by windbg from the "Microsoft Debugging Tools for Windows". */
|
||
|
||
std::string bare_name;
|
||
if (sym_name == NULL || *sym_name == '\0')
|
||
bare_name = string_printf ("#%d", ordinal);
|
||
else
|
||
bare_name = sym_name;
|
||
|
||
std::string qualified_name
|
||
= string_printf ("%s!%s", dll_name, bare_name.c_str ());
|
||
|
||
if ((section_data->ms_type == mst_unknown) && debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog , _("Unknown section type for \"%s\""
|
||
" for entry \"%s\" in dll \"%s\"\n"),
|
||
section_data->section_name.c_str (), sym_name,
|
||
dll_name);
|
||
|
||
reader.record_with_info (qualified_name.c_str (), vma, section_data->ms_type,
|
||
section_data->index);
|
||
|
||
/* Enter the plain name as well, which might not be unique. */
|
||
reader.record_with_info (bare_name.c_str (), vma, section_data->ms_type,
|
||
section_data->index);
|
||
if (debug_coff_pe_read > 1)
|
||
fprintf_unfiltered (gdb_stdlog, _("Adding exported symbol \"%s\""
|
||
" in dll \"%s\"\n"), sym_name, dll_name);
|
||
}
|
||
|
||
/* Create a minimal symbol entry for an exported forward symbol.
|
||
Return 1 if the forwarded function was found 0 otherwise.
|
||
SYM_NAME contains the exported name or NULL if exported by ordinal,
|
||
FORWARD_DLL_NAME is the name of the DLL in which the target symobl resides,
|
||
FORWARD_FUNC_NAME is the name of the target symbol in that DLL,
|
||
ORDINAL is the ordinal index value of the symbol,
|
||
DLL_NAME is the internal name of the DLL file,
|
||
OBJFILE is the objfile struct of DLL_NAME. */
|
||
|
||
static int
|
||
add_pe_forwarded_sym (minimal_symbol_reader &reader,
|
||
const char *sym_name, const char *forward_dll_name,
|
||
const char *forward_func_name, int ordinal,
|
||
const char *dll_name, struct objfile *objfile)
|
||
{
|
||
CORE_ADDR vma, baseaddr;
|
||
struct bound_minimal_symbol msymbol;
|
||
enum minimal_symbol_type msymtype;
|
||
int forward_dll_name_len = strlen (forward_dll_name);
|
||
int forward_func_name_len = strlen (forward_func_name);
|
||
int forward_len = forward_dll_name_len + forward_func_name_len + 2;
|
||
char *forward_qualified_name = (char *) alloca (forward_len);
|
||
short section;
|
||
|
||
xsnprintf (forward_qualified_name, forward_len, "%s!%s", forward_dll_name,
|
||
forward_func_name);
|
||
|
||
|
||
msymbol = lookup_bound_minimal_symbol (forward_qualified_name);
|
||
|
||
if (!msymbol.minsym)
|
||
{
|
||
int i;
|
||
|
||
for (i = 0; i < forward_dll_name_len; i++)
|
||
forward_qualified_name[i] = tolower (forward_qualified_name[i]);
|
||
msymbol = lookup_bound_minimal_symbol (forward_qualified_name);
|
||
}
|
||
|
||
if (!msymbol.minsym)
|
||
{
|
||
if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Unable to find function \"%s\" in"
|
||
" dll \"%s\", forward of \"%s\" in dll \"%s\"\n"),
|
||
forward_func_name, forward_dll_name, sym_name,
|
||
dll_name);
|
||
return 0;
|
||
}
|
||
|
||
if (debug_coff_pe_read > 1)
|
||
fprintf_unfiltered (gdb_stdlog, _("Adding forwarded exported symbol"
|
||
" \"%s\" in dll \"%s\", pointing to \"%s\"\n"),
|
||
sym_name, dll_name, forward_qualified_name);
|
||
|
||
vma = BMSYMBOL_VALUE_ADDRESS (msymbol);
|
||
msymtype = MSYMBOL_TYPE (msymbol.minsym);
|
||
section = MSYMBOL_SECTION (msymbol.minsym);
|
||
|
||
/* Generate a (hopefully unique) qualified name using the first part
|
||
of the dll name, e.g. KERNEL32!AddAtomA. This matches the style
|
||
used by windbg from the "Microsoft Debugging Tools for Windows". */
|
||
|
||
std::string bare_name;
|
||
if (sym_name == NULL || *sym_name == '\0')
|
||
bare_name = string_printf ("#%d", ordinal);
|
||
else
|
||
bare_name = sym_name;
|
||
|
||
std::string qualified_name
|
||
= string_printf ("%s!%s", dll_name, bare_name.c_str ());
|
||
|
||
/* Note that this code makes a minimal symbol whose value may point
|
||
outside of any section in this objfile. These symbols can't
|
||
really be relocated properly, but nevertheless we make a stab at
|
||
it, choosing an approach consistent with the history of this
|
||
code. */
|
||
baseaddr = objfile->section_offsets[SECT_OFF_TEXT (objfile)];
|
||
|
||
reader.record_with_info (qualified_name.c_str (), vma - baseaddr, msymtype,
|
||
section);
|
||
|
||
/* Enter the plain name as well, which might not be unique. */
|
||
reader.record_with_info (bare_name.c_str(), vma - baseaddr, msymtype,
|
||
section);
|
||
|
||
return 1;
|
||
}
|
||
|
||
/* Truncate a dll_name at the last dot character. */
|
||
|
||
static void
|
||
read_pe_truncate_name (char *dll_name)
|
||
{
|
||
char *last_point = strrchr (dll_name, '.');
|
||
|
||
if (last_point != NULL)
|
||
*last_point = '\0';
|
||
}
|
||
|
||
/* Low-level support functions, direct from the ld module pe-dll.c. */
|
||
static unsigned int
|
||
pe_get16 (bfd *abfd, int where)
|
||
{
|
||
unsigned char b[2];
|
||
|
||
bfd_seek (abfd, (file_ptr) where, SEEK_SET);
|
||
bfd_bread (b, (bfd_size_type) 2, abfd);
|
||
return b[0] + (b[1] << 8);
|
||
}
|
||
|
||
static unsigned int
|
||
pe_get32 (bfd *abfd, int where)
|
||
{
|
||
unsigned char b[4];
|
||
|
||
bfd_seek (abfd, (file_ptr) where, SEEK_SET);
|
||
bfd_bread (b, (bfd_size_type) 4, abfd);
|
||
return b[0] + (b[1] << 8) + (b[2] << 16) + (b[3] << 24);
|
||
}
|
||
|
||
static unsigned int
|
||
pe_as16 (void *ptr)
|
||
{
|
||
unsigned char *b = (unsigned char *) ptr;
|
||
|
||
return b[0] + (b[1] << 8);
|
||
}
|
||
|
||
static unsigned int
|
||
pe_as32 (void *ptr)
|
||
{
|
||
unsigned char *b = (unsigned char *) ptr;
|
||
|
||
return b[0] + (b[1] << 8) + (b[2] << 16) + (b[3] << 24);
|
||
}
|
||
|
||
/* Read the (non-debug) export symbol table from a portable
|
||
executable. Code originally lifted from the ld function
|
||
pe_implied_import_dll in pe-dll.c. */
|
||
|
||
void
|
||
read_pe_exported_syms (minimal_symbol_reader &reader,
|
||
struct objfile *objfile)
|
||
{
|
||
bfd *dll = objfile->obfd;
|
||
unsigned long nbnormal, nbforward;
|
||
unsigned long pe_header_offset, opthdr_ofs, num_entries, i;
|
||
unsigned long export_opthdrrva, export_opthdrsize;
|
||
unsigned long export_rva, export_size, nsections, secptr, expptr;
|
||
unsigned long exp_funcbase;
|
||
unsigned char *expdata, *erva;
|
||
unsigned long name_rvas, ordinals, nexp, ordbase;
|
||
char *dll_name = (char *) dll->filename;
|
||
int otherix = PE_SECTION_TABLE_SIZE;
|
||
int is_pe64 = 0;
|
||
int is_pe32 = 0;
|
||
|
||
/* Array elements are for text, data and bss in that order
|
||
Initialization with RVA_START > RVA_END guarantees that
|
||
unused sections won't be matched. */
|
||
struct pe_sections_info pe_sections_info;
|
||
|
||
char const *target = bfd_get_target (objfile->obfd);
|
||
|
||
std::vector<struct read_pe_section_data> section_data
|
||
(PE_SECTION_TABLE_SIZE);
|
||
|
||
for (i=0; i < PE_SECTION_TABLE_SIZE; i++)
|
||
{
|
||
section_data[i].vma_offset = 0;
|
||
section_data[i].rva_start = 1;
|
||
section_data[i].rva_end = 0;
|
||
};
|
||
section_data[PE_SECTION_INDEX_TEXT].ms_type = mst_text;
|
||
section_data[PE_SECTION_INDEX_TEXT].section_name = ".text";
|
||
section_data[PE_SECTION_INDEX_DATA].ms_type = mst_data;
|
||
section_data[PE_SECTION_INDEX_DATA].section_name = ".data";
|
||
section_data[PE_SECTION_INDEX_BSS].ms_type = mst_bss;
|
||
section_data[PE_SECTION_INDEX_BSS].section_name = ".bss";
|
||
|
||
is_pe64 = (strcmp (target, "pe-x86-64") == 0
|
||
|| strcmp (target, "pei-x86-64") == 0);
|
||
is_pe32 = (strcmp (target, "pe-i386") == 0
|
||
|| strcmp (target, "pei-i386") == 0
|
||
|| strcmp (target, "pe-arm-wince-little") == 0
|
||
|| strcmp (target, "pei-arm-wince-little") == 0);
|
||
if (!is_pe32 && !is_pe64)
|
||
{
|
||
/* This is not a recognized PE format file. Abort now, because
|
||
the code is untested on anything else. *FIXME* test on
|
||
further architectures and loosen or remove this test. */
|
||
return;
|
||
}
|
||
|
||
/* Get pe_header, optional header and numbers of export entries. */
|
||
pe_header_offset = pe_get32 (dll, 0x3c);
|
||
opthdr_ofs = pe_header_offset + 4 + 20;
|
||
if (is_pe64)
|
||
num_entries = pe_get32 (dll, opthdr_ofs + 108);
|
||
else
|
||
num_entries = pe_get32 (dll, opthdr_ofs + 92);
|
||
|
||
if (num_entries < 1) /* No exports. */
|
||
return;
|
||
if (is_pe64)
|
||
{
|
||
export_opthdrrva = pe_get32 (dll, opthdr_ofs + 112);
|
||
export_opthdrsize = pe_get32 (dll, opthdr_ofs + 116);
|
||
}
|
||
else
|
||
{
|
||
export_opthdrrva = pe_get32 (dll, opthdr_ofs + 96);
|
||
export_opthdrsize = pe_get32 (dll, opthdr_ofs + 100);
|
||
}
|
||
nsections = pe_get16 (dll, pe_header_offset + 4 + 2);
|
||
secptr = (pe_header_offset + 4 + 20 +
|
||
pe_get16 (dll, pe_header_offset + 4 + 16));
|
||
expptr = 0;
|
||
export_size = 0;
|
||
|
||
/* Get the rva and size of the export section. */
|
||
for (i = 0; i < nsections; i++)
|
||
{
|
||
char sname[8];
|
||
unsigned long secptr1 = secptr + 40 * i;
|
||
unsigned long vaddr = pe_get32 (dll, secptr1 + 12);
|
||
unsigned long vsize = pe_get32 (dll, secptr1 + 16);
|
||
unsigned long fptr = pe_get32 (dll, secptr1 + 20);
|
||
|
||
bfd_seek (dll, (file_ptr) secptr1, SEEK_SET);
|
||
bfd_bread (sname, (bfd_size_type) sizeof (sname), dll);
|
||
|
||
if ((strcmp (sname, ".edata") == 0)
|
||
|| (vaddr <= export_opthdrrva && export_opthdrrva < vaddr + vsize))
|
||
{
|
||
if (strcmp (sname, ".edata") != 0)
|
||
{
|
||
if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Export RVA for dll "
|
||
"\"%s\" is in section \"%s\"\n"),
|
||
dll_name, sname);
|
||
}
|
||
else if (export_opthdrrva != vaddr && debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Wrong value of export RVA"
|
||
" for dll \"%s\": 0x%lx instead of 0x%lx\n"),
|
||
dll_name, export_opthdrrva, vaddr);
|
||
expptr = fptr + (export_opthdrrva - vaddr);
|
||
break;
|
||
}
|
||
}
|
||
|
||
if (expptr == 0)
|
||
{
|
||
/* no section contains export table rva */
|
||
return;
|
||
}
|
||
|
||
export_rva = export_opthdrrva;
|
||
export_size = export_opthdrsize;
|
||
|
||
if (export_size == 0)
|
||
{
|
||
/* Empty export table. */
|
||
return;
|
||
}
|
||
|
||
/* Scan sections and store the base and size of the relevant
|
||
sections. */
|
||
for (i = 0; i < nsections; i++)
|
||
{
|
||
unsigned long secptr1 = secptr + 40 * i;
|
||
unsigned long vsize = pe_get32 (dll, secptr1 + 8);
|
||
unsigned long vaddr = pe_get32 (dll, secptr1 + 12);
|
||
unsigned long characteristics = pe_get32 (dll, secptr1 + 36);
|
||
char sec_name[SCNNMLEN + 1];
|
||
int sectix;
|
||
unsigned int bfd_section_index;
|
||
asection *section;
|
||
|
||
bfd_seek (dll, (file_ptr) secptr1 + 0, SEEK_SET);
|
||
bfd_bread (sec_name, (bfd_size_type) SCNNMLEN, dll);
|
||
sec_name[SCNNMLEN] = '\0';
|
||
|
||
sectix = read_pe_section_index (sec_name);
|
||
section = bfd_get_section_by_name (dll, sec_name);
|
||
if (section)
|
||
bfd_section_index = section->index;
|
||
else
|
||
bfd_section_index = -1;
|
||
|
||
if (sectix != PE_SECTION_INDEX_INVALID)
|
||
{
|
||
section_data[sectix].rva_start = vaddr;
|
||
section_data[sectix].rva_end = vaddr + vsize;
|
||
section_data[sectix].index = bfd_section_index;
|
||
}
|
||
else
|
||
{
|
||
section_data.resize (otherix + 1);
|
||
section_data[otherix].section_name = sec_name;
|
||
section_data[otherix].rva_start = vaddr;
|
||
section_data[otherix].rva_end = vaddr + vsize;
|
||
section_data[otherix].vma_offset = 0;
|
||
section_data[otherix].index = bfd_section_index;
|
||
if (characteristics & IMAGE_SCN_CNT_CODE)
|
||
section_data[otherix].ms_type = mst_text;
|
||
else if (characteristics & IMAGE_SCN_CNT_INITIALIZED_DATA)
|
||
section_data[otherix].ms_type = mst_data;
|
||
else if (characteristics & IMAGE_SCN_CNT_UNINITIALIZED_DATA)
|
||
section_data[otherix].ms_type = mst_bss;
|
||
else
|
||
section_data[otherix].ms_type = mst_unknown;
|
||
otherix++;
|
||
}
|
||
}
|
||
|
||
gdb::def_vector<unsigned char> expdata_storage (export_size);
|
||
expdata = expdata_storage.data ();
|
||
|
||
bfd_seek (dll, (file_ptr) expptr, SEEK_SET);
|
||
bfd_bread (expdata, (bfd_size_type) export_size, dll);
|
||
erva = expdata - export_rva;
|
||
|
||
nexp = pe_as32 (expdata + 24);
|
||
name_rvas = pe_as32 (expdata + 32);
|
||
ordinals = pe_as32 (expdata + 36);
|
||
ordbase = pe_as32 (expdata + 16);
|
||
exp_funcbase = pe_as32 (expdata + 28);
|
||
|
||
/* Use internal dll name instead of full pathname. */
|
||
dll_name = (char *) (pe_as32 (expdata + 12) + erva);
|
||
|
||
pe_sections_info.nb_sections = otherix;
|
||
pe_sections_info.sections = section_data.data ();
|
||
|
||
bfd_map_over_sections (dll, get_section_vmas, &pe_sections_info);
|
||
|
||
/* Truncate name at first dot. Should maybe also convert to all
|
||
lower case for convenience on Windows. */
|
||
read_pe_truncate_name (dll_name);
|
||
|
||
if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("DLL \"%s\" has %ld export entries,"
|
||
" base=%ld\n"), dll_name, nexp, ordbase);
|
||
nbforward = 0;
|
||
nbnormal = 0;
|
||
/* Iterate through the list of symbols. */
|
||
for (i = 0; i < nexp; i++)
|
||
{
|
||
/* Pointer to the names vector. */
|
||
unsigned long name_rva = pe_as32 (erva + name_rvas + i * 4);
|
||
/* Retrieve ordinal value. */
|
||
|
||
unsigned long ordinal = pe_as16 (erva + ordinals + i * 2);
|
||
|
||
|
||
/* Pointer to the function address vector. */
|
||
/* This is relative to ordinal value. */
|
||
unsigned long func_rva = pe_as32 (erva + exp_funcbase +
|
||
ordinal * 4);
|
||
|
||
/* Find this symbol's section in our own array. */
|
||
int sectix = 0;
|
||
int section_found = 0;
|
||
|
||
/* First handle forward cases. */
|
||
if (func_rva >= export_rva && func_rva < export_rva + export_size)
|
||
{
|
||
char *forward_name = (char *) (erva + func_rva);
|
||
char *funcname = (char *) (erva + name_rva);
|
||
char *forward_dll_name = forward_name;
|
||
char *forward_func_name = forward_name;
|
||
char *sep = strrchr (forward_name, '.');
|
||
|
||
if (sep)
|
||
{
|
||
int len = (int) (sep - forward_name);
|
||
|
||
forward_dll_name = (char *) alloca (len + 1);
|
||
strncpy (forward_dll_name, forward_name, len);
|
||
forward_dll_name[len] = '\0';
|
||
forward_func_name = ++sep;
|
||
}
|
||
if (add_pe_forwarded_sym (reader, funcname, forward_dll_name,
|
||
forward_func_name, ordinal,
|
||
dll_name, objfile) != 0)
|
||
++nbforward;
|
||
continue;
|
||
}
|
||
|
||
for (sectix = 0; sectix < otherix; ++sectix)
|
||
{
|
||
if ((func_rva >= section_data[sectix].rva_start)
|
||
&& (func_rva < section_data[sectix].rva_end))
|
||
{
|
||
char *sym_name = (char *) (erva + name_rva);
|
||
|
||
section_found = 1;
|
||
add_pe_exported_sym (reader, sym_name, func_rva, ordinal,
|
||
§ion_data[sectix], dll_name, objfile);
|
||
++nbnormal;
|
||
break;
|
||
}
|
||
}
|
||
if (!section_found)
|
||
{
|
||
char *funcname = (char *) (erva + name_rva);
|
||
|
||
if (name_rva == 0)
|
||
{
|
||
add_pe_exported_sym (reader, NULL, func_rva, ordinal,
|
||
§ion_data[0], dll_name, objfile);
|
||
++nbnormal;
|
||
}
|
||
else if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Export name \"%s\" ord. %lu,"
|
||
" RVA 0x%lx in dll \"%s\" not handled\n"),
|
||
funcname, ordinal, func_rva, dll_name);
|
||
}
|
||
}
|
||
|
||
if (debug_coff_pe_read)
|
||
fprintf_unfiltered (gdb_stdlog, _("Finished reading \"%s\", exports %ld,"
|
||
" forwards %ld, total %ld/%ld.\n"), dll_name, nbnormal,
|
||
nbforward, nbnormal + nbforward, nexp);
|
||
}
|
||
|
||
/* Extract from ABFD the offset of the .text section.
|
||
This offset is mainly related to the offset within the file.
|
||
The value was previously expected to be 0x1000 for all files,
|
||
but some Windows OS core DLLs seem to use 0x10000 section alignment
|
||
which modified the return value of that function.
|
||
Still return default 0x1000 value if ABFD is NULL or
|
||
if '.text' section is not found, but that should not happen... */
|
||
|
||
#define DEFAULT_COFF_PE_TEXT_SECTION_OFFSET 0x1000
|
||
|
||
CORE_ADDR
|
||
pe_text_section_offset (struct bfd *abfd)
|
||
|
||
{
|
||
unsigned long pe_header_offset, i;
|
||
unsigned long nsections, secptr;
|
||
int is_pe64 = 0;
|
||
int is_pe32 = 0;
|
||
char const *target;
|
||
|
||
if (!abfd)
|
||
return DEFAULT_COFF_PE_TEXT_SECTION_OFFSET;
|
||
|
||
target = bfd_get_target (abfd);
|
||
|
||
is_pe64 = (strcmp (target, "pe-x86-64") == 0
|
||
|| strcmp (target, "pei-x86-64") == 0);
|
||
is_pe32 = (strcmp (target, "pe-i386") == 0
|
||
|| strcmp (target, "pei-i386") == 0
|
||
|| strcmp (target, "pe-arm-wince-little") == 0
|
||
|| strcmp (target, "pei-arm-wince-little") == 0);
|
||
|
||
if (!is_pe32 && !is_pe64)
|
||
{
|
||
/* This is not a recognized PE format file. Abort now, because
|
||
the code is untested on anything else. *FIXME* test on
|
||
further architectures and loosen or remove this test. */
|
||
return DEFAULT_COFF_PE_TEXT_SECTION_OFFSET;
|
||
}
|
||
|
||
/* Get pe_header, optional header and numbers of sections. */
|
||
pe_header_offset = pe_get32 (abfd, 0x3c);
|
||
nsections = pe_get16 (abfd, pe_header_offset + 4 + 2);
|
||
secptr = (pe_header_offset + 4 + 20 +
|
||
pe_get16 (abfd, pe_header_offset + 4 + 16));
|
||
|
||
/* Get the rva and size of the export section. */
|
||
for (i = 0; i < nsections; i++)
|
||
{
|
||
char sname[SCNNMLEN + 1];
|
||
unsigned long secptr1 = secptr + 40 * i;
|
||
unsigned long vaddr = pe_get32 (abfd, secptr1 + 12);
|
||
|
||
bfd_seek (abfd, (file_ptr) secptr1, SEEK_SET);
|
||
bfd_bread (sname, (bfd_size_type) SCNNMLEN, abfd);
|
||
sname[SCNNMLEN] = '\0';
|
||
if (strcmp (sname, ".text") == 0)
|
||
return vaddr;
|
||
}
|
||
|
||
return DEFAULT_COFF_PE_TEXT_SECTION_OFFSET;
|
||
}
|
||
|
||
/* Implements "show debug coff_pe_read" command. */
|
||
|
||
static void
|
||
show_debug_coff_pe_read (struct ui_file *file, int from_tty,
|
||
struct cmd_list_element *c, const char *value)
|
||
{
|
||
fprintf_filtered (file, _("Coff PE read debugging is %s.\n"), value);
|
||
}
|
||
|
||
/* Adds "Set/show debug coff_pe_read" commands. */
|
||
|
||
void _initialize_coff_pe_read ();
|
||
void
|
||
_initialize_coff_pe_read ()
|
||
{
|
||
add_setshow_zuinteger_cmd ("coff-pe-read", class_maintenance,
|
||
&debug_coff_pe_read,
|
||
_("Set coff PE read debugging."),
|
||
_("Show coff PE read debugging."),
|
||
_("When set, debugging messages for coff reading "
|
||
"of exported symbols are displayed."),
|
||
NULL, show_debug_coff_pe_read,
|
||
&setdebuglist, &showdebuglist);
|
||
}
|