mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-11 19:33:33 +08:00
0f6329bd7f
When elf section size is beyond unsigned int max value, objdump fails
to disassemble from that section. Ex on PowerPC,
$ objdump -h /proc/kcore
Idx Name Size VMA
4 load2 100000000 c000000000000000
Here, size of load2 section is 0x100000000. Also note that, 0xc00....
address range is kernel space for PowerPC. Now let's try to disassemble
do_sys_open() using /proc/kcore.
$ cat /proc/kallsyms | grep -A1 -w do_sys_open
c00000000036c000 T do_sys_open
c00000000036c2d0 T SyS_open
Before patch:
$ objdump -d --start-address=0xc00000000036c000 --stop-address=0xc00000000036c2d0 /proc/kcore
/proc/kcore: file format elf64-powerpcle
Disassembly of section load2:
c00000000036c000 <load2+0x36c000>:
c00000000036c000: Address 0xc00000000036c000 is out of bounds.
Fix this by changing type of 'buffer_length' from unsigned int to
size_t. After patch:
$ objdump -d --start-address=0xc00000000036c000 --stop-address=0xc00000000036c2d0 /proc/kcore
/proc/kcore: file format elf64-powerpcle
Disassembly of section load2:
c00000000036c000 <load2+0x36c000>:
c00000000036c000: fc 00 4c 3c addis r2,r12,252
c00000000036c004: 00 53 42 38 addi r2,r2,21248
c00000000036c008: a6 02 08 7c mflr r0
include/
* dis-asm.h (struct disassemble_info): Change type of buffer_length
field to size_t.
opcodes/
* dis-buf.c (buffer_read_memory): Change type of end_addr_offset,
max_addr_offset and octets variables to size_t.
107 lines
3.1 KiB
C
107 lines
3.1 KiB
C
/* Disassemble from a buffer, for GNU.
|
|
Copyright (C) 1993-2017 Free Software Foundation, Inc.
|
|
|
|
This file is part of the GNU opcodes library.
|
|
|
|
This library is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3, or (at your option)
|
|
any later version.
|
|
|
|
It is distributed in the hope that it will be useful, but WITHOUT
|
|
ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
|
|
or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public
|
|
License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
|
MA 02110-1301, USA. */
|
|
|
|
#include "sysdep.h"
|
|
#include "dis-asm.h"
|
|
#include <errno.h>
|
|
#include "opintl.h"
|
|
|
|
/* Get LENGTH bytes from info's buffer, at target address memaddr.
|
|
Transfer them to myaddr. */
|
|
int
|
|
buffer_read_memory (bfd_vma memaddr,
|
|
bfd_byte *myaddr,
|
|
unsigned int length,
|
|
struct disassemble_info *info)
|
|
{
|
|
unsigned int opb = info->octets_per_byte;
|
|
size_t end_addr_offset = length / opb;
|
|
size_t max_addr_offset = info->buffer_length / opb;
|
|
size_t octets = (memaddr - info->buffer_vma) * opb;
|
|
|
|
if (memaddr < info->buffer_vma
|
|
|| memaddr - info->buffer_vma > max_addr_offset
|
|
|| memaddr - info->buffer_vma + end_addr_offset > max_addr_offset
|
|
|| (info->stop_vma && (memaddr >= info->stop_vma
|
|
|| memaddr + end_addr_offset > info->stop_vma)))
|
|
/* Out of bounds. Use EIO because GDB uses it. */
|
|
return EIO;
|
|
memcpy (myaddr, info->buffer + octets, length);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/* Print an error message. We can assume that this is in response to
|
|
an error return from buffer_read_memory. */
|
|
|
|
void
|
|
perror_memory (int status,
|
|
bfd_vma memaddr,
|
|
struct disassemble_info *info)
|
|
{
|
|
if (status != EIO)
|
|
/* Can't happen. */
|
|
info->fprintf_func (info->stream, _("Unknown error %d\n"), status);
|
|
else
|
|
{
|
|
char buf[30];
|
|
|
|
/* Actually, address between memaddr and memaddr + len was
|
|
out of bounds. */
|
|
sprintf_vma (buf, memaddr);
|
|
info->fprintf_func (info->stream,
|
|
_("Address 0x%s is out of bounds.\n"), buf);
|
|
}
|
|
}
|
|
|
|
/* This could be in a separate file, to save miniscule amounts of space
|
|
in statically linked executables. */
|
|
|
|
/* Just print the address is hex. This is included for completeness even
|
|
though both GDB and objdump provide their own (to print symbolic
|
|
addresses). */
|
|
|
|
void
|
|
generic_print_address (bfd_vma addr, struct disassemble_info *info)
|
|
{
|
|
char buf[30];
|
|
|
|
sprintf_vma (buf, addr);
|
|
(*info->fprintf_func) (info->stream, "0x%s", buf);
|
|
}
|
|
|
|
/* Just return true. */
|
|
|
|
int
|
|
generic_symbol_at_address (bfd_vma addr ATTRIBUTE_UNUSED,
|
|
struct disassemble_info *info ATTRIBUTE_UNUSED)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
/* Just return TRUE. */
|
|
|
|
bfd_boolean
|
|
generic_symbol_is_valid (asymbol * sym ATTRIBUTE_UNUSED,
|
|
struct disassemble_info *info ATTRIBUTE_UNUSED)
|
|
{
|
|
return TRUE;
|
|
}
|