Go to file
Simon Marchi 9a93831ccc Fix syscall group completion
The test gdb.base/catch-syscall.exp has been failing since commit

  3d415c26ba
  Remove cleanups from break-catch-syscall.c

The reason is that we are putting into the group_ptr array a pointer to
the buffer of the local string object.  If the string is small enough to
fit in the internal string buffer (used for small string optimizations),
the pointer will point to the local object directly.  So even if we
std::move the string to the vector, the pointer in group_ptr will still
point to the local object.  When we reuse that object (technically a new
instance, but most likely the same memory) for the next syscall, we'll
overwrite the previous string.  The result is that we'll get less
results than expected, since there will be duplicates.

We'll also run into problems if we push the string to the vector, and
then record the c_str () pointer using the string object in the vector.
The vector might get reallocated, the string may move in memory, and our
pointer in group_ptr will point to stale memory.

Instead, we have to push all the strings first, then, when we know the
vector won't change anymore, build the group_ptr array.  This is what
this patch does.

gdb/ChangeLog:

	* break-catch-syscall.c (catch_syscall_completer): Get pointers
	to syscall group strings after building the string vector.
2017-12-06 16:37:29 -05:00
bfd BFD whitespace fixes 2017-12-06 17:51:43 +10:30
binutils Objcopy interleave fails if section address not multiple of interleave. 2017-12-06 10:34:36 -08:00
config
cpu
elfcpp oops - changelog entry omitted from previous delta 2017-09-21 09:07:11 +01:00
etc
gas Documentation fix 2017-12-04 22:26:32 +10:30
gdb Fix syscall group completion 2017-12-06 16:37:29 -05:00
gold Handle case where posix_fallocate is not supported for a filesystem. 2017-12-02 09:56:40 -08:00
gprof Support --localedir, --datarootdir and --datadir 2017-11-29 20:10:52 +10:30
include Use consistent types for holding instructions, instruction masks, etc. 2017-12-01 11:20:15 -06:00
intl Require ngettext in test of system gettext implementation 2017-11-07 15:56:44 +10:30
ld Objcopy interleave fails if section address not multiple of interleave. 2017-12-06 10:34:36 -08:00
libdecnumber
libiberty
opcodes Fix "FAIL: VLE relocations 3" 2017-12-03 21:54:47 +10:30
readline
sim FT32: support for FT32B processor - part 2/2 2017-11-01 18:36:51 -07:00
texinfo
zlib
.cvsignore
.gitattributes
.gitignore
ChangeLog
compile
config-ml.in
config.guess
config.rpath
config.sub
configure
configure.ac
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.LIBGLOSS
COPYING.NEWLIB
depcomp
djunpack.bat
install-sh
libtool.m4
lt~obsolete.m4
ltgcc.m4
ltmain.sh
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS
Makefile.def
Makefile.in
Makefile.tpl
makefile.vms
missing
mkdep
mkinstalldirs
move-if-change
README
README-maintainer-mode
setup.com
src-release.sh
symlink-tree
ylwrap

		   README for GNU development tools

This directory contains various GNU compilers, assemblers, linkers, 
debuggers, etc., plus their support routines, definitions, and documentation.

If you are receiving this as part of a GDB release, see the file gdb/README.
If with a binutils release, see binutils/README;  if with a libg++ release,
see libg++/README, etc.  That'll give you info about this
package -- supported targets, how to use it, how to report bugs, etc.

It is now possible to automatically configure and build a variety of
tools with one command.  To build all of the tools contained herein,
run the ``configure'' script here, e.g.:

	./configure 
	make

To install them (by default in /usr/local/bin, /usr/local/lib, etc),
then do:
	make install

(If the configure script can't determine your type of computer, give it
the name as an argument, for instance ``./configure sun4''.  You can
use the script ``config.sub'' to test whether a name is recognized; if
it is, config.sub translates it to a triplet specifying CPU, vendor,
and OS.)

If you have more than one compiler on your system, it is often best to
explicitly set CC in the environment before running configure, and to
also set CC when running make.  For example (assuming sh/bash/ksh):

	CC=gcc ./configure
	make

A similar example using csh:

	setenv CC gcc
	./configure
	make

Much of the code and documentation enclosed is copyright by
the Free Software Foundation, Inc.  See the file COPYING or
COPYING.LIB in the various directories, for a description of the
GNU General Public License terms under which you can copy the files.

REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info
on where and how to report problems.