binutils-gdb/gdb/regformats
Joel Brobecker 190852c8ac gdbserver/Windows: crash during connection establishment phase
On Windows, starting a new process with GDBserver seems to work,
in the sense that the program does get started, and GDBserver
confirms that it is listening for GDB to connect. However, as soon as
GDB establishes the connection with GDBserver, and starts discussing
with it, GDBserver crashes, with a SEGV.

This SEGV occurs in remote-utils.c::prepare_resume_reply...

  | regp = current_target_desc ()->expedite_regs;
  | [...]
  | while (*regp)

... because, in our case, REGP is NULL.

This patches fixes the issues by adding a parameter to init_target_desc,
in order to make sure that we always provide the list of registers when
we initialize a target description.

gdb/ChangeLog:

        PR server/23158:
        * regformats/regdat.sh: Adjust script, following the addition
        of the new expedite_regs parameter to init_target_desc.

gdb/gdbserver/ChangeLog:

        PR server/23158:
        * tdesc.h (init_target_desc) <expedite_regs>: New parameter.
        * tdesc.c (init_target_desc) <expedite_regs>: New parameter.
        Use it to set the expedite_regs field in the given tdesc.
        * x86-tdesc.h: New file.
        * linux-aarch64-tdesc.c (aarch64_linux_read_description):
        Adjust following the addition of the new expedite_regs parameter
        to init_target_desc.
        * linux-tic6x-low.c (tic6x_read_description): Likewise.
        * linux-x86-tdesc.c: #include "x86-tdesc.h".
        (i386_linux_read_description, amd64_linux_read_description):
        Adjust following the addition of the new expedite_regs parameter
        to init_target_desc.
        * lynx-i386-low.c: #include "x86-tdesc.h".
        (lynx_i386_arch_setup): Adjust following the addition of the new
        expedite_regs parameter to init_target_desc.
        * nto-x86-low.c: #include "x86-tdesc.h".
        (nto_x86_arch_setup): Adjust following the addition of the new
        expedite_regs parameter to init_target_desc.
        * win32-i386-low.c: #include "x86-tdesc.h".
        (i386_arch_setup): Adjust following the addition of the new
        expedite_regs parameter to init_target_desc.
2018-05-10 11:27:13 -04:00
..
arm
i386 Add feature reference in .dat files 2018-04-18 20:08:42 +01:00
rs6000
aarch64.dat Add feature reference in .dat files 2018-04-18 20:08:42 +01:00
microblaze-with-stack-protect.dat
mips64-dsp-linux.dat
mips64-linux.dat
mips-dsp-linux.dat
mips-linux.dat
nios2-linux.dat
reg-arm.dat
reg-bfin.dat
reg-cf.dat
reg-cris.dat
reg-crisv32.dat
reg-ia64.dat
reg-m32r.dat
reg-m68k.dat
reg-sh.dat
reg-sparc64.dat
reg-spu.dat
reg-tilegx32.dat
reg-tilegx.dat
reg-xtensa.dat
regdat.sh gdbserver/Windows: crash during connection establishment phase 2018-05-10 11:27:13 -04:00
regdef.h Commonise tdesc_reg and makes use of it in gdbserver tdesc 2018-04-18 14:00:30 +01:00
s390-gs-linux64.dat
s390-linux32.dat
s390-linux32v1.dat
s390-linux32v2.dat
s390-linux64.dat
s390-linux64v1.dat
s390-linux64v2.dat
s390-te-linux64.dat
s390-tevx-linux64.dat
s390-vx-linux64.dat
s390x-gs-linux64.dat
s390x-linux64.dat
s390x-linux64v1.dat
s390x-linux64v2.dat
s390x-te-linux64.dat
s390x-tevx-linux64.dat
s390x-vx-linux64.dat
tic6x-c62x-linux.dat Add feature reference in .dat files 2018-04-18 20:08:42 +01:00
tic6x-c64x-linux.dat Add feature reference in .dat files 2018-04-18 20:08:42 +01:00
tic6x-c64xp-linux.dat Add feature reference in .dat files 2018-04-18 20:08:42 +01:00