mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-27 20:14:06 +08:00
34f997c8f7
After the commit:
commit 6647f05df0
Date: Tue Jan 24 18:13:38 2023 +0100
gdb: defer warnings when loading separate debug files
It was pointed out[1] that the warnings being deferred and then later
emitted lacked styling. The warnings lacked styling before the above
commit, but it was suggested that the filenames in these warnings
should be styled, and this commit does this.
There were a couple of previous attempts[2][3][4] to solve this
problem, but these all tried to extend the mechanism introduced in the
above commit, the deferred warnings were placed directly into a
std::vector, but now we tried to, when appropriate, style these
warnings. The review feedback that this approach looked too complex.
So instead, this revision adds a new helper class 'deferred_warnings'
which can be used to collect a set of deferred warnings, and then emit
these deferred warnings later, if needed. This helper class hides the
complexity, so at the point the deferred warning is created no extra
logic is required.
The deferred_warnings class will style the deferred warnings only if
gdb_stderr supports styling. GDB's warnings are sent to gdb_stderr,
so this should ensure we only style when expected.
There was also review feedback[5] that all of the warnings should be
bundled into a single string_file, this has not been done. I feel
pretty strongly that separate warnings should be emitted using
separate "warning" calls. If we do end up with multiple warnings in
this case they aren't really related, one will be about looking up
debug via .gnu_debuglink, while the other will be about build-id based
lookup. So I'd really rather keep the warnings separate.
[1] https://inbox.sourceware.org/gdb-patches/87edr9pcku.fsf@tromey.com/
[2] https://inbox.sourceware.org/gdb-patches/20230216195604.2685177-1-ahajkova@redhat.com/
[3] https://inbox.sourceware.org/gdb-patches/20230217123547.2737612-1-ahajkova@redhat.com/
[4] https://inbox.sourceware.org/gdb-patches/20230320145638.1202335-1-ahajkova@redhat.com/
[5] https://inbox.sourceware.org/gdb-patches/87o7nh1g8h.fsf@tromey.com/
Co-Authored-By: Alexandra Hájková <ahajkova@redhat.com>
Approved-By: Simon Marchi <simon.marchi@efficios.com>
74 lines
2.5 KiB
C++
74 lines
2.5 KiB
C++
/* build-id-related functions.
|
|
|
|
Copyright (C) 1991-2023 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef BUILD_ID_H
|
|
#define BUILD_ID_H
|
|
|
|
#include "gdb_bfd.h"
|
|
#include "gdbsupport/rsp-low.h"
|
|
|
|
/* Locate NT_GNU_BUILD_ID from ABFD and return its content. */
|
|
|
|
extern const struct bfd_build_id *build_id_bfd_get (bfd *abfd);
|
|
|
|
/* Return true if ABFD has NT_GNU_BUILD_ID matching the CHECK value.
|
|
Otherwise, issue a warning and return false. */
|
|
|
|
extern int build_id_verify (bfd *abfd,
|
|
size_t check_len, const bfd_byte *check);
|
|
|
|
|
|
/* Find and open a BFD for a debuginfo file given a build-id. If no BFD
|
|
can be found, return NULL. */
|
|
|
|
extern gdb_bfd_ref_ptr build_id_to_debug_bfd (size_t build_id_len,
|
|
const bfd_byte *build_id);
|
|
|
|
/* Find and open a BFD for an executable file given a build-id. If no BFD
|
|
can be found, return NULL. The returned reference to the BFD must be
|
|
released by the caller. */
|
|
|
|
extern gdb_bfd_ref_ptr build_id_to_exec_bfd (size_t build_id_len,
|
|
const bfd_byte *build_id);
|
|
|
|
/* Find the separate debug file for OBJFILE, by using the build-id
|
|
associated with OBJFILE's BFD. If successful, returns the file name for the
|
|
separate debug file, otherwise, return an empty string.
|
|
|
|
Any warnings that are generated by the lookup process should be added to
|
|
WARNINGS. If some other mechanism can be used to lookup the debug
|
|
information then the warning will not be shown, however, if GDB fails to
|
|
find suitable debug information using any approach, then any warnings
|
|
will be printed. */
|
|
|
|
extern std::string find_separate_debug_file_by_buildid
|
|
(struct objfile *objfile, deferred_warnings *warnings);
|
|
|
|
/* Return an hex-string representation of BUILD_ID. */
|
|
|
|
static inline std::string
|
|
build_id_to_string (const bfd_build_id *build_id)
|
|
{
|
|
gdb_assert (build_id != NULL);
|
|
|
|
return bin2hex (build_id->data, build_id->size);
|
|
}
|
|
|
|
#endif /* BUILD_ID_H */
|