mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-30 13:33:53 +08:00
08106042d9
I built GDB for all targets on a x86-64/GNU-Linux system, and then (accidentally) passed GDB a RISC-V binary, and asked GDB to "run" the binary on the native target. I got this error: (gdb) show architecture The target architecture is set to "auto" (currently "i386"). (gdb) file /tmp/hello.rv32.exe Reading symbols from /tmp/hello.rv32.exe... (gdb) show architecture The target architecture is set to "auto" (currently "riscv:rv32"). (gdb) run Starting program: /tmp/hello.rv32.exe ../../src/gdb/i387-tdep.c:596: internal-error: i387_supply_fxsave: Assertion `tdep->st0_regnum >= I386_ST0_REGNUM' failed. What's going on here is this; initially the architecture is i386, this is based on the default architecture, which is set based on the native target. After loading the RISC-V executable the architecture of the current inferior is updated based on the architecture of the executable. When we "run", GDB does a fork & exec, with the inferior being controlled through ptrace. GDB sees an initial stop from the inferior as soon as the inferior comes to life. In response to this stop GDB ends up calling save_stop_reason (linux-nat.c), which ends up trying to read register from the inferior, to do this we end up calling target_ops::fetch_registers, which, for the x86-64 native target, calls amd64_linux_nat_target::fetch_registers. After this I eventually end up in i387_supply_fxsave, different x86 based targets will end in different functions to fetch registers, but it doesn't really matter which function we end up in, the problem is this line, which is repeated in many places: i386_gdbarch_tdep *tdep = (i386_gdbarch_tdep *) gdbarch_tdep (arch); The problem here is that the ARCH in this line comes from the current inferior, which, as we discussed above, will be a RISC-V gdbarch, the tdep field will actually be of type riscv_gdbarch_tdep, not i386_gdbarch_tdep. After this cast we are relying on undefined behaviour, in my case I happen to trigger an assert, but this might not always be the case. The thing I tried that exposed this problem was of course, trying to start an executable of the wrong architecture on a native target. I don't think that the correct solution for this problem is to detect, at the point of cast, that the gdbarch_tdep object is of the wrong type, but, I did wonder, is there a way that we could protect ourselves from incorrectly casting the gdbarch_tdep object? I think that there is something we can do here, and this commit is the first step in that direction, though no actual check is added by this commit. This commit can be split into two parts: (1) In gdbarch.h and arch-utils.c. In these files I have modified gdbarch_tdep (the function) so that it now takes a template argument, like this: template<typename TDepType> static inline TDepType * gdbarch_tdep (struct gdbarch *gdbarch) { struct gdbarch_tdep *tdep = gdbarch_tdep_1 (gdbarch); return static_cast<TDepType *> (tdep); } After this change we are no better protected, but the cast is now done within the gdbarch_tdep function rather than at the call sites, this leads to the second, much larger change in this commit, (2) Everywhere gdbarch_tdep is called, we make changes like this: - i386_gdbarch_tdep *tdep = (i386_gdbarch_tdep *) gdbarch_tdep (arch); + i386_gdbarch_tdep *tdep = gdbarch_tdep<i386_gdbarch_tdep> (arch); There should be no functional change after this commit. In the next commit I will build on this change to add an assertion in gdbarch_tdep that checks we are casting to the correct type.
202 lines
5.5 KiB
C
202 lines
5.5 KiB
C
/* Target-dependent code for the GNU Hurd.
|
|
Copyright (C) 2002-2022 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "gdbcore.h"
|
|
#include "osabi.h"
|
|
#include "solib-svr4.h"
|
|
|
|
#include "i386-tdep.h"
|
|
|
|
/* Recognizing signal handler frames. */
|
|
|
|
/* When the GNU/Hurd libc calls a signal handler, the return address points
|
|
inside the trampoline assembly snippet.
|
|
|
|
If the trampoline function name can not be identified, we resort to reading
|
|
memory from the process in order to identify it. */
|
|
|
|
static const gdb_byte gnu_sigtramp_code[] =
|
|
{
|
|
/* rpc_wait_trampoline: */
|
|
0xb8, 0xe7, 0xff, 0xff, 0xff, /* mov $-25,%eax */
|
|
0x9a, 0x00, 0x00, 0x00, 0x00, 0x07, 0x00, /* lcall $7,$0 */
|
|
0x89, 0x01, /* movl %eax, (%ecx) */
|
|
0x89, 0xdc, /* movl %ebx, %esp */
|
|
|
|
/* trampoline: */
|
|
0xff, 0xd2, /* call *%edx */
|
|
/* RA HERE */
|
|
0x83, 0xc4, 0x0c, /* addl $12, %esp */
|
|
0xc3, /* ret */
|
|
|
|
/* firewall: */
|
|
0xf4, /* hlt */
|
|
};
|
|
|
|
#define GNU_SIGTRAMP_LEN (sizeof gnu_sigtramp_code)
|
|
#define GNU_SIGTRAMP_TAIL 5 /* length of tail after RA */
|
|
|
|
/* If THIS_FRAME is a sigtramp routine, return the address of the
|
|
start of the routine. Otherwise, return 0. */
|
|
|
|
static CORE_ADDR
|
|
i386_gnu_sigtramp_start (struct frame_info *this_frame)
|
|
{
|
|
CORE_ADDR pc = get_frame_pc (this_frame);
|
|
gdb_byte buf[GNU_SIGTRAMP_LEN];
|
|
|
|
if (!safe_frame_unwind_memory (this_frame,
|
|
pc + GNU_SIGTRAMP_TAIL - GNU_SIGTRAMP_LEN,
|
|
buf))
|
|
return 0;
|
|
|
|
if (memcmp (buf, gnu_sigtramp_code, GNU_SIGTRAMP_LEN) != 0)
|
|
return 0;
|
|
|
|
return pc;
|
|
}
|
|
|
|
/* Return whether THIS_FRAME corresponds to a GNU/Linux sigtramp
|
|
routine. */
|
|
|
|
static int
|
|
i386_gnu_sigtramp_p (struct frame_info *this_frame)
|
|
{
|
|
CORE_ADDR pc = get_frame_pc (this_frame);
|
|
const char *name;
|
|
|
|
find_pc_partial_function (pc, &name, NULL, NULL);
|
|
|
|
/* If we have a NAME, we can check for the trampoline function */
|
|
if (name != NULL && strcmp (name, "trampoline") == 0)
|
|
return 1;
|
|
|
|
return i386_gnu_sigtramp_start (this_frame) != 0;
|
|
}
|
|
|
|
/* Offset to sc_i386_thread_state in sigcontext, from <bits/sigcontext.h>. */
|
|
#define I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET 20
|
|
|
|
/* Assuming THIS_FRAME is a GNU/Linux sigtramp routine, return the
|
|
address of the associated sigcontext structure. */
|
|
|
|
static CORE_ADDR
|
|
i386_gnu_sigcontext_addr (struct frame_info *this_frame)
|
|
{
|
|
struct gdbarch *gdbarch = get_frame_arch (this_frame);
|
|
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
|
CORE_ADDR pc;
|
|
CORE_ADDR sp;
|
|
gdb_byte buf[4];
|
|
|
|
get_frame_register (this_frame, I386_ESP_REGNUM, buf);
|
|
sp = extract_unsigned_integer (buf, 4, byte_order);
|
|
|
|
pc = i386_gnu_sigtramp_start (this_frame);
|
|
if (pc)
|
|
{
|
|
CORE_ADDR sigcontext_addr;
|
|
|
|
/* The sigcontext structure address is passed as the third argument to
|
|
the signal handler. */
|
|
read_memory (sp + 8, buf, 4);
|
|
sigcontext_addr = extract_unsigned_integer (buf, 4, byte_order);
|
|
return sigcontext_addr + I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET;
|
|
}
|
|
|
|
error (_("Couldn't recognize signal trampoline."));
|
|
return 0;
|
|
}
|
|
|
|
/* Mapping between the general-purpose registers in `struct
|
|
sigcontext' format (starting at sc_i386_thread_state)
|
|
and GDB's register cache layout. */
|
|
|
|
/* From <bits/sigcontext.h>. */
|
|
static int i386_gnu_sc_reg_offset[] =
|
|
{
|
|
11 * 4, /* %eax */
|
|
10 * 4, /* %ecx */
|
|
9 * 4, /* %edx */
|
|
8 * 4, /* %ebx */
|
|
7 * 4, /* %esp */
|
|
6 * 4, /* %ebp */
|
|
5 * 4, /* %esi */
|
|
4 * 4, /* %edi */
|
|
12 * 4, /* %eip */
|
|
14 * 4, /* %eflags */
|
|
13 * 4, /* %cs */
|
|
16 * 4, /* %ss */
|
|
3 * 4, /* %ds */
|
|
2 * 4, /* %es */
|
|
1 * 4, /* %fs */
|
|
0 * 4 /* %gs */
|
|
};
|
|
|
|
/* From <sys/ucontext.h>. */
|
|
static int i386gnu_gregset_reg_offset[] =
|
|
{
|
|
11 * 4, /* %eax */
|
|
10 * 4, /* %ecx */
|
|
9 * 4, /* %edx */
|
|
8 * 4, /* %ebx */
|
|
17 * 4, /* %uesp */
|
|
6 * 4, /* %ebp */
|
|
5 * 4, /* %esi */
|
|
4 * 4, /* %edi */
|
|
14 * 4, /* %eip */
|
|
16 * 4, /* %efl */
|
|
15 * 4, /* %cs */
|
|
18 * 4, /* %ss */
|
|
3 * 4, /* %ds */
|
|
2 * 4, /* %es */
|
|
1 * 4, /* %fs */
|
|
0 * 4, /* %gs */
|
|
};
|
|
|
|
static void
|
|
i386gnu_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
|
{
|
|
i386_gdbarch_tdep *tdep = gdbarch_tdep<i386_gdbarch_tdep> (gdbarch);
|
|
|
|
/* GNU uses ELF. */
|
|
i386_elf_init_abi (info, gdbarch);
|
|
|
|
set_solib_svr4_fetch_link_map_offsets
|
|
(gdbarch, svr4_ilp32_fetch_link_map_offsets);
|
|
|
|
tdep->gregset_reg_offset = i386gnu_gregset_reg_offset;
|
|
tdep->gregset_num_regs = ARRAY_SIZE (i386gnu_gregset_reg_offset);
|
|
tdep->sizeof_gregset = 19 * 4;
|
|
|
|
tdep->jb_pc_offset = 20; /* From <bits/setjmp.h>. */
|
|
|
|
tdep->sigtramp_p = i386_gnu_sigtramp_p;
|
|
tdep->sigcontext_addr = i386_gnu_sigcontext_addr;
|
|
tdep->sc_reg_offset = i386_gnu_sc_reg_offset;
|
|
tdep->sc_num_regs = ARRAY_SIZE (i386_gnu_sc_reg_offset);
|
|
}
|
|
|
|
void _initialize_i386gnu_tdep ();
|
|
void
|
|
_initialize_i386gnu_tdep ()
|
|
{
|
|
gdbarch_register_osabi (bfd_arch_i386, 0, GDB_OSABI_HURD, i386gnu_init_abi);
|
|
}
|