mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-12 03:43:33 +08:00
258c81da3c
When running test-case gdb.xml/tdesc-regs.exp on riscv64-linux, I get:
...
(gdb) set tdesc file single-reg.xml^M
warning: Architecture rejected target-supplied description^M
(gdb) FAIL: gdb.xml/tdesc-regs.exp: set tdesc file single-reg.xml
UNSUPPORTED: gdb.xml/tdesc-regs.exp: register tests
...
The FAIL and UNSUPPORTED are produced here:
...
# If no core registers were specified, assume this target does not
# support target-defined registers. Verify that we get a warning if
# we try to use them. This not only tests the warning, but also
# reminds maintainers to add test support when they add the feature.
if {[string equal ${core-regs} ""]} {
gdb_test "set tdesc file $single_reg_xml" \
"warning: Target-supplied registers are not supported.*" \
"set tdesc file single-reg.xml"
unsupported "register tests"
return 0
}
...
The test-case contains target-specific setting of the core-regs variable, and
adding this for riscv64 bypasses this code and makes the test-case pass.
However, without that change, the test-case shouldn't produce a FAIL since
gdb isn't doing anything wrong.
Fix this by producing instead:
...
PASS: $exp: set tdesc file single-reg.xml
UNSUPPORTED: $exp: register tests (missing architecture-specific core-regs setting)
...
Tested on riscv64-linux.
|
||
|---|---|---|
| .. | ||
| bad-include.xml | ||
| core-only.xml | ||
| extra-regs.xml | ||
| inc-2.xml | ||
| inc-body.xml | ||
| includes.xml | ||
| loop.xml | ||
| maint_print_struct.exp | ||
| maint_print_struct.xml | ||
| maint-xml-dump-01.xml | ||
| maint-xml-dump-02.xml | ||
| maint-xml-dump-03.xml | ||
| maint-xml-dump.exp | ||
| single-reg.xml | ||
| tdesc-arch.exp | ||
| tdesc-bogus.xml | ||
| tdesc-errors.exp | ||
| tdesc-regs.exp | ||
| tdesc-reload.c | ||
| tdesc-reload.exp | ||
| tdesc-unknown.xml | ||
| tdesc-xinclude.exp | ||
| trivial.xml | ||