mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-30 21:44:19 +08:00
a9a87d3525
With the new member functions for struct trad_frame_saved_reg, there is no need to invoke some of the set/get functions anymore. This patch removes those and adjusts all callers. Even though the most natural initial state of a saved register value is UNKNOWN, there are target backends relying on the previous initial state of REALREG set to a register's own number. I noticed this in at least a couple targets: aarch64 and riscv. Because of that, I decided to keep the reset function that sets the set of register values to REALREG. I can't exercise all the targets to make sure the initial state change won't break things, hence why it is risky to change the default. Validated with --enable-targets=all on aarch64-linux Ubuntu 18.04/20.04. gdb/ChangeLog 2021-01-19 Luis Machado <luis.machado@linaro.org> * trad-frame.h (trad_frame_saved_reg) <set_value_bytes>: Allocate memory and save data. (trad_frame_set_value, trad_frame_set_realreg, trad_frame_set_addr) (trad_frame_set_unknown, trad_frame_set_value_bytes) (trad_frame_value_p, trad_frame_addr_p, trad_frame_realreg_p) (trad_frame_value_bytes_p): Remove. (trad_frame_reset_saved_regs): Adjust documentation. * trad-frame.c (trad_frame_alloc_saved_regs): Initialize via a constructor and reset the state of the registers. (trad_frame_value_p, trad_frame_addr_p, trad_frame_realreg_p) (trad_frame_value_bytes_p, trad_frame_set_value) (trad_frame_set_realreg, trad_frame_set_addr) (trad_frame_set_unknown, trad_frame_set_value_bytes): Remove. (trad_frame_set_reg_realreg): Update to call member function. (trad_frame_set_reg_addr, trad_frame_set_reg_value_bytes): Likewise. (trad_frame_get_prev_register): Likewise. * aarch64-tdep.c (aarch64_analyze_prologue) (aarch64_analyze_prologue_test, aarch64_make_prologue_cache_1) (aarch64_prologue_prev_register): Update to use member functions. * alpha-mdebug-tdep.c (alpha_mdebug_frame_unwind_cache): Likewise. * alpha-tdep.c (alpha_heuristic_frame_unwind_cache): Likewise. * arc-tdep.c (arc_print_frame_cache, arc_make_frame_cache): Likewise. * arm-tdep.c (arm_make_prologue_cache, arm_exidx_fill_cache) (arm_make_epilogue_frame_cache): Likewise. * avr-tdep.c (avr_frame_unwind_cache) (avr_frame_prev_register): Likewise. * cris-tdep.c (cris_scan_prologue): Likewise. * csky-tdep.c (csky_frame_unwind_cache): Likewise. * frv-tdep.c (frv_analyze_prologue): Likewise. * hppa-tdep.c (hppa_frame_cache, hppa_fallback_frame_cache): Likewise. * lm32-tdep.c (lm32_frame_cache): Likewise. * m32r-tdep.c (m32r_frame_unwind_cache): Likewise. * m68hc11-tdep.c (m68hc11_frame_unwind_cache): Likewise. * mips-tdep.c (set_reg_offset, mips_insn16_frame_cache) (mips_micro_frame_cache, mips_insn32_frame_cache): Likewise. (reset_saved_regs): Adjust to set realreg. * riscv-tdep.c (riscv_scan_prologue, riscv_frame_cache): Adjust to call member functions. * rs6000-tdep.c (rs6000_frame_cache, rs6000_epilogue_frame_cache) * s390-tdep.c (s390_prologue_frame_unwind_cache) (s390_backchain_frame_unwind_cache): Likewise. * score-tdep.c (score7_analyze_prologue) (score3_analyze_prologue, score_make_prologue_cache): Likewise. * sparc-netbsd-tdep.c (sparc32nbsd_sigcontext_saved_regs): Likewise. * sparc-sol2-tdep.c (sparc32_sol2_sigtramp_frame_cache): Likewise. * sparc64-netbsd-tdep.c (sparc64nbsd_sigcontext_saved_regs): Likewise. * sparc64-sol2-tdep.c (sparc64_sol2_sigtramp_frame_cache): Likewise. * tilegx-tdep.c (tilegx_analyze_prologue) (tilegx_frame_cache): Likewise. * v850-tdep.c (v850_frame_cache): Likewise. * vax-tdep.c (vax_frame_cache): Likewise.
245 lines
7.2 KiB
C
245 lines
7.2 KiB
C
/* Traditional frame unwind support, for GDB the GNU Debugger.
|
|
|
|
Copyright (C) 2003-2021 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "frame.h"
|
|
#include "trad-frame.h"
|
|
#include "regcache.h"
|
|
#include "frame-unwind.h"
|
|
#include "target.h"
|
|
#include "value.h"
|
|
#include "gdbarch.h"
|
|
#include "gdbsupport/traits.h"
|
|
|
|
struct trad_frame_cache
|
|
{
|
|
struct frame_info *this_frame;
|
|
CORE_ADDR this_base;
|
|
trad_frame_saved_reg *prev_regs;
|
|
struct frame_id this_id;
|
|
};
|
|
|
|
struct trad_frame_cache *
|
|
trad_frame_cache_zalloc (struct frame_info *this_frame)
|
|
{
|
|
struct trad_frame_cache *this_trad_cache;
|
|
|
|
this_trad_cache = FRAME_OBSTACK_ZALLOC (struct trad_frame_cache);
|
|
this_trad_cache->prev_regs = trad_frame_alloc_saved_regs (this_frame);
|
|
this_trad_cache->this_frame = this_frame;
|
|
return this_trad_cache;
|
|
}
|
|
|
|
/* See trad-frame.h. */
|
|
|
|
void
|
|
trad_frame_reset_saved_regs (struct gdbarch *gdbarch,
|
|
trad_frame_saved_reg *regs)
|
|
{
|
|
int numregs = gdbarch_num_cooked_regs (gdbarch);
|
|
|
|
for (int regnum = 0; regnum < numregs; regnum++)
|
|
regs[regnum].set_realreg (regnum);
|
|
}
|
|
|
|
trad_frame_saved_reg *
|
|
trad_frame_alloc_saved_regs (struct gdbarch *gdbarch)
|
|
{
|
|
#ifdef HAVE_IS_TRIVIALLY_CONSTRUCTIBLE
|
|
gdb_static_assert (std::is_trivially_constructible<trad_frame_saved_reg>::value);
|
|
#endif
|
|
|
|
int numregs = gdbarch_num_cooked_regs (gdbarch);
|
|
trad_frame_saved_reg *this_saved_regs
|
|
= FRAME_OBSTACK_CALLOC (numregs, trad_frame_saved_reg);
|
|
|
|
/* For backwards compatibility, initialize all the register values to
|
|
REALREG, with register 0 stored in 0, register 1 stored in 1 and so
|
|
on. */
|
|
trad_frame_reset_saved_regs (gdbarch, this_saved_regs);
|
|
|
|
return this_saved_regs;
|
|
}
|
|
|
|
/* A traditional frame is unwound by analysing the function prologue
|
|
and using the information gathered to track registers. For
|
|
non-optimized frames, the technique is reliable (just need to check
|
|
for all potential instruction sequences). */
|
|
|
|
trad_frame_saved_reg *
|
|
trad_frame_alloc_saved_regs (struct frame_info *this_frame)
|
|
{
|
|
struct gdbarch *gdbarch = get_frame_arch (this_frame);
|
|
|
|
return trad_frame_alloc_saved_regs (gdbarch);
|
|
}
|
|
|
|
void
|
|
trad_frame_set_reg_value (struct trad_frame_cache *this_trad_cache,
|
|
int regnum, LONGEST val)
|
|
{
|
|
/* External interface for users of trad_frame_cache
|
|
(who cannot access the prev_regs object directly). */
|
|
this_trad_cache->prev_regs[regnum].set_value (val);
|
|
}
|
|
|
|
void
|
|
trad_frame_set_reg_realreg (struct trad_frame_cache *this_trad_cache,
|
|
int regnum, int realreg)
|
|
{
|
|
this_trad_cache->prev_regs[regnum].set_realreg (realreg);
|
|
}
|
|
|
|
void
|
|
trad_frame_set_reg_addr (struct trad_frame_cache *this_trad_cache,
|
|
int regnum, CORE_ADDR addr)
|
|
{
|
|
this_trad_cache->prev_regs[regnum].set_addr (addr);
|
|
}
|
|
|
|
void
|
|
trad_frame_set_reg_regmap (struct trad_frame_cache *this_trad_cache,
|
|
const struct regcache_map_entry *regmap,
|
|
CORE_ADDR addr, size_t size)
|
|
{
|
|
struct gdbarch *gdbarch = get_frame_arch (this_trad_cache->this_frame);
|
|
int offs = 0, count;
|
|
|
|
for (; (count = regmap->count) != 0; regmap++)
|
|
{
|
|
int regno = regmap->regno;
|
|
int slot_size = regmap->size;
|
|
|
|
if (slot_size == 0 && regno != REGCACHE_MAP_SKIP)
|
|
slot_size = register_size (gdbarch, regno);
|
|
|
|
if (offs + slot_size > size)
|
|
break;
|
|
|
|
if (regno == REGCACHE_MAP_SKIP)
|
|
offs += count * slot_size;
|
|
else
|
|
for (; count--; regno++, offs += slot_size)
|
|
{
|
|
/* Mimic the semantics of regcache::transfer_regset if a
|
|
register slot's size does not match the size of a
|
|
register.
|
|
|
|
If a register slot is larger than a register, assume
|
|
the register's value is stored in the first N bytes of
|
|
the slot and ignore the remaining bytes.
|
|
|
|
If the register slot is smaller than the register,
|
|
assume that the slot contains the low N bytes of the
|
|
register's value. Since trad_frame assumes that
|
|
registers stored by address are sized according to the
|
|
register, read the low N bytes and zero-extend them to
|
|
generate a register value. */
|
|
if (slot_size >= register_size (gdbarch, regno))
|
|
trad_frame_set_reg_addr (this_trad_cache, regno, addr + offs);
|
|
else
|
|
{
|
|
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
|
gdb_byte buf[slot_size];
|
|
|
|
if (target_read_memory (addr + offs, buf, sizeof buf) == 0)
|
|
{
|
|
LONGEST val
|
|
= extract_unsigned_integer (buf, sizeof buf, byte_order);
|
|
trad_frame_set_reg_value (this_trad_cache, regno, val);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
/* See trad-frame.h. */
|
|
|
|
void
|
|
trad_frame_set_reg_value_bytes (struct trad_frame_cache *this_trad_cache,
|
|
int regnum,
|
|
gdb::array_view<const gdb_byte> bytes)
|
|
{
|
|
/* External interface for users of trad_frame_cache
|
|
(who cannot access the prev_regs object directly). */
|
|
this_trad_cache->prev_regs[regnum].set_value_bytes (bytes);
|
|
}
|
|
|
|
|
|
|
|
struct value *
|
|
trad_frame_get_prev_register (struct frame_info *this_frame,
|
|
trad_frame_saved_reg this_saved_regs[],
|
|
int regnum)
|
|
{
|
|
if (this_saved_regs[regnum].is_addr ())
|
|
/* The register was saved in memory. */
|
|
return frame_unwind_got_memory (this_frame, regnum,
|
|
this_saved_regs[regnum].addr ());
|
|
else if (this_saved_regs[regnum].is_realreg ())
|
|
return frame_unwind_got_register (this_frame, regnum,
|
|
this_saved_regs[regnum].realreg ());
|
|
else if (this_saved_regs[regnum].is_value ())
|
|
/* The register's value is available. */
|
|
return frame_unwind_got_constant (this_frame, regnum,
|
|
this_saved_regs[regnum].value ());
|
|
else if (this_saved_regs[regnum].is_value_bytes ())
|
|
/* The register's value is available as a sequence of bytes. */
|
|
return frame_unwind_got_bytes (this_frame, regnum,
|
|
this_saved_regs[regnum].value_bytes ());
|
|
else
|
|
return frame_unwind_got_optimized (this_frame, regnum);
|
|
}
|
|
|
|
struct value *
|
|
trad_frame_get_register (struct trad_frame_cache *this_trad_cache,
|
|
struct frame_info *this_frame,
|
|
int regnum)
|
|
{
|
|
return trad_frame_get_prev_register (this_frame, this_trad_cache->prev_regs,
|
|
regnum);
|
|
}
|
|
|
|
void
|
|
trad_frame_set_id (struct trad_frame_cache *this_trad_cache,
|
|
struct frame_id this_id)
|
|
{
|
|
this_trad_cache->this_id = this_id;
|
|
}
|
|
|
|
void
|
|
trad_frame_get_id (struct trad_frame_cache *this_trad_cache,
|
|
struct frame_id *this_id)
|
|
{
|
|
(*this_id) = this_trad_cache->this_id;
|
|
}
|
|
|
|
void
|
|
trad_frame_set_this_base (struct trad_frame_cache *this_trad_cache,
|
|
CORE_ADDR this_base)
|
|
{
|
|
this_trad_cache->this_base = this_base;
|
|
}
|
|
|
|
CORE_ADDR
|
|
trad_frame_get_this_base (struct trad_frame_cache *this_trad_cache)
|
|
{
|
|
return this_trad_cache->this_base;
|
|
}
|