Pedro Alves 6a2c1b8790 "complete" command and completion word break characters ... The linespec/locations/completer testcase added later in the series tests every completion with both TAB completion and the "complete" command. This exposed problems in the "complete" command, around determining the completion word point. First, the complete command has a too-simple approximation of what readline's TAB-completion code does to find the completion word point. Unfortunately, readline doesn't expose the functionality it uses internally, so to fix this this patch copies over the relevant code, and adjusts it a bit to better fit the use cases we need it for. (Specifically, our version avoids relying on the rl_word_break_characters, etc. globals, and instead takes those as arguments.) A following patch will want to use this function for TAB-completion too, but the "complete" command was a good excuse to split this to a separate patch. Then, notice how the complete_command does not call into the completer for the command being completed to determine the right set of word break characters. It always uses the default set. That is fixed by having the "complete" command call into complete_line_internal for a full handle_brkchars phase, just TAB-completion. gdb/ChangeLog: 2017-07-17 Pedro Alves <palves@redhat.com> * cli/cli-cmds.c (complete_command): Use a completion tracker along with completion_find_completion_word for handle_brkchars phase. * completer.c (RL_QF_SINGLE_QUOTE, RL_QF_DOUBLE_QUOTE) (RL_QF_BACKSLASH, RL_QF_OTHER_QUOTE): New. (struct gdb_rl_completion_word_info): New. (gdb_rl_find_completion_word): New. (completion_find_completion_word): New. * completer.h (completion_find_completion_word): Declare.		2017-07-17 15:30:59 +01:00
..
cli-cmds.c	"complete" command and completion word break characters	2017-07-17 15:30:59 +01:00
cli-cmds.h	update copyright year range in GDB files	2017-01-01 10:52:34 +04:00
cli-decode.c	Introduce class completion_tracker & rewrite completion<->readline interaction	2017-07-17 14:45:59 +01:00
cli-decode.h	Clean up "completer_handle_brkchars" callback handling	2017-07-17 12:05:03 +01:00
cli-dump.c	Introduce gdb::byte_vector, add allocator that default-initializes	2017-06-14 11:08:52 +01:00
cli-interp.c	C++-fy struct interp/cli_interp/tui_interp/mi_interp	2017-02-03 16:30:04 +00:00
cli-interp.h	C++-fy struct interp/cli_interp/tui_interp/mi_interp	2017-02-03 16:30:04 +00:00
cli-logging.c	Move "tee" building down to interpreter::set_logging_proc	2017-02-02 22:00:43 +00:00
cli-script.c	PR cli/21688: Detect aliases when issuing python/compile/guile commands (and fix last commit)	2017-06-30 09:31:21 -04:00
cli-script.h	Introduce command_line_up	2017-04-12 11:16:17 -06:00
cli-setshow.c	Use ui_out_emit_tuple	2017-04-22 09:46:58 -06:00
cli-setshow.h	update copyright year range in GDB files	2017-01-01 10:52:34 +04:00
cli-utils.c	-Wwrite-strings: Some constification in gdb/breakpoint.c	2017-04-05 19:21:36 +01:00
cli-utils.h	-Wwrite-strings: Some constification in gdb/breakpoint.c	2017-04-05 19:21:36 +01:00