binutils-gdb/gdb/buildsym-legacy.c
Tom Tromey 0d12e84cfc Don't include gdbarch.h from defs.h
I touched symtab.h and was surprised to see how many files were
rebuilt.  I looked into it a bit, and found that defs.h includes
gdbarch.h, which in turn includes many things.

gdbarch.h is only needed by a minority ofthe files in gdb, so this
patch removes the include from defs.h and updates the fallout.

I did "wc -l" on the files in build/gdb/.deps; this patch reduces the
line count from 139935 to 137030; so there are definitely future
build-time savings here.

Note that while I configured with --enable-targets=all, it's possible
that some *-nat.c file needs an update.  I could not test all of
these.  The buildbot caught a few problems along these lines.

gdb/ChangeLog
2019-07-10  Tom Tromey  <tom@tromey.com>

	* defs.h: Don't include gdbarch.h.
	* aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
	alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
	ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
	cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
	cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
	compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
	cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
	dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
	dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
	dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
	frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
	go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
	i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
	linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
	mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
	objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
	parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
	record-btrace.c, record.h, regcache-dump.c, regcache.h,
	riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
	sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
	sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
	sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
	target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
	tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
	utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
	xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
	* s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2019-07-10 14:53:53 -06:00

348 lines
8.4 KiB
C
Raw Blame History

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

/* Legacy support routines for building symbol tables in GDB's internal format.
Copyright (C) 1986-2019 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "buildsym-legacy.h"
#include "symtab.h"
/* The work-in-progress of the compunit we are building.
This is created first, before any subfiles by start_symtab. */
static struct buildsym_compunit *buildsym_compunit;
void
record_debugformat (const char *format)
{
buildsym_compunit->record_debugformat (format);
}
void
record_producer (const char *producer)
{
buildsym_compunit->record_producer (producer);
}
/* See buildsym.h. */
void
set_last_source_file (const char *name)
{
gdb_assert (buildsym_compunit != nullptr || name == nullptr);
if (buildsym_compunit != nullptr)
buildsym_compunit->set_last_source_file (name);
}
/* See buildsym.h. */
const char *
get_last_source_file ()
{
if (buildsym_compunit == nullptr)
return nullptr;
return buildsym_compunit->get_last_source_file ();
}
/* See buildsym.h. */
void
set_last_source_start_addr (CORE_ADDR addr)
{
gdb_assert (buildsym_compunit != nullptr);
buildsym_compunit->set_last_source_start_addr (addr);
}
/* See buildsym.h. */
CORE_ADDR
get_last_source_start_addr ()
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit->get_last_source_start_addr ();
}
/* See buildsym.h. */
struct using_direct **
get_local_using_directives ()
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit->get_local_using_directives ();
}
/* See buildsym.h. */
void
set_local_using_directives (struct using_direct *new_local)
{
gdb_assert (buildsym_compunit != nullptr);
buildsym_compunit->set_local_using_directives (new_local);
}
/* See buildsym.h. */
struct using_direct **
get_global_using_directives ()
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit->get_global_using_directives ();
}
/* See buildsym.h. */
bool
outermost_context_p ()
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit->outermost_context_p ();
}
/* See buildsym.h. */
struct context_stack *
get_current_context_stack ()
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit->get_current_context_stack ();
}
/* See buildsym.h. */
int
get_context_stack_depth ()
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit->get_context_stack_depth ();
}
/* See buildsym.h. */
struct subfile *
get_current_subfile ()
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit->get_current_subfile ();
}
/* See buildsym.h. */
struct pending **
get_local_symbols ()
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit->get_local_symbols ();
}
/* See buildsym.h. */
struct pending **
get_file_symbols ()
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit->get_file_symbols ();
}
/* See buildsym.h. */
struct pending **
get_global_symbols ()
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit->get_global_symbols ();
}
void
start_subfile (const char *name)
{
gdb_assert (buildsym_compunit != nullptr);
buildsym_compunit->start_subfile (name);
}
void
patch_subfile_names (struct subfile *subfile, const char *name)
{
gdb_assert (buildsym_compunit != nullptr);
buildsym_compunit->patch_subfile_names (subfile, name);
}
void
push_subfile ()
{
gdb_assert (buildsym_compunit != nullptr);
buildsym_compunit->push_subfile ();
}
const char *
pop_subfile ()
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit->pop_subfile ();
}
/* Delete the buildsym compunit. */
static void
free_buildsym_compunit (void)
{
if (buildsym_compunit == NULL)
return;
delete buildsym_compunit;
buildsym_compunit = NULL;
}
struct compunit_symtab *
end_symtab (CORE_ADDR end_addr, int section)
{
gdb_assert (buildsym_compunit != nullptr);
struct compunit_symtab *result
= buildsym_compunit->end_symtab (end_addr, section);
free_buildsym_compunit ();
return result;
}
struct context_stack *
push_context (int desc, CORE_ADDR valu)
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit->push_context (desc, valu);
}
struct context_stack
pop_context ()
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit->pop_context ();
}
struct block *
finish_block (struct symbol *symbol, struct pending_block *old_blocks,
const struct dynamic_prop *static_link,
CORE_ADDR start, CORE_ADDR end)
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit->finish_block (symbol, old_blocks, static_link,
start, end);
}
void
record_block_range (struct block *block, CORE_ADDR start,
CORE_ADDR end_inclusive)
{
gdb_assert (buildsym_compunit != nullptr);
buildsym_compunit->record_block_range (block, start, end_inclusive);
}
void
record_line (struct subfile *subfile, int line, CORE_ADDR pc)
{
gdb_assert (buildsym_compunit != nullptr);
buildsym_compunit->record_line (subfile, line, pc);
}
/* Start a new symtab for a new source file in OBJFILE. Called, for example,
when a stabs symbol of type N_SO is seen, or when a DWARF
TAG_compile_unit DIE is seen. It indicates the start of data for
one original source file.
NAME is the name of the file (cannot be NULL). COMP_DIR is the
directory in which the file was compiled (or NULL if not known).
START_ADDR is the lowest address of objects in the file (or 0 if
not known). LANGUAGE is the language of the source file, or
language_unknown if not known, in which case it'll be deduced from
the filename. */
struct compunit_symtab *
start_symtab (struct objfile *objfile, const char *name, const char *comp_dir,
CORE_ADDR start_addr, enum language language)
{
/* These should have been reset either by successful completion of building
a symtab, or by the scoped_free_pendings destructor. */
gdb_assert (buildsym_compunit == nullptr);
buildsym_compunit = new struct buildsym_compunit (objfile, name, comp_dir,
language, start_addr);
return buildsym_compunit->get_compunit_symtab ();
}
/* Restart compilation for a symtab.
CUST is the result of end_expandable_symtab.
NAME, START_ADDR are the source file we are resuming with.
This is used when a symtab is built from multiple sources.
The symtab is first built with start_symtab/end_expandable_symtab
and then for each additional piece call restart_symtab/augment_*_symtab.
Note: At the moment there is only augment_type_symtab. */
void
restart_symtab (struct compunit_symtab *cust,
const char *name, CORE_ADDR start_addr)
{
/* These should have been reset either by successful completion of building
a symtab, or by the scoped_free_pendings destructor. */
gdb_assert (buildsym_compunit == nullptr);
buildsym_compunit
= new struct buildsym_compunit (COMPUNIT_OBJFILE (cust),
name,
COMPUNIT_DIRNAME (cust),
compunit_language (cust),
start_addr,
cust);
}
/* See buildsym.h. */
struct compunit_symtab *
buildsym_compunit_symtab (void)
{
gdb_assert (buildsym_compunit != NULL);
return buildsym_compunit->get_compunit_symtab ();
}
/* See buildsym.h. */
struct macro_table *
get_macro_table (void)
{
gdb_assert (buildsym_compunit != NULL);
return buildsym_compunit->get_macro_table ();
}
/* At end of reading syms, or in case of quit, ensure everything
associated with building symtabs is freed.
N.B. This is *not* intended to be used when building psymtabs. Some debug
info readers call this anyway, which is harmless if confusing. */
scoped_free_pendings::~scoped_free_pendings ()
{
free_buildsym_compunit ();
}
/* See buildsym-legacy.h. */
struct buildsym_compunit *
get_buildsym_compunit ()
{
gdb_assert (buildsym_compunit != nullptr);
return buildsym_compunit;
}