mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-24 18:44:20 +08:00
0d12e84cfc
I touched symtab.h and was surprised to see how many files were rebuilt. I looked into it a bit, and found that defs.h includes gdbarch.h, which in turn includes many things. gdbarch.h is only needed by a minority ofthe files in gdb, so this patch removes the include from defs.h and updates the fallout. I did "wc -l" on the files in build/gdb/.deps; this patch reduces the line count from 139935 to 137030; so there are definitely future build-time savings here. Note that while I configured with --enable-targets=all, it's possible that some *-nat.c file needs an update. I could not test all of these. The buildbot caught a few problems along these lines. gdb/ChangeLog 2019-07-10 Tom Tromey <tom@tromey.com> * defs.h: Don't include gdbarch.h. * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h, alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h, ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c, cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h, cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c, compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c, cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c, dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c, dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c, dwarf2expr.c, expression.h, f-lang.c, frame-base.c, frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h, go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c, i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c, linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c, mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c, objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c, parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c, record-btrace.c, record.h, regcache-dump.c, regcache.h, riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y, sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c, sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c, sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h, target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c, tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c, utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c, xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update. * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
130 lines
4.1 KiB
C
130 lines
4.1 KiB
C
/* Simulate breakpoints by patching locations in the target system, for GDB.
|
|
|
|
Copyright (C) 1990-2019 Free Software Foundation, Inc.
|
|
|
|
Contributed by Cygnus Support. Written by John Gilmore.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "symtab.h"
|
|
#include "breakpoint.h"
|
|
#include "inferior.h"
|
|
#include "target.h"
|
|
#include "gdbarch.h"
|
|
|
|
/* Insert a breakpoint on targets that don't have any better
|
|
breakpoint support. We read the contents of the target location
|
|
and stash it, then overwrite it with a breakpoint instruction.
|
|
BP_TGT->placed_address is the target location in the target
|
|
machine. BP_TGT->shadow_contents is some memory allocated for
|
|
saving the target contents. It is guaranteed by the caller to be
|
|
long enough to save BREAKPOINT_LEN bytes (this is accomplished via
|
|
BREAKPOINT_MAX). */
|
|
|
|
int
|
|
default_memory_insert_breakpoint (struct gdbarch *gdbarch,
|
|
struct bp_target_info *bp_tgt)
|
|
{
|
|
CORE_ADDR addr = bp_tgt->placed_address;
|
|
const unsigned char *bp;
|
|
gdb_byte *readbuf;
|
|
int bplen;
|
|
int val;
|
|
|
|
/* Determine appropriate breakpoint contents and size for this address. */
|
|
bp = gdbarch_sw_breakpoint_from_kind (gdbarch, bp_tgt->kind, &bplen);
|
|
|
|
/* Save the memory contents in the shadow_contents buffer and then
|
|
write the breakpoint instruction. */
|
|
readbuf = (gdb_byte *) alloca (bplen);
|
|
val = target_read_memory (addr, readbuf, bplen);
|
|
if (val == 0)
|
|
{
|
|
/* These must be set together, either before or after the shadow
|
|
read, so that if we're "reinserting" a breakpoint that
|
|
doesn't have a shadow yet, the breakpoint masking code inside
|
|
target_read_memory doesn't mask out this breakpoint using an
|
|
unfilled shadow buffer. The core may be trying to reinsert a
|
|
permanent breakpoint, for targets that support breakpoint
|
|
conditions/commands on the target side for some types of
|
|
breakpoints, such as target remote. */
|
|
bp_tgt->shadow_len = bplen;
|
|
memcpy (bp_tgt->shadow_contents, readbuf, bplen);
|
|
|
|
val = target_write_raw_memory (addr, bp, bplen);
|
|
}
|
|
|
|
return val;
|
|
}
|
|
|
|
|
|
int
|
|
default_memory_remove_breakpoint (struct gdbarch *gdbarch,
|
|
struct bp_target_info *bp_tgt)
|
|
{
|
|
int bplen;
|
|
|
|
gdbarch_sw_breakpoint_from_kind (gdbarch, bp_tgt->kind, &bplen);
|
|
|
|
return target_write_raw_memory (bp_tgt->placed_address, bp_tgt->shadow_contents,
|
|
bplen);
|
|
}
|
|
|
|
|
|
int
|
|
memory_insert_breakpoint (struct target_ops *ops, struct gdbarch *gdbarch,
|
|
struct bp_target_info *bp_tgt)
|
|
{
|
|
return gdbarch_memory_insert_breakpoint (gdbarch, bp_tgt);
|
|
}
|
|
|
|
int
|
|
memory_remove_breakpoint (struct target_ops *ops, struct gdbarch *gdbarch,
|
|
struct bp_target_info *bp_tgt,
|
|
enum remove_bp_reason reason)
|
|
{
|
|
return gdbarch_memory_remove_breakpoint (gdbarch, bp_tgt);
|
|
}
|
|
|
|
int
|
|
memory_validate_breakpoint (struct gdbarch *gdbarch,
|
|
struct bp_target_info *bp_tgt)
|
|
{
|
|
CORE_ADDR addr = bp_tgt->placed_address;
|
|
const gdb_byte *bp;
|
|
int val;
|
|
int bplen;
|
|
gdb_byte cur_contents[BREAKPOINT_MAX];
|
|
|
|
/* Determine appropriate breakpoint contents and size for this
|
|
address. */
|
|
bp = gdbarch_breakpoint_from_pc (gdbarch, &addr, &bplen);
|
|
|
|
if (bp == NULL)
|
|
return 0;
|
|
|
|
/* Make sure we see the memory breakpoints. */
|
|
scoped_restore restore_memory
|
|
= make_scoped_restore_show_memory_breakpoints (1);
|
|
val = target_read_memory (addr, cur_contents, bplen);
|
|
|
|
/* If our breakpoint is no longer at the address, this means that
|
|
the program modified the code on us, so it is wrong to put back
|
|
the old value. */
|
|
return (val == 0 && memcmp (bp, cur_contents, bplen) == 0);
|
|
}
|