mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-28 04:25:10 +08:00
bd2e3511f7
The problem is that while the command line isn't trivially empty, it contains no input files. As gold tries to configure the number of threads to use based on the number of input files, this causes the assertion failure above. Fix this problem by making the logic in gold.cc more robust and also adding a better error message about --start-lib to options.cc. gold/ PR gold/22406 * gold.cc (queue_initial_tasks) Check for number of real input files. * options.cc (Command_line::process) Check for unterminated --start-lib options. * testsuite/Makefile.am: Add new test script. * testsuite/Makefile.in: Regenerate. * testsuite/check_empty_command_lines.sh: New test script.
44 lines
1.3 KiB
Bash
Executable File
44 lines
1.3 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
# empty_command_line_test.sh -- test various command lines with no inputs
|
|
|
|
# Copyright (C) 2017 Free Software Foundation, Inc.
|
|
# Written by Benjamin Peterson <bp@benjamin.pe>
|
|
|
|
# This file is part of gold.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
|
# MA 02110-1301, USA.
|
|
|
|
check()
|
|
{
|
|
expected_msg="$1"
|
|
shift
|
|
echo "checking empty command line '$@'"
|
|
err=$(gcctestdir/ld "$@" 2>&1)
|
|
if [ $? != 1 ]; then
|
|
echo "gold didn't fail"
|
|
exit 1
|
|
fi
|
|
echo "$err" | grep -q "$expected_msg" || {
|
|
echo "unexpected error message: $err"
|
|
exit 1
|
|
}
|
|
}
|
|
|
|
check "no input files"
|
|
check "missing lib end" --start-lib
|
|
check "missing group end" --start-group
|