Pedro Alves 51abb42130 Kill init_sal ... Instead, make symtab_and_line initialize its members itself. Many symtab_and_line declarations are moved to where the object is initialized at the same time both for clarity and to avoid double initialization. A few functions, like e.g., find_frame_sal are adjusted to return the sal using normal function return instead of an output parameter likewise to avoid having to default-construct a sal and then immediately have the object overwritten. gdb/ChangeLog: 2017-09-04 Pedro Alves <palves@redhat.com> * ada-lang.c (is_known_support_routine): Move sal declaration to where it is initialized. * breakpoint.c (create_internal_breakpoint, init_catchpoint) (parse_breakpoint_sals, decode_static_tracepoint_spec) (clear_command, update_static_tracepoint): Remove init_sal references. Move declarations closer to initializations. * cli/cli-cmds.c (list_command): Move sal declarations closer to initializations. * elfread.c (elf_gnu_ifunc_resolver_stop): Remove init_sal references. Move sal declarations closer to initializations. * frame.c (find_frame_sal): Return a symtab_and_line via function return instead of output parameter. Remove init_sal references. * frame.h (find_frame_sal): Return a symtab_and_line via function return instead of output parameter. * guile/scm-frame.c (gdbscm_frame_sal): Adjust. * guile/scm-symtab.c (stscm_make_sal_smob): Use in-place new instead of memset. (gdbscm_find_pc_line): Remove init_sal reference. * infcall.c (call_function_by_hand_dummy): Remove init_sal references. Move declarations closer to initializations. * infcmd.c (set_step_frame): Update. Move declarations closer to initializations. (finish_backward): Remove init_sal references. Move declarations closer to initializations. * infrun.c (process_event_stop_test, handle_step_into_function) (insert_hp_step_resume_breakpoint_at_frame) (insert_step_resume_breakpoint_at_caller): Likewise. * linespec.c (create_sals_line_offset, decode_digits_ordinary) (symbol_to_sal): Likewise. * probe.c (parse_probes_in_pspace): Remove init_sal reference. * python/py-frame.c (frapy_find_sal): Move sal declaration closer to its initialization. * reverse.c (save_bookmark_command): Use new/delete. Remove init_sal references. Move declarations closer to initializations. * source.c (get_current_source_symtab_and_line): Remove brace initialization. (set_current_source_symtab_and_line): Now takes the sal by const reference. Remove brace initialization. (line_info): Remove init_sal reference. * source.h (set_current_source_symtab_and_line): Now takes a symtab_and_line via const reference. * stack.c (set_current_sal_from_frame): Adjust. (print_frame_info): Adjust. (get_last_displayed_sal): Return the sal via function return instead of via output parameter. Simplify. (frame_info): Adjust. * stack.h (get_last_displayed_sal): Return the sal via function return instead of via output parameter. * symtab.c (init_sal): Delete. (find_pc_sect_line): Remove init_sal references. Move declarations closer to initializations. (find_function_start_sal): Remove init_sal references. Move declarations closer to initializations. * symtab.h (struct symtab_and_line): In-class initialize all fields. * tracepoint.c (set_traceframe_context) (print_one_static_tracepoint_marker): Remove init_sal references. Move declarations closer to initializations. * tui/tui-disasm.c (tui_show_disassem_and_update_source): Adjust. * tui/tui-stack.c (tui_show_frame_info): Adjust. Move declarations closer to initializations. * tui/tui-winsource.c (tui_update_source_window_as_is): Remove init_sal references. Adjust.		2017-09-04 17:11:45 +01:00
..
cli-cmds.c	Kill init_sal	2017-09-04 17:11:45 +01:00
cli-cmds.h	Change return type of find_and_open_script	2017-08-03 07:58:53 -06:00
cli-decode.c	Introduce class completion_tracker & rewrite completion<->readline interaction	2017-07-17 14:45:59 +01:00
cli-decode.h	Clean up "completer_handle_brkchars" callback handling	2017-07-17 12:05:03 +01:00
cli-dump.c	Use gdb::unique_xmalloc_ptr when calling tilde_expand	2017-08-05 15:52:49 -06:00
cli-interp.c	C++-fy struct interp/cli_interp/tui_interp/mi_interp	2017-02-03 16:30:04 +00:00
cli-interp.h	C++-fy struct interp/cli_interp/tui_interp/mi_interp	2017-02-03 16:30:04 +00:00
cli-logging.c	Move "tee" building down to interpreter::set_logging_proc	2017-02-02 22:00:43 +00:00
cli-script.c	define_command: Don't convert command name to lower case	2017-08-28 23:05:04 +02:00
cli-script.h	Introduce command_line_up	2017-04-12 11:16:17 -06:00
cli-setshow.c	Use std::string in do_set_command	2017-09-03 13:03:07 -06:00
cli-setshow.h	update copyright year range in GDB files	2017-01-01 10:52:34 +04:00
cli-utils.c	-Wwrite-strings: Some constification in gdb/breakpoint.c	2017-04-05 19:21:36 +01:00
cli-utils.h	-Wwrite-strings: Some constification in gdb/breakpoint.c	2017-04-05 19:21:36 +01:00