mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-18 23:03:29 +08:00
f26a32876b
It is possible to create shared libraries on PowerPC using -ftls-model=inital-exec or -ftls-model=local-exec. The first is half reasonable, getting you a shared library that can't be dlopen'd but otherwise is reasonable. The second is quite bad. Not only do you lose being able to dlopen, the library also has dynamic text relocations. Worse, the TPREL16_LO, TPREL16_HA and other TPREL16 dynamic relocs emitted were wrong, resulting in wrong values being applied by ld.so. Using the first TLS section symbol in dynamic relocations for local TLS symbols doesn't work. It's wrong because TLS symbols used by TLS relocs have values relative to the TLS segment, whereas the TLS section symbols are addresses. This patch instead uses a symbol index of zero which is used elsewhere by PowerPC on dynamic TLS relocs. It's not strictly ABI compliant to use a non-TLS symbol with TLS relocs but symbol index zero can be interpreted as "no symbol". Not using the first TLS section symbol means it doesn't need to be dynamic. The patch also fixes a further problem with PowerPC32 dynamic TPREL16* relocs, which shouldn't have the symbol value in the addend as we do for non-TLS symbols. bfd/ * elflink.c (_bfd_elf_omit_section_dynsym_default): Don't keep tls_sec. (_bfd_elf_init_1_index_section): Prefer not using TLS sections. (_bfd_elf_init_2_index_sections): Likewise. * elf64-ppc.c (ppc64_elf_relocate_section): When emitting dynamic relocations for local TLS symbols, use STN_UNDEF as the relocation symbol. * elf32-ppc.c (ppc_elf_relocate_section): Likewise, and don't leave TLS symbol value in the addend. ld/ * testsuite/ld-powerpc/tlsso.r: Update. * testsuite/ld-powerpc/tlsso32.g: Update. * testsuite/ld-powerpc/tlsso32.r: Update. * testsuite/ld-powerpc/tlstocso.r: Update. * testsuite/ld-cris/tls-dso-dtpoffd2.d: Update. * testsuite/ld-cris/tls-dso-dtpoffd4.d: Update. * testsuite/ld-cris/tls-dso-tpoffgotcomm1.d: Update. * testsuite/ld-cris/tls-gd-1.d: Update. * testsuite/ld-cris/tls-gd-1h.d: Update. * testsuite/ld-cris/tls-gd-2.d: Update. * testsuite/ld-cris/tls-gd-2h.d: Update. * testsuite/ld-cris/tls-ie-10.d: Update. * testsuite/ld-cris/tls-ie-11.d: Update. * testsuite/ld-cris/tls-ie-8.d: Update. * testsuite/ld-cris/tls-ie-9.d: Update. * testsuite/ld-cris/tls-js1.d: Update. * testsuite/ld-cris/tls-ld-4.d: Update. * testsuite/ld-cris/tls-ld-5.d: Update. * testsuite/ld-cris/tls-ld-6.d: Update. * testsuite/ld-cris/tls-ld-7.d: Update. * testsuite/ld-cris/tls-ldgd-14.d: Update. * testsuite/ld-cris/tls-ldgd-15.d: Update. * testsuite/ld-cris/tls-ldgdx-14.d: Update. * testsuite/ld-cris/tls-ldgdx-15.d: Update. * testsuite/ld-cris/tls-local-54.d: Update. * testsuite/ld-cris/tls-local-60.d: Update. * testsuite/ld-cris/tls-local-61.d: Update. * testsuite/ld-cris/tls-local-63.d: Update. * testsuite/ld-cris/tls-local-64.d: Update. * testsuite/ld-cris/tls-ok-30.d: Update. * testsuite/ld-cris/tls-ok-32.d: Update. * testsuite/ld-cris/tls-ok-34.d: Update. * testsuite/ld-mips-elf/tls-multi-got-1.got: Update. * testsuite/ld-mips-elf/tls-multi-got-1.r: Update. * testsuite/ld-mips-elf/tlsdyn-pie-o32.d: Update. * testsuite/ld-mips-elf/tlsdyn-pie-o32.got: Update. * testsuite/ld-mips-elf/tlslib-o32-hidden.got: Update. * testsuite/ld-mips-elf/tlslib-o32-ver.got: Update. * testsuite/ld-mips-elf/tlslib-o32.got: Update. * testsuite/ld-s390/tlspic.rd: Update. * testsuite/ld-s390/tlspic_64.rd: Update. * testsuite/ld-sparc/tlssunnopic32.rd: Update. * testsuite/ld-sparc/tlssunnopic64.rd: Update. * testsuite/ld-sparc/tlssunpic32.rd: Update. * testsuite/ld-sparc/tlssunpic64.rd: Update.
56 lines
1.2 KiB
Makefile
56 lines
1.2 KiB
Makefile
#source: tls128.s
|
|
#source: tls-ld-5.s
|
|
#source: tls-gd-1.s
|
|
#source: tls-ldgd-14.s
|
|
#source: tls-hx1x2.s
|
|
#as: --pic --no-underscore --em=criself
|
|
#ld: --shared -m crislinux --hash-style=sysv tmpdir/tls-dso-xz-1.so
|
|
#objdump: -s -h -t -T -R -r -p
|
|
|
|
# Check that we have proper NPTL/TLS markings and GOT for two
|
|
# R_CRIS_16_GOT_GD and two R_CRIS_16_DTPRELs against different
|
|
# variables in a DSO, GD symbols defined elsewhere.
|
|
|
|
.*: file format elf32-cris
|
|
|
|
Program Header:
|
|
#...
|
|
TLS off .*
|
|
filesz 0x0+88 memsz 0x0+88 flags r--
|
|
|
|
Dynamic Section:
|
|
NEEDED tmpdir/tls-dso-xz-1.so
|
|
#...
|
|
private flags = 0:
|
|
#...
|
|
7 .got .*
|
|
CONTENTS.*
|
|
SYMBOL TABLE:
|
|
#...
|
|
0+ \*UND\* 0+ x
|
|
#...
|
|
0+ \*UND\* 0+ z
|
|
#...
|
|
DYNAMIC SYMBOL TABLE:
|
|
#...
|
|
0+ D \*UND\* 0+ x
|
|
#...
|
|
0+ D \*UND\* 0+ z
|
|
#...
|
|
DYNAMIC RELOCATION RECORDS
|
|
OFFSET TYPE VALUE
|
|
000022d0 R_CRIS_DTPMOD \*ABS\*
|
|
000022d8 R_CRIS_DTP x
|
|
000022e0 R_CRIS_DTP z
|
|
|
|
Contents of section \.hash:
|
|
#...
|
|
Contents of section \.text:
|
|
01b4 5fae8000 5fbe8400 5fae1400 5fae1c00 .*
|
|
Contents of section .tdata:
|
|
#...
|
|
Contents of section \.got:
|
|
22c4 4c220+ 0+ 0+ 0+ .*
|
|
22d4 0+ 0+ 0+ 0+ .*
|
|
22e4 0+ .*
|