mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-28 04:25:10 +08:00
e0700ba44c
String-like settings (var_string, var_filename, var_optional_filename, var_string_noescape) currently take a pointer to a `char *` storage variable (typically global) that holds the setting's value. I'd like to "mordernize" this by changing them to use an std::string for storage. An obvious reason is that string operations on std::string are often easier to write than with C strings. And they avoid having to do any manual memory management. Another interesting reason is that, with `char *`, nullptr and an empty string often both have the same meaning of "no value". String settings are initially nullptr (unless initialized otherwise). But when doing "set foo" (where `foo` is a string setting), the setting now points to an empty string. For example, solib_search_path is nullptr at startup, but points to an empty string after doing "set solib-search-path". This leads to some code that needs to check for both to check for "no value". Or some code that converts back and forth between NULL and "" when getting or setting the value. I find this very error-prone, because it is very easy to forget one or the other. With std::string, we at least know that the variable is not "NULL". There is only one way of representing an empty string setting, that is with an empty string. I was wondering whether the distinction between NULL and "" would be important for some setting, but it doesn't seem so. If that ever happens, it would be more C++-y and self-descriptive to use optional<string> anyway. Actually, there's one spot where this distinction mattered, it's in init_history, for the test gdb.base/gdbinit-history.exp. init_history sets the history filename to the default ".gdb_history" if it sees that the setting was never set - if history_filename is nullptr. If history_filename is an empty string, it means the setting was explicitly cleared, so it leaves it as-is. With the change to std::string, this distinction doesn't exist anymore. This can be fixed by moving the code that chooses a good default value for history_filename to _initialize_top. This is ran before -ex commands are processed, so an -ex command can then clear that value if needed (what gdb.base/gdbinit-history.exp tests). Another small improvement, in my opinion is that we can now easily give string parameters initial values, by simply initializing the global variables, instead of xstrdup-ing it in the _initialize function. In Python and Guile, when registering a string-like parameter, we allocate (with new) an std::string that is owned by the param_smob (in Guile) and the parmpy_object (in Python) objects. This patch started by changing all relevant add_setshow_* commands to take an `std::string *` instead of a `char **` and fixing everything that failed to build. That includes of course all string setting variable and their uses. string_option_def now uses an std::string also, because there's a connection between options and settings (see add_setshow_cmds_for_options). The add_path function in source.c is really complex and twisted, I'd rather not try to change it to work on an std::string right now. Instead, I added an overload that copies the std:string to a `char *` and back. This means more copying, but this is not used in a hot path at all, so I think it is acceptable. Change-Id: I92c50a1bdd8307141cdbacb388248e4e4fc08c93 Co-authored-by: Lancelot SIX <lsix@lancelotsix.com>
178 lines
4.7 KiB
C
178 lines
4.7 KiB
C
/* Fork a Unix child process, and set up to debug it, for GDB.
|
|
|
|
Copyright (C) 1990-2021 Free Software Foundation, Inc.
|
|
|
|
Contributed by Cygnus Support.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "inferior.h"
|
|
#include "gdbcmd.h"
|
|
#include "terminal.h"
|
|
#include "gdbthread.h"
|
|
#include "top.h"
|
|
#include "gdbsupport/job-control.h"
|
|
#include "gdbsupport/filestuff.h"
|
|
#include "nat/fork-inferior.h"
|
|
#include "gdbsupport/common-inferior.h"
|
|
|
|
/* The exec-wrapper, if any, that will be used when starting the
|
|
inferior. */
|
|
|
|
static std::string exec_wrapper;
|
|
|
|
/* See gdbsupport/common-inferior.h. */
|
|
|
|
const char *
|
|
get_exec_wrapper ()
|
|
{
|
|
return !exec_wrapper.empty () ? exec_wrapper.c_str () : nullptr;
|
|
}
|
|
|
|
/* See nat/fork-inferior.h. */
|
|
|
|
void
|
|
gdb_flush_out_err ()
|
|
{
|
|
gdb_flush (main_ui->m_gdb_stdout);
|
|
gdb_flush (main_ui->m_gdb_stderr);
|
|
}
|
|
|
|
/* The ui structure that will be saved on 'prefork_hook' and
|
|
restored on 'postfork_hook'. */
|
|
static struct ui *saved_ui = NULL;
|
|
|
|
/* See nat/fork-inferior.h. */
|
|
|
|
void
|
|
prefork_hook (const char *args)
|
|
{
|
|
gdb_assert (saved_ui == NULL);
|
|
/* Retain a copy of our UI, since the child will replace this value
|
|
and if we're vforked, we have to restore it. */
|
|
saved_ui = current_ui;
|
|
|
|
/* Tell the terminal handling subsystem what tty we plan to run on;
|
|
it will just record the information for later. */
|
|
new_tty_prefork (current_inferior ()->tty ());
|
|
}
|
|
|
|
/* See nat/fork-inferior.h. */
|
|
|
|
void
|
|
postfork_hook (pid_t pid)
|
|
{
|
|
inferior *inf = current_inferior ();
|
|
|
|
inferior_appeared (inf, pid);
|
|
|
|
gdb_assert (saved_ui != NULL);
|
|
current_ui = saved_ui;
|
|
saved_ui = NULL;
|
|
|
|
new_tty_postfork ();
|
|
}
|
|
|
|
/* See nat/fork-inferior.h. */
|
|
|
|
void
|
|
postfork_child_hook ()
|
|
{
|
|
/* This is set to the result of setpgrp, which if vforked, will be
|
|
visible to you in the parent process. It's only used by humans
|
|
for debugging. */
|
|
static int debug_setpgrp = 657473;
|
|
|
|
/* Make sure we switch to main_ui here in order to be able to
|
|
use the fprintf_unfiltered/warning/error functions. */
|
|
current_ui = main_ui;
|
|
|
|
/* Create a new session for the inferior process, if necessary.
|
|
It will also place the inferior in a separate process group. */
|
|
if (create_tty_session () <= 0)
|
|
{
|
|
/* No session was created, but we still want to run the inferior
|
|
in a separate process group. */
|
|
debug_setpgrp = gdb_setpgid ();
|
|
if (debug_setpgrp == -1)
|
|
perror (_("setpgrp failed in child"));
|
|
}
|
|
|
|
/* Ask the tty subsystem to switch to the one we specified
|
|
earlier (or to share the current terminal, if none was
|
|
specified). */
|
|
new_tty ();
|
|
}
|
|
|
|
/* See inferior.h. */
|
|
|
|
ptid_t
|
|
gdb_startup_inferior (pid_t pid, int num_traps)
|
|
{
|
|
inferior *inf = current_inferior ();
|
|
process_stratum_target *proc_target = inf->process_target ();
|
|
|
|
ptid_t ptid = startup_inferior (proc_target, pid, num_traps, NULL, NULL);
|
|
|
|
/* Mark all threads non-executing. */
|
|
set_executing (proc_target, ptid, false);
|
|
|
|
return ptid;
|
|
}
|
|
|
|
/* Implement the "unset exec-wrapper" command. */
|
|
|
|
static void
|
|
unset_exec_wrapper_command (const char *args, int from_tty)
|
|
{
|
|
exec_wrapper.clear ();
|
|
}
|
|
|
|
static void
|
|
show_startup_with_shell (struct ui_file *file, int from_tty,
|
|
struct cmd_list_element *c, const char *value)
|
|
{
|
|
fprintf_filtered (file,
|
|
_("Use of shell to start subprocesses is %s.\n"),
|
|
value);
|
|
}
|
|
|
|
void _initialize_fork_child ();
|
|
void
|
|
_initialize_fork_child ()
|
|
{
|
|
add_setshow_filename_cmd ("exec-wrapper", class_run, &exec_wrapper, _("\
|
|
Set a wrapper for running programs.\n\
|
|
The wrapper prepares the system and environment for the new program."),
|
|
_("\
|
|
Show the wrapper for running programs."), NULL,
|
|
NULL, NULL,
|
|
&setlist, &showlist);
|
|
|
|
add_cmd ("exec-wrapper", class_run, unset_exec_wrapper_command,
|
|
_("Disable use of an execution wrapper."),
|
|
&unsetlist);
|
|
|
|
add_setshow_boolean_cmd ("startup-with-shell", class_support,
|
|
&startup_with_shell, _("\
|
|
Set use of shell to start subprocesses. The default is on."), _("\
|
|
Show use of shell to start subprocesses."), NULL,
|
|
NULL,
|
|
show_startup_with_shell,
|
|
&setlist, &showlist);
|
|
}
|