binutils-gdb/gdb/skip.c
Tom Tromey 863779b0c6 Constify some commands in skip.c
gdb/ChangeLog
2017-09-27  Tom Tromey  <tom@tromey.com>

	* skip.c (skip_file_command, skip_function_command)
	(skip_enable_command, skip_disable_command, skip_delete_command):
	Constify.
2017-09-27 08:44:37 -06:00

668 lines
19 KiB
C

/* Skipping uninteresting files and functions while stepping.
Copyright (C) 2011-2017 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "skip.h"
#include "value.h"
#include "valprint.h"
#include "ui-out.h"
#include "symtab.h"
#include "gdbcmd.h"
#include "command.h"
#include "completer.h"
#include "stack.h"
#include "cli/cli-utils.h"
#include "arch-utils.h"
#include "linespec.h"
#include "objfiles.h"
#include "breakpoint.h" /* for get_sal_arch () */
#include "source.h"
#include "filenames.h"
#include "fnmatch.h"
#include "gdb_regex.h"
#include "common/gdb_optional.h"
#include <list>
class skiplist_entry
{
public:
/* Create a skiplist_entry object and add it to the chain. */
static void add_entry (bool file_is_glob,
std::string &&file,
bool function_is_regexp,
std::string &&function);
/* Return true if the skip entry has a file or glob-style file
pattern that matches FUNCTION_SAL. */
bool skip_file_p (const symtab_and_line &function_sal) const;
/* Return true if the skip entry has a function or function regexp
that matches FUNCTION_NAME. */
bool skip_function_p (const char *function_name) const;
/* Getters. */
int number () const { return m_number; };
bool enabled () const { return m_enabled; };
bool file_is_glob () const { return m_file_is_glob; }
const std::string &file () const { return m_file; }
const std::string &function () const { return m_function; }
bool function_is_regexp () const { return m_function_is_regexp; }
/* Setters. */
void enable () { m_enabled = true; };
void disable () { m_enabled = false; };
/* Disable copy. */
skiplist_entry (const skiplist_entry &) = delete;
void operator= (const skiplist_entry &) = delete;
private:
/* Key that grants access to the constructor. */
struct private_key {};
public:
/* Public so we can construct with container::emplace_back. Since
it requires a private class key, it can't be called from outside.
Use the add_entry static factory method to construct instead. */
skiplist_entry (bool file_is_glob, std::string &&file,
bool function_is_regexp, std::string &&function,
private_key);
private:
/* Return true if we're stopped at a file to be skipped. */
bool do_skip_file_p (const symtab_and_line &function_sal) const;
/* Return true if we're stopped at a globbed file to be skipped. */
bool do_skip_gfile_p (const symtab_and_line &function_sal) const;
private: /* data */
int m_number = -1;
/* True if FILE is a glob-style pattern.
Otherwise it is the plain file name (possibly with directories). */
bool m_file_is_glob;
/* The name of the file or empty if no name. */
std::string m_file;
/* True if FUNCTION is a regexp.
Otherwise it is a plain function name (possibly with arguments,
for C++). */
bool m_function_is_regexp;
/* The name of the function or empty if no name. */
std::string m_function;
/* If this is a function regexp, the compiled form. */
gdb::optional<compiled_regex> m_compiled_function_regexp;
/* Enabled/disabled state. */
bool m_enabled = true;
};
static std::list<skiplist_entry> skiplist_entries;
static int highest_skiplist_entry_num = 0;
skiplist_entry::skiplist_entry (bool file_is_glob,
std::string &&file,
bool function_is_regexp,
std::string &&function,
private_key)
: m_file_is_glob (file_is_glob),
m_file (std::move (file)),
m_function_is_regexp (function_is_regexp),
m_function (std::move (function))
{
gdb_assert (!m_file.empty () || !m_function.empty ());
if (m_file_is_glob)
gdb_assert (!m_file.empty ());
if (m_function_is_regexp)
{
gdb_assert (!m_function.empty ());
int flags = REG_NOSUB;
#ifdef REG_EXTENDED
flags |= REG_EXTENDED;
#endif
gdb_assert (!m_function.empty ());
m_compiled_function_regexp.emplace (m_function.c_str (), flags,
_("regexp"));
}
}
void
skiplist_entry::add_entry (bool file_is_glob, std::string &&file,
bool function_is_regexp, std::string &&function)
{
skiplist_entries.emplace_back (file_is_glob,
std::move (file),
function_is_regexp,
std::move (function),
private_key {});
/* Incremented after push_back, in case push_back throws. */
skiplist_entries.back ().m_number = ++highest_skiplist_entry_num;
}
static void
skip_file_command (const char *arg, int from_tty)
{
struct symtab *symtab;
const char *filename = NULL;
/* If no argument was given, try to default to the last
displayed codepoint. */
if (arg == NULL)
{
symtab = get_last_displayed_symtab ();
if (symtab == NULL)
error (_("No default file now."));
/* It is not a typo, symtab_to_filename_for_display woule be needlessly
ambiguous. */
filename = symtab_to_fullname (symtab);
}
else
filename = arg;
skiplist_entry::add_entry (false, std::string (filename),
false, std::string ());
printf_filtered (_("File %s will be skipped when stepping.\n"), filename);
}
/* Create a skiplist entry for the given function NAME and add it to the
list. */
static void
skip_function (const char *name)
{
skiplist_entry::add_entry (false, std::string (), false, std::string (name));
printf_filtered (_("Function %s will be skipped when stepping.\n"), name);
}
static void
skip_function_command (const char *arg, int from_tty)
{
/* Default to the current function if no argument is given. */
if (arg == NULL)
{
const char *name = NULL;
CORE_ADDR pc;
if (!last_displayed_sal_is_valid ())
error (_("No default function now."));
pc = get_last_displayed_addr ();
if (!find_pc_partial_function (pc, &name, NULL, NULL))
{
error (_("No function found containing current program point %s."),
paddress (get_current_arch (), pc));
}
skip_function (name);
return;
}
skip_function (arg);
}
/* Process "skip ..." that does not match "skip file" or "skip function". */
static void
skip_command (char *arg, int from_tty)
{
const char *file = NULL;
const char *gfile = NULL;
const char *function = NULL;
const char *rfunction = NULL;
int i;
if (arg == NULL)
{
skip_function_command (arg, from_tty);
return;
}
gdb_argv argv (arg);
for (i = 0; argv[i] != NULL; ++i)
{
const char *p = argv[i];
const char *value = argv[i + 1];
if (strcmp (p, "-fi") == 0
|| strcmp (p, "-file") == 0)
{
if (value == NULL)
error (_("Missing value for %s option."), p);
file = value;
++i;
}
else if (strcmp (p, "-gfi") == 0
|| strcmp (p, "-gfile") == 0)
{
if (value == NULL)
error (_("Missing value for %s option."), p);
gfile = value;
++i;
}
else if (strcmp (p, "-fu") == 0
|| strcmp (p, "-function") == 0)
{
if (value == NULL)
error (_("Missing value for %s option."), p);
function = value;
++i;
}
else if (strcmp (p, "-rfu") == 0
|| strcmp (p, "-rfunction") == 0)
{
if (value == NULL)
error (_("Missing value for %s option."), p);
rfunction = value;
++i;
}
else if (*p == '-')
error (_("Invalid skip option: %s"), p);
else if (i == 0)
{
/* Assume the user entered "skip FUNCTION-NAME".
FUNCTION-NAME may be `foo (int)', and therefore we pass the
complete original arg to skip_function command as if the user
typed "skip function arg". */
skip_function_command (arg, from_tty);
return;
}
else
error (_("Invalid argument: %s"), p);
}
if (file != NULL && gfile != NULL)
error (_("Cannot specify both -file and -gfile."));
if (function != NULL && rfunction != NULL)
error (_("Cannot specify both -function and -rfunction."));
/* This shouldn't happen as "skip" by itself gets punted to
skip_function_command. */
gdb_assert (file != NULL || gfile != NULL
|| function != NULL || rfunction != NULL);
std::string entry_file;
if (file != NULL)
entry_file = file;
else if (gfile != NULL)
entry_file = gfile;
std::string entry_function;
if (function != NULL)
entry_function = function;
else if (rfunction != NULL)
entry_function = rfunction;
skiplist_entry::add_entry (gfile != NULL, std::move (entry_file),
rfunction != NULL, std::move (entry_function));
/* I18N concerns drive some of the choices here (we can't piece together
the output too much). OTOH we want to keep this simple. Therefore the
only polish we add to the output is to append "(s)" to "File" or
"Function" if they're a glob/regexp. */
{
const char *file_to_print = file != NULL ? file : gfile;
const char *function_to_print = function != NULL ? function : rfunction;
const char *file_text = gfile != NULL ? _("File(s)") : _("File");
const char *lower_file_text = gfile != NULL ? _("file(s)") : _("file");
const char *function_text
= rfunction != NULL ? _("Function(s)") : _("Function");
if (function_to_print == NULL)
{
printf_filtered (_("%s %s will be skipped when stepping.\n"),
file_text, file_to_print);
}
else if (file_to_print == NULL)
{
printf_filtered (_("%s %s will be skipped when stepping.\n"),
function_text, function_to_print);
}
else
{
printf_filtered (_("%s %s in %s %s will be skipped"
" when stepping.\n"),
function_text, function_to_print,
lower_file_text, file_to_print);
}
}
}
static void
info_skip_command (char *arg, int from_tty)
{
int num_printable_entries = 0;
struct value_print_options opts;
get_user_print_options (&opts);
/* Count the number of rows in the table and see if we need space for a
64-bit address anywhere. */
for (const skiplist_entry &e : skiplist_entries)
if (arg == NULL || number_is_in_list (arg, e.number ()))
num_printable_entries++;
if (num_printable_entries == 0)
{
if (arg == NULL)
current_uiout->message (_("Not skipping any files or functions.\n"));
else
current_uiout->message (
_("No skiplist entries found with number %s.\n"), arg);
return;
}
ui_out_emit_table table_emitter (current_uiout, 6, num_printable_entries,
"SkiplistTable");
current_uiout->table_header (5, ui_left, "number", "Num"); /* 1 */
current_uiout->table_header (3, ui_left, "enabled", "Enb"); /* 2 */
current_uiout->table_header (4, ui_right, "regexp", "Glob"); /* 3 */
current_uiout->table_header (20, ui_left, "file", "File"); /* 4 */
current_uiout->table_header (2, ui_right, "regexp", "RE"); /* 5 */
current_uiout->table_header (40, ui_noalign, "function", "Function"); /* 6 */
current_uiout->table_body ();
for (const skiplist_entry &e : skiplist_entries)
{
QUIT;
if (arg != NULL && !number_is_in_list (arg, e.number ()))
continue;
ui_out_emit_tuple tuple_emitter (current_uiout, "blklst-entry");
current_uiout->field_int ("number", e.number ()); /* 1 */
if (e.enabled ())
current_uiout->field_string ("enabled", "y"); /* 2 */
else
current_uiout->field_string ("enabled", "n"); /* 2 */
if (e.file_is_glob ())
current_uiout->field_string ("regexp", "y"); /* 3 */
else
current_uiout->field_string ("regexp", "n"); /* 3 */
current_uiout->field_string ("file",
e.file ().empty () ? "<none>"
: e.file ().c_str ()); /* 4 */
if (e.function_is_regexp ())
current_uiout->field_string ("regexp", "y"); /* 5 */
else
current_uiout->field_string ("regexp", "n"); /* 5 */
current_uiout->field_string ("function",
e.function ().empty () ? "<none>"
: e.function ().c_str ()); /* 6 */
current_uiout->text ("\n");
}
}
static void
skip_enable_command (const char *arg, int from_tty)
{
bool found = false;
for (skiplist_entry &e : skiplist_entries)
if (arg == NULL || number_is_in_list (arg, e.number ()))
{
e.enable ();
found = true;
}
if (!found)
error (_("No skiplist entries found with number %s."), arg);
}
static void
skip_disable_command (const char *arg, int from_tty)
{
bool found = false;
for (skiplist_entry &e : skiplist_entries)
if (arg == NULL || number_is_in_list (arg, e.number ()))
{
e.disable ();
found = true;
}
if (!found)
error (_("No skiplist entries found with number %s."), arg);
}
static void
skip_delete_command (const char *arg, int from_tty)
{
bool found = false;
for (auto it = skiplist_entries.begin (),
end = skiplist_entries.end ();
it != end;)
{
const skiplist_entry &e = *it;
if (arg == NULL || number_is_in_list (arg, e.number ()))
{
it = skiplist_entries.erase (it);
found = true;
}
else
++it;
}
if (!found)
error (_("No skiplist entries found with number %s."), arg);
}
bool
skiplist_entry::do_skip_file_p (const symtab_and_line &function_sal) const
{
/* Check first sole SYMTAB->FILENAME. It may not be a substring of
symtab_to_fullname as it may contain "./" etc. */
if (compare_filenames_for_search (function_sal.symtab->filename,
m_file.c_str ()))
return true;
/* Before we invoke realpath, which can get expensive when many
files are involved, do a quick comparison of the basenames. */
if (!basenames_may_differ
&& filename_cmp (lbasename (function_sal.symtab->filename),
lbasename (m_file.c_str ())) != 0)
return false;
/* Note: symtab_to_fullname caches its result, thus we don't have to. */
{
const char *fullname = symtab_to_fullname (function_sal.symtab);
if (compare_filenames_for_search (fullname, m_file.c_str ()))
return true;
}
return false;
}
bool
skiplist_entry::do_skip_gfile_p (const symtab_and_line &function_sal) const
{
/* Check first sole SYMTAB->FILENAME. It may not be a substring of
symtab_to_fullname as it may contain "./" etc. */
if (gdb_filename_fnmatch (m_file.c_str (), function_sal.symtab->filename,
FNM_FILE_NAME | FNM_NOESCAPE) == 0)
return true;
/* Before we invoke symtab_to_fullname, which is expensive, do a quick
comparison of the basenames.
Note that we assume that lbasename works with glob-style patterns.
If the basename of the glob pattern is something like "*.c" then this
isn't much of a win. Oh well. */
if (!basenames_may_differ
&& gdb_filename_fnmatch (lbasename (m_file.c_str ()),
lbasename (function_sal.symtab->filename),
FNM_FILE_NAME | FNM_NOESCAPE) != 0)
return false;
/* Note: symtab_to_fullname caches its result, thus we don't have to. */
{
const char *fullname = symtab_to_fullname (function_sal.symtab);
if (compare_glob_filenames_for_search (fullname, m_file.c_str ()))
return true;
}
return false;
}
bool
skiplist_entry::skip_file_p (const symtab_and_line &function_sal) const
{
if (m_file.empty ())
return false;
if (function_sal.symtab == NULL)
return false;
if (m_file_is_glob)
return do_skip_gfile_p (function_sal);
else
return do_skip_file_p (function_sal);
}
bool
skiplist_entry::skip_function_p (const char *function_name) const
{
if (m_function.empty ())
return false;
if (m_function_is_regexp)
{
gdb_assert (m_compiled_function_regexp);
return (m_compiled_function_regexp->exec (function_name, 0, NULL, 0)
== 0);
}
else
return strcmp_iw (function_name, m_function.c_str ()) == 0;
}
/* See skip.h. */
bool
function_name_is_marked_for_skip (const char *function_name,
const symtab_and_line &function_sal)
{
if (function_name == NULL)
return false;
for (const skiplist_entry &e : skiplist_entries)
{
if (!e.enabled ())
continue;
bool skip_by_file = e.skip_file_p (function_sal);
bool skip_by_function = e.skip_function_p (function_name);
/* If both file and function must match, make sure we don't errantly
exit if only one of them match. */
if (!e.file ().empty () && !e.function ().empty ())
{
if (skip_by_file && skip_by_function)
return true;
}
/* Only one of file/function is specified. */
else if (skip_by_file || skip_by_function)
return true;
}
return false;
}
void
_initialize_step_skip (void)
{
static struct cmd_list_element *skiplist = NULL;
struct cmd_list_element *c;
add_prefix_cmd ("skip", class_breakpoint, skip_command, _("\
Ignore a function while stepping.\n\
\n\
Usage: skip [FUNCTION-NAME]\n\
skip [<file-spec>] [<function-spec>]\n\
If no arguments are given, ignore the current function.\n\
\n\
<file-spec> is one of:\n\
-fi|-file FILE-NAME\n\
-gfi|-gfile GLOB-FILE-PATTERN\n\
<function-spec> is one of:\n\
-fu|-function FUNCTION-NAME\n\
-rfu|-rfunction FUNCTION-NAME-REGULAR-EXPRESSION"),
&skiplist, "skip ", 1, &cmdlist);
c = add_cmd ("file", class_breakpoint, skip_file_command, _("\
Ignore a file while stepping.\n\
Usage: skip file [FILE-NAME]\n\
If no filename is given, ignore the current file."),
&skiplist);
set_cmd_completer (c, filename_completer);
c = add_cmd ("function", class_breakpoint, skip_function_command, _("\
Ignore a function while stepping.\n\
Usage: skip function [FUNCTION-NAME]\n\
If no function name is given, skip the current function."),
&skiplist);
set_cmd_completer (c, location_completer);
add_cmd ("enable", class_breakpoint, skip_enable_command, _("\
Enable skip entries. You can specify numbers (e.g. \"skip enable 1 3\"), \
ranges (e.g. \"skip enable 4-8\"), or both (e.g. \"skip enable 1 3 4-8\").\n\n\
If you don't specify any numbers or ranges, we'll enable all skip entries.\n\n\
Usage: skip enable [NUMBERS AND/OR RANGES]"),
&skiplist);
add_cmd ("disable", class_breakpoint, skip_disable_command, _("\
Disable skip entries. You can specify numbers (e.g. \"skip disable 1 3\"), \
ranges (e.g. \"skip disable 4-8\"), or both (e.g. \"skip disable 1 3 4-8\").\n\n\
If you don't specify any numbers or ranges, we'll disable all skip entries.\n\n\
Usage: skip disable [NUMBERS AND/OR RANGES]"),
&skiplist);
add_cmd ("delete", class_breakpoint, skip_delete_command, _("\
Delete skip entries. You can specify numbers (e.g. \"skip delete 1 3\"), \
ranges (e.g. \"skip delete 4-8\"), or both (e.g. \"skip delete 1 3 4-8\").\n\n\
If you don't specify any numbers or ranges, we'll delete all skip entries.\n\n\
Usage: skip delete [NUMBERS AND/OR RANGES]"),
&skiplist);
add_info ("skip", info_skip_command, _("\
Display the status of skips. You can specify numbers (e.g. \"skip info 1 3\"), \
ranges (e.g. \"skip info 4-8\"), or both (e.g. \"skip info 1 3 4-8\").\n\n\
If you don't specify any numbers or ranges, we'll show all skips.\n\n\
Usage: skip info [NUMBERS AND/OR RANGES]\n\
The \"Type\" column indicates one of:\n\
\tfile - ignored file\n\
\tfunction - ignored function"));
}