mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-28 04:25:10 +08:00
72ca041044
With my debug build of Python (--with-pydebug), many tests fails because
of the same issue. Python scripts are loaded by the tests using this
pattern:
(gdb) python exec (open ('file.py').read ())
This causes Python to output this warning:
__main__:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='file.py' mode='r' encoding='ANSI_X3.4-1968'>
and the test to fail because of that extra output. Instead of using the
open + read + exec trick which leaks the file and causes the warning,
why not just source the files?
(gdb) source file.py
This patch changes this, and standardizes the test names of the tests I
touched to "load python file" (some of them were empty, others were
overly complicated).
gdb/testsuite/ChangeLog:
* gdb.python/py-bad-printers.exp: Load python file using "source".
* gdb.python/py-events.exp: Likewise.
* gdb.python/py-evsignal.exp: Likewise.
* gdb.python/py-evthreads.exp: Likewise.
* gdb.python/py-frame-args.exp: Likewise.
* gdb.python/py-framefilter-invalidarg.exp: Likewise.
* gdb.python/py-framefilter-mi.exp: Likewise.
* gdb.python/py-framefilter.exp: Likewise.
* gdb.python/py-mi.exp: Likewise.
* gdb.python/py-pp-maint.exp: Likewise.
* gdb.python/py-pp-registration.exp: Likewise.
* gdb.python/py-prettyprint.exp: Likewise.
(run_lang_tests): Likewise.
* gdb.python/py-typeprint.exp: Likewise.
82 lines
2.6 KiB
Plaintext
82 lines
2.6 KiB
Plaintext
# Copyright (C) 2010-2017 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
if {[is_remote target]} {
|
|
# RuntimeError: Could not find event thread
|
|
kfail "python/12966" "Run to breakpoint 1"
|
|
return -1
|
|
}
|
|
|
|
if { ![support_displaced_stepping] } {
|
|
unsupported "displaced stepping"
|
|
return -1
|
|
}
|
|
|
|
load_lib gdb-python.exp
|
|
|
|
standard_testfile
|
|
set pyfile ${srcdir}/${subdir}/py-events.py
|
|
|
|
if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
|
|
return -1
|
|
}
|
|
clean_restart $testfile
|
|
|
|
if { [skip_python_tests] } { continue }
|
|
|
|
gdb_test_no_output "source ${pyfile}" "load python file"
|
|
|
|
gdb_test "test-events" "Event testers registered."
|
|
gdb_test_no_output "set non-stop on"
|
|
|
|
gdb_breakpoint "main"
|
|
gdb_breakpoint "thread2"
|
|
gdb_breakpoint "thread3"
|
|
|
|
gdb_run_cmd
|
|
set test "run to breakpoint 1"
|
|
gdb_test_multiple "" $test {
|
|
-re "event type: stop\r\nstop reason: breakpoint\r\nfirst breakpoint number: 1\r\nbreakpoint number: 1\r\nthread num: 1\r\n.*$gdb_prompt $" {
|
|
pass $test
|
|
}
|
|
-re "The target does not support running in non-stop mode" {
|
|
unsupported "non-stop mode is unsupported"
|
|
return
|
|
}
|
|
}
|
|
|
|
gdb_test "next" "event type: stop\r\nstop reason: breakpoint\r\nfirst breakpoint number: 2\r\nbreakpoint number: 2\r\nthread num: 2.*" "reached breakpoint 2"
|
|
|
|
gdb_test "thread 2" {\[Switching to thread 2 .*}
|
|
|
|
gdb_test "next" "event type: stop\r\nstop reason: breakpoint\r\nfirst breakpoint number: 3\r\nbreakpoint number: 3\r\nthread num: 3.*" "reached breakpoint 3"
|
|
|
|
gdb_test "thread 3" {\[Switching to thread 3 .*}
|
|
|
|
set test "continue thread 1"
|
|
gdb_test_multiple "continue&" $test {
|
|
-re "event type: continue\r\nthread num: 3\r\n$gdb_prompt " {
|
|
# This expect string must not expect the end-of-buffer '$'.
|
|
pass $test
|
|
}
|
|
}
|
|
|
|
set test "thread 3 was signaled"
|
|
gdb_test_multiple "" $test {
|
|
-re "event type: stop\r\nstop reason: signal\r\nstop signal: SIGUSR1\r\nthread num: 3\r\nevent type: stop\r\n" {
|
|
pass $test
|
|
}
|
|
}
|