mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-01 05:55:23 +08:00
a9a87d3525
With the new member functions for struct trad_frame_saved_reg, there is no need to invoke some of the set/get functions anymore. This patch removes those and adjusts all callers. Even though the most natural initial state of a saved register value is UNKNOWN, there are target backends relying on the previous initial state of REALREG set to a register's own number. I noticed this in at least a couple targets: aarch64 and riscv. Because of that, I decided to keep the reset function that sets the set of register values to REALREG. I can't exercise all the targets to make sure the initial state change won't break things, hence why it is risky to change the default. Validated with --enable-targets=all on aarch64-linux Ubuntu 18.04/20.04. gdb/ChangeLog 2021-01-19 Luis Machado <luis.machado@linaro.org> * trad-frame.h (trad_frame_saved_reg) <set_value_bytes>: Allocate memory and save data. (trad_frame_set_value, trad_frame_set_realreg, trad_frame_set_addr) (trad_frame_set_unknown, trad_frame_set_value_bytes) (trad_frame_value_p, trad_frame_addr_p, trad_frame_realreg_p) (trad_frame_value_bytes_p): Remove. (trad_frame_reset_saved_regs): Adjust documentation. * trad-frame.c (trad_frame_alloc_saved_regs): Initialize via a constructor and reset the state of the registers. (trad_frame_value_p, trad_frame_addr_p, trad_frame_realreg_p) (trad_frame_value_bytes_p, trad_frame_set_value) (trad_frame_set_realreg, trad_frame_set_addr) (trad_frame_set_unknown, trad_frame_set_value_bytes): Remove. (trad_frame_set_reg_realreg): Update to call member function. (trad_frame_set_reg_addr, trad_frame_set_reg_value_bytes): Likewise. (trad_frame_get_prev_register): Likewise. * aarch64-tdep.c (aarch64_analyze_prologue) (aarch64_analyze_prologue_test, aarch64_make_prologue_cache_1) (aarch64_prologue_prev_register): Update to use member functions. * alpha-mdebug-tdep.c (alpha_mdebug_frame_unwind_cache): Likewise. * alpha-tdep.c (alpha_heuristic_frame_unwind_cache): Likewise. * arc-tdep.c (arc_print_frame_cache, arc_make_frame_cache): Likewise. * arm-tdep.c (arm_make_prologue_cache, arm_exidx_fill_cache) (arm_make_epilogue_frame_cache): Likewise. * avr-tdep.c (avr_frame_unwind_cache) (avr_frame_prev_register): Likewise. * cris-tdep.c (cris_scan_prologue): Likewise. * csky-tdep.c (csky_frame_unwind_cache): Likewise. * frv-tdep.c (frv_analyze_prologue): Likewise. * hppa-tdep.c (hppa_frame_cache, hppa_fallback_frame_cache): Likewise. * lm32-tdep.c (lm32_frame_cache): Likewise. * m32r-tdep.c (m32r_frame_unwind_cache): Likewise. * m68hc11-tdep.c (m68hc11_frame_unwind_cache): Likewise. * mips-tdep.c (set_reg_offset, mips_insn16_frame_cache) (mips_micro_frame_cache, mips_insn32_frame_cache): Likewise. (reset_saved_regs): Adjust to set realreg. * riscv-tdep.c (riscv_scan_prologue, riscv_frame_cache): Adjust to call member functions. * rs6000-tdep.c (rs6000_frame_cache, rs6000_epilogue_frame_cache) * s390-tdep.c (s390_prologue_frame_unwind_cache) (s390_backchain_frame_unwind_cache): Likewise. * score-tdep.c (score7_analyze_prologue) (score3_analyze_prologue, score_make_prologue_cache): Likewise. * sparc-netbsd-tdep.c (sparc32nbsd_sigcontext_saved_regs): Likewise. * sparc-sol2-tdep.c (sparc32_sol2_sigtramp_frame_cache): Likewise. * sparc64-netbsd-tdep.c (sparc64nbsd_sigcontext_saved_regs): Likewise. * sparc64-sol2-tdep.c (sparc64_sol2_sigtramp_frame_cache): Likewise. * tilegx-tdep.c (tilegx_analyze_prologue) (tilegx_frame_cache): Likewise. * v850-tdep.c (v850_frame_cache): Likewise. * vax-tdep.c (vax_frame_cache): Likewise.
207 lines
5.9 KiB
C++
207 lines
5.9 KiB
C++
/* Traditional frame unwind support, for GDB the GNU Debugger.
|
|
|
|
Copyright (C) 2003-2021 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef TRAD_FRAME_H
|
|
#define TRAD_FRAME_H
|
|
|
|
#include "frame.h" /* For "struct frame_id". */
|
|
|
|
struct frame_info;
|
|
struct regcache_map_entry;
|
|
struct trad_frame_cache;
|
|
|
|
/* A simple, or traditional frame cache.
|
|
|
|
The entire cache is populated in a single pass and then generic
|
|
routines are used to extract the various cache values. */
|
|
|
|
struct trad_frame_cache *trad_frame_cache_zalloc (struct frame_info *);
|
|
|
|
/* This frame's ID. */
|
|
void trad_frame_set_id (struct trad_frame_cache *this_trad_cache,
|
|
struct frame_id this_id);
|
|
void trad_frame_get_id (struct trad_frame_cache *this_trad_cache,
|
|
struct frame_id *this_id);
|
|
void trad_frame_set_this_base (struct trad_frame_cache *this_trad_cache,
|
|
CORE_ADDR this_base);
|
|
CORE_ADDR trad_frame_get_this_base (struct trad_frame_cache *this_trad_cache);
|
|
|
|
void trad_frame_set_reg_realreg (struct trad_frame_cache *this_trad_cache,
|
|
int regnum, int realreg);
|
|
void trad_frame_set_reg_addr (struct trad_frame_cache *this_trad_cache,
|
|
int regnum, CORE_ADDR addr);
|
|
void trad_frame_set_reg_regmap (struct trad_frame_cache *this_trad_cache,
|
|
const struct regcache_map_entry *regmap,
|
|
CORE_ADDR addr, size_t size);
|
|
void trad_frame_set_reg_value (struct trad_frame_cache *this_cache,
|
|
int regnum, LONGEST val);
|
|
|
|
/* Given the cache in THIS_TRAD_CACHE, set the value of REGNUM to the bytes
|
|
contained in BYTES with size SIZE. */
|
|
void trad_frame_set_reg_value_bytes (struct trad_frame_cache *this_trad_cache,
|
|
int regnum,
|
|
gdb::array_view<const gdb_byte> bytes);
|
|
|
|
struct value *trad_frame_get_register (struct trad_frame_cache *this_trad_cache,
|
|
struct frame_info *this_frame,
|
|
int regnum);
|
|
|
|
/* Describes the kind of encoding a stored register has. */
|
|
enum class trad_frame_saved_reg_kind
|
|
{
|
|
/* Register value is unknown. */
|
|
UNKNOWN = 0,
|
|
/* Register value is a constant. */
|
|
VALUE,
|
|
/* Register value is in another register. */
|
|
REALREG,
|
|
/* Register value is at an address. */
|
|
ADDR,
|
|
/* Register value is a sequence of bytes. */
|
|
VALUE_BYTES
|
|
};
|
|
|
|
/* A struct that describes a saved register in a frame. */
|
|
|
|
struct trad_frame_saved_reg
|
|
{
|
|
/* Setters */
|
|
|
|
/* Encode that the saved register's value is constant VAL in the
|
|
trad-frame. */
|
|
void set_value (LONGEST val)
|
|
{
|
|
m_kind = trad_frame_saved_reg_kind::VALUE;
|
|
m_reg.value = val;
|
|
}
|
|
|
|
/* Encode that the saved register's value is stored in register REALREG. */
|
|
void set_realreg (int realreg)
|
|
{
|
|
m_kind = trad_frame_saved_reg_kind::REALREG;
|
|
m_reg.realreg = realreg;
|
|
}
|
|
|
|
/* Encode that the saved register's value is stored in memory at ADDR. */
|
|
void set_addr (LONGEST addr)
|
|
{
|
|
m_kind = trad_frame_saved_reg_kind::ADDR;
|
|
m_reg.addr = addr;
|
|
}
|
|
|
|
/* Encode that the saved register's value is unknown. */
|
|
void set_unknown ()
|
|
{
|
|
m_kind = trad_frame_saved_reg_kind::UNKNOWN;
|
|
}
|
|
|
|
/* Encode that the saved register's value is stored as a sequence of bytes.
|
|
This is useful when the value is larger than what primitive types
|
|
can hold. */
|
|
void set_value_bytes (gdb::array_view<const gdb_byte> bytes)
|
|
{
|
|
/* Allocate the space and copy the data bytes. */
|
|
gdb_byte *data = FRAME_OBSTACK_CALLOC (bytes.size (), gdb_byte);
|
|
memcpy (data, bytes.data (), bytes.size ());
|
|
|
|
m_kind = trad_frame_saved_reg_kind::VALUE_BYTES;
|
|
m_reg.value_bytes = data;
|
|
}
|
|
|
|
/* Getters */
|
|
|
|
LONGEST value () const
|
|
{
|
|
gdb_assert (m_kind == trad_frame_saved_reg_kind::VALUE);
|
|
return m_reg.value;
|
|
}
|
|
|
|
int realreg () const
|
|
{
|
|
gdb_assert (m_kind == trad_frame_saved_reg_kind::REALREG);
|
|
return m_reg.realreg;
|
|
}
|
|
|
|
LONGEST addr () const
|
|
{
|
|
gdb_assert (m_kind == trad_frame_saved_reg_kind::ADDR);
|
|
return m_reg.addr;
|
|
}
|
|
|
|
const gdb_byte *value_bytes () const
|
|
{
|
|
gdb_assert (m_kind == trad_frame_saved_reg_kind::VALUE_BYTES);
|
|
return m_reg.value_bytes;
|
|
}
|
|
|
|
/* Convenience functions, return true if the register has been
|
|
encoded as specified. Return false otherwise. */
|
|
bool is_value () const
|
|
{
|
|
return m_kind == trad_frame_saved_reg_kind::VALUE;
|
|
}
|
|
|
|
bool is_realreg () const
|
|
{
|
|
return m_kind == trad_frame_saved_reg_kind::REALREG;
|
|
}
|
|
|
|
bool is_addr () const
|
|
{
|
|
return m_kind == trad_frame_saved_reg_kind::ADDR;
|
|
}
|
|
|
|
bool is_unknown () const
|
|
{
|
|
return m_kind == trad_frame_saved_reg_kind::UNKNOWN;
|
|
}
|
|
|
|
bool is_value_bytes () const
|
|
{
|
|
return m_kind == trad_frame_saved_reg_kind::VALUE_BYTES;
|
|
}
|
|
|
|
private:
|
|
|
|
trad_frame_saved_reg_kind m_kind;
|
|
|
|
union {
|
|
LONGEST value;
|
|
int realreg;
|
|
LONGEST addr;
|
|
const gdb_byte *value_bytes;
|
|
} m_reg;
|
|
};
|
|
|
|
/* Reset the saved regs cache, setting register values to REALREG. */
|
|
void trad_frame_reset_saved_regs (struct gdbarch *gdbarch,
|
|
trad_frame_saved_reg *regs);
|
|
|
|
/* Return a freshly allocated (and initialized) trad_frame array. */
|
|
trad_frame_saved_reg *trad_frame_alloc_saved_regs (struct frame_info *);
|
|
trad_frame_saved_reg *trad_frame_alloc_saved_regs (struct gdbarch *);
|
|
|
|
/* Given the trad_frame info, return the location of the specified
|
|
register. */
|
|
struct value *trad_frame_get_prev_register (struct frame_info *this_frame,
|
|
trad_frame_saved_reg this_saved_regs[],
|
|
int regnum);
|
|
|
|
#endif
|