mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-25 02:53:48 +08:00
981a3fb359
This changes add_prefix_cmd to accept a const-taking function as an argument; then fixes up all the callers. In a couple of spots I had to add a non-const overload of a function, because the function is passed to two different command-adding "constructors". These overloads are temporary; once constification is complete they can be removed. This patch also fixes a typo I happened to notice while constifying. Note that this touches a couple of files (gnu-nat.c and go32-nat.c) that I can't build. So, while I made a best-effort there, I am not certain they will still compile. Tested by rebuilding. gdb/ChangeLog 2017-10-11 Tom Tromey <tom@tromey.com> * gdbthread.h (thread_command): Constify. * inferior.h (detach_command): Constify. * top.h (set_history, show_history): Constify. * arm-tdep.c (set_arm_command, show_arm_command): Constify. * serial.c (serial_set_cmd, serial_show_cmd): Constify. * bsd-kvm.c (bsd_kvm_cmd): Constify. * printcmd.c (set_command): Constify. (non_const_set_command): New function. * dcache.c (set_dcache_command, show_dcache_command): Constify. * breakpoint.c (enable_command, disable_command, delete_command) (catch_command, tcatch_command, set_breakpoint_cmd) (show_breakpoint_cmd): Constify. * macrocmd.c (macro_command): Constify. * infcmd.c (unset_command, kill_command, detach_command) (info_proc_cmd): Constify. * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Constify. * auto-load.c (show_auto_load_cmd, set_auto_load_cmd) (info_auto_load_cmd): Constify. * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd) (unset_tdesc_cmd): Constify. * ada-lang.c (set_ada_command, show_ada_command) (maint_set_ada_cmd, maint_show_ada_cmd): Constify. * guile/guile.c (set_guile_command, show_guile_command) (info_guile_command): Constify. * tui/tui-win.c (tui_command, set_tui_cmd, show_tui_cmd): Constify. * skip.c (skip_command): Constify. * compile/compile.c (_initialize_compile): Constify. * dwarf2read.c (set_dwarf_cmd, show_dwarf_cmd): Constify. * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd) (maint_btrace_show_cmd, maint_btrace_pt_set_cmd) (maint_btrace_pt_show_cmd): Constify. * remote.c (set_remote_cmd, show_remote_cmd, remote_command): Constify. * python/python.c (user_show_python, user_set_python): Constify. * mips-tdep.c (set_mips_command, show_mips_command) (set_mipsfpu_command): Constify. * record-btrace.c (cmd_record_btrace_start) (cmd_set_record_btrace, cmd_show_record_btrace) (cmd_set_record_btrace_bts, cmd_show_record_btrace_bts) (cmd_set_record_btrace_pt, cmd_show_record_btrace_pt): Constify. * rs6000-tdep.c (set_powerpc_command, show_powerpc_command): Constify. * symfile.c (overlay_command): Constify. * spu-tdep.c (set_spu_command, show_spu_command): Constify. * cli/cli-logging.c (set_logging_command, show_logging_command): Constify. * cli/cli-dump.c (dump_command, append_command) (srec_dump_command, ihex_dump_command, verilog_dump_command) (tekhex_dump_command, binary_dump_command) (binary_append_command): Constify. * cli/cli-decode.c (struct cmd_list_element): Change type of "fun". * cli/cli-cmds.c (info_command, show_command, set_debug) (show_debug): Constify. (show_command): Add non-const overload. * top.c (set_history, show_history): Constify. * sh-tdep.c (set_sh_command, show_sh_command): Constify. * command.h (add_prefix_cmd): Accept a cmd_const_cfunc_ftype. * target.c (target_command): Constify. * sparc64-tdep.c (info_adi_command): Constify. * record-full.c (cmd_record_full_start): Constify. (set_record_full_command): Constify. Fix typo. (show_record_full_command): Constify. * thread.c (thread_command, thread_apply_command): Constify. * memattr.c (dummy_cmd): Constify. * value.c (function_command): Constify. * frame.c (set_backtrace_cmd, show_backtrace_cmd): Constify. * probe.c (info_probes_command): Constify. * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Constify. * gnu-nat.c (set_task_cmd, show_task_cmd, set_thread_cmd) (show_thread_cmd, set_thread_default_cmd) (show_thread_default_cmd): Constify. (check_empty): Constify. * tracepoint.c (tfind_command): Constify. * cp-support.c (maint_cplus_command): Constify. * windows-tdep.c (info_w32_command): Constify. * record.c (cmd_record_start, set_record_command) (show_record_command, info_record_command, cmd_record_goto): Constify. * ravenscar-thread.c (set_ravenscar_command) (show_ravenscar_command): Constify. * utils.c (set_internal_problem_cmd, show_internal_problem_cmd): Constify. (add_internal_problem_command): Remove casts. * arc-tdep.c (maintenance_print_arc_command): Constify. * valprint.c (set_print, show_print, set_print_raw) (show_print_raw): Constify. * maint.c (maintenance_command, maintenance_info_command) (maintenance_print_command, maintenance_set_cmd) (maintenance_show_cmd, set_per_command_cmd) (show_per_command_cmd, maintenance_check_command): Constify. * language.c (set_check, show_check): Constify. * typeprint.c (show_print_type, set_print_type): Constify. * go32-nat.c (go32_info_dos_command): Constify.
406 lines
10 KiB
C
406 lines
10 KiB
C
/* BSD Kernel Data Access Library (libkvm) interface.
|
||
|
||
Copyright (C) 2004-2017 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#define _KMEMUSER
|
||
#include "defs.h"
|
||
#include "cli/cli-cmds.h"
|
||
#include "command.h"
|
||
#include "frame.h"
|
||
#include "regcache.h"
|
||
#include "target.h"
|
||
#include "value.h"
|
||
#include "gdbcore.h" /* for get_exec_file */
|
||
#include "gdbthread.h"
|
||
|
||
#include <fcntl.h>
|
||
#include <kvm.h>
|
||
#ifdef HAVE_NLIST_H
|
||
#include <nlist.h>
|
||
#endif
|
||
#include <paths.h>
|
||
#include "readline/readline.h"
|
||
#include <sys/param.h>
|
||
#include <sys/proc.h>
|
||
#ifdef HAVE_SYS_USER_H
|
||
#include <sys/user.h>
|
||
#endif
|
||
|
||
#include "bsd-kvm.h"
|
||
|
||
/* Kernel memory device file. */
|
||
static const char *bsd_kvm_corefile;
|
||
|
||
/* Kernel memory interface descriptor. */
|
||
static kvm_t *core_kd;
|
||
|
||
/* Address of process control block. */
|
||
static struct pcb *bsd_kvm_paddr;
|
||
|
||
/* Pointer to architecture-specific function that reconstructs the
|
||
register state from PCB and supplies it to REGCACHE. */
|
||
static int (*bsd_kvm_supply_pcb)(struct regcache *regcache, struct pcb *pcb);
|
||
|
||
/* Target ops for libkvm interface. */
|
||
static struct target_ops bsd_kvm_ops;
|
||
|
||
/* This is the ptid we use while we're connected to kvm. The kvm
|
||
target currently doesn't export any view of the running processes,
|
||
so this represents the kernel task. */
|
||
static ptid_t bsd_kvm_ptid;
|
||
|
||
static void
|
||
bsd_kvm_open (const char *arg, int from_tty)
|
||
{
|
||
char errbuf[_POSIX2_LINE_MAX];
|
||
char *execfile = NULL;
|
||
kvm_t *temp_kd;
|
||
char *filename = NULL;
|
||
|
||
target_preopen (from_tty);
|
||
|
||
if (arg)
|
||
{
|
||
char *temp;
|
||
|
||
filename = tilde_expand (arg);
|
||
if (filename[0] != '/')
|
||
{
|
||
temp = concat (current_directory, "/", filename, (char *)NULL);
|
||
xfree (filename);
|
||
filename = temp;
|
||
}
|
||
}
|
||
|
||
execfile = get_exec_file (0);
|
||
temp_kd = kvm_openfiles (execfile, filename, NULL,
|
||
write_files ? O_RDWR : O_RDONLY, errbuf);
|
||
if (temp_kd == NULL)
|
||
error (("%s"), errbuf);
|
||
|
||
bsd_kvm_corefile = filename;
|
||
unpush_target (&bsd_kvm_ops);
|
||
core_kd = temp_kd;
|
||
push_target (&bsd_kvm_ops);
|
||
|
||
add_thread_silent (bsd_kvm_ptid);
|
||
inferior_ptid = bsd_kvm_ptid;
|
||
|
||
target_fetch_registers (get_current_regcache (), -1);
|
||
|
||
reinit_frame_cache ();
|
||
print_stack_frame (get_selected_frame (NULL), 0, SRC_AND_LOC, 1);
|
||
}
|
||
|
||
static void
|
||
bsd_kvm_close (struct target_ops *self)
|
||
{
|
||
if (core_kd)
|
||
{
|
||
if (kvm_close (core_kd) == -1)
|
||
warning (("%s"), kvm_geterr(core_kd));
|
||
core_kd = NULL;
|
||
}
|
||
|
||
inferior_ptid = null_ptid;
|
||
delete_thread_silent (bsd_kvm_ptid);
|
||
}
|
||
|
||
static LONGEST
|
||
bsd_kvm_xfer_memory (CORE_ADDR addr, ULONGEST len,
|
||
gdb_byte *readbuf, const gdb_byte *writebuf)
|
||
{
|
||
ssize_t nbytes = len;
|
||
|
||
if (readbuf)
|
||
nbytes = kvm_read (core_kd, addr, readbuf, nbytes);
|
||
if (writebuf && nbytes > 0)
|
||
nbytes = kvm_write (core_kd, addr, writebuf, nbytes);
|
||
return nbytes;
|
||
}
|
||
|
||
static enum target_xfer_status
|
||
bsd_kvm_xfer_partial (struct target_ops *ops, enum target_object object,
|
||
const char *annex, gdb_byte *readbuf,
|
||
const gdb_byte *writebuf,
|
||
ULONGEST offset, ULONGEST len, ULONGEST *xfered_len)
|
||
{
|
||
switch (object)
|
||
{
|
||
case TARGET_OBJECT_MEMORY:
|
||
{
|
||
LONGEST ret = bsd_kvm_xfer_memory (offset, len, readbuf, writebuf);
|
||
|
||
if (ret < 0)
|
||
return TARGET_XFER_E_IO;
|
||
else if (ret == 0)
|
||
return TARGET_XFER_EOF;
|
||
else
|
||
{
|
||
*xfered_len = (ULONGEST) ret;
|
||
return TARGET_XFER_OK;
|
||
}
|
||
}
|
||
|
||
default:
|
||
return TARGET_XFER_E_IO;
|
||
}
|
||
}
|
||
|
||
static void
|
||
bsd_kvm_files_info (struct target_ops *ops)
|
||
{
|
||
if (bsd_kvm_corefile && strcmp (bsd_kvm_corefile, _PATH_MEM) != 0)
|
||
printf_filtered (_("\tUsing the kernel crash dump %s.\n"),
|
||
bsd_kvm_corefile);
|
||
else
|
||
printf_filtered (_("\tUsing the currently running kernel.\n"));
|
||
}
|
||
|
||
/* Fetch process control block at address PADDR. */
|
||
|
||
static int
|
||
bsd_kvm_fetch_pcb (struct regcache *regcache, struct pcb *paddr)
|
||
{
|
||
struct pcb pcb;
|
||
|
||
if (kvm_read (core_kd, (unsigned long) paddr, &pcb, sizeof pcb) == -1)
|
||
error (("%s"), kvm_geterr (core_kd));
|
||
|
||
gdb_assert (bsd_kvm_supply_pcb);
|
||
return bsd_kvm_supply_pcb (regcache, &pcb);
|
||
}
|
||
|
||
static void
|
||
bsd_kvm_fetch_registers (struct target_ops *ops,
|
||
struct regcache *regcache, int regnum)
|
||
{
|
||
struct nlist nl[2];
|
||
|
||
if (bsd_kvm_paddr)
|
||
{
|
||
bsd_kvm_fetch_pcb (regcache, bsd_kvm_paddr);
|
||
return;
|
||
}
|
||
|
||
/* On dumping core, BSD kernels store the faulting context (PCB)
|
||
in the variable "dumppcb". */
|
||
memset (nl, 0, sizeof nl);
|
||
nl[0].n_name = "_dumppcb";
|
||
|
||
if (kvm_nlist (core_kd, nl) == -1)
|
||
error (("%s"), kvm_geterr (core_kd));
|
||
|
||
if (nl[0].n_value != 0)
|
||
{
|
||
/* Found dumppcb. If it contains a valid context, return
|
||
immediately. */
|
||
if (bsd_kvm_fetch_pcb (regcache, (struct pcb *) nl[0].n_value))
|
||
return;
|
||
}
|
||
|
||
/* Traditional BSD kernels have a process proc0 that should always
|
||
be present. The address of proc0's PCB is stored in the variable
|
||
"proc0paddr". */
|
||
|
||
memset (nl, 0, sizeof nl);
|
||
nl[0].n_name = "_proc0paddr";
|
||
|
||
if (kvm_nlist (core_kd, nl) == -1)
|
||
error (("%s"), kvm_geterr (core_kd));
|
||
|
||
if (nl[0].n_value != 0)
|
||
{
|
||
struct pcb *paddr;
|
||
|
||
/* Found proc0paddr. */
|
||
if (kvm_read (core_kd, nl[0].n_value, &paddr, sizeof paddr) == -1)
|
||
error (("%s"), kvm_geterr (core_kd));
|
||
|
||
bsd_kvm_fetch_pcb (regcache, paddr);
|
||
return;
|
||
}
|
||
|
||
#ifdef HAVE_STRUCT_THREAD_TD_PCB
|
||
/* In FreeBSD kernels for 5.0-RELEASE and later, the PCB no longer
|
||
lives in `struct proc' but in `struct thread'. The `struct
|
||
thread' for the initial thread for proc0 can be found in the
|
||
variable "thread0". */
|
||
|
||
memset (nl, 0, sizeof nl);
|
||
nl[0].n_name = "_thread0";
|
||
|
||
if (kvm_nlist (core_kd, nl) == -1)
|
||
error (("%s"), kvm_geterr (core_kd));
|
||
|
||
if (nl[0].n_value != 0)
|
||
{
|
||
struct pcb *paddr;
|
||
|
||
/* Found thread0. */
|
||
nl[0].n_value += offsetof (struct thread, td_pcb);
|
||
if (kvm_read (core_kd, nl[0].n_value, &paddr, sizeof paddr) == -1)
|
||
error (("%s"), kvm_geterr (core_kd));
|
||
|
||
bsd_kvm_fetch_pcb (regcache, paddr);
|
||
return;
|
||
}
|
||
#endif
|
||
|
||
/* i18n: PCB == "Process Control Block". */
|
||
error (_("Cannot find a valid PCB"));
|
||
}
|
||
|
||
|
||
/* Kernel memory interface commands. */
|
||
struct cmd_list_element *bsd_kvm_cmdlist;
|
||
|
||
static void
|
||
bsd_kvm_cmd (const char *arg, int fromtty)
|
||
{
|
||
/* ??? Should this become an alias for "target kvm"? */
|
||
}
|
||
|
||
#ifndef HAVE_STRUCT_THREAD_TD_PCB
|
||
|
||
static void
|
||
bsd_kvm_proc_cmd (char *arg, int fromtty)
|
||
{
|
||
CORE_ADDR addr;
|
||
|
||
if (arg == NULL)
|
||
error_no_arg (_("proc address"));
|
||
|
||
if (core_kd == NULL)
|
||
error (_("No kernel memory image."));
|
||
|
||
addr = parse_and_eval_address (arg);
|
||
#ifdef HAVE_STRUCT_LWP
|
||
addr += offsetof (struct lwp, l_addr);
|
||
#else
|
||
addr += offsetof (struct proc, p_addr);
|
||
#endif
|
||
|
||
if (kvm_read (core_kd, addr, &bsd_kvm_paddr, sizeof bsd_kvm_paddr) == -1)
|
||
error (("%s"), kvm_geterr (core_kd));
|
||
|
||
target_fetch_registers (get_current_regcache (), -1);
|
||
|
||
reinit_frame_cache ();
|
||
print_stack_frame (get_selected_frame (NULL), 0, SRC_AND_LOC, 1);
|
||
}
|
||
|
||
#endif
|
||
|
||
static void
|
||
bsd_kvm_pcb_cmd (char *arg, int fromtty)
|
||
{
|
||
if (arg == NULL)
|
||
/* i18n: PCB == "Process Control Block". */
|
||
error_no_arg (_("pcb address"));
|
||
|
||
if (core_kd == NULL)
|
||
error (_("No kernel memory image."));
|
||
|
||
bsd_kvm_paddr = (struct pcb *)(u_long) parse_and_eval_address (arg);
|
||
|
||
target_fetch_registers (get_current_regcache (), -1);
|
||
|
||
reinit_frame_cache ();
|
||
print_stack_frame (get_selected_frame (NULL), 0, SRC_AND_LOC, 1);
|
||
}
|
||
|
||
static int
|
||
bsd_kvm_thread_alive (struct target_ops *ops,
|
||
ptid_t ptid)
|
||
{
|
||
return 1;
|
||
}
|
||
|
||
static const char *
|
||
bsd_kvm_pid_to_str (struct target_ops *ops, ptid_t ptid)
|
||
{
|
||
static char buf[64];
|
||
xsnprintf (buf, sizeof buf, "<kvm>");
|
||
return buf;
|
||
}
|
||
|
||
static int
|
||
bsd_kvm_return_one (struct target_ops *ops)
|
||
{
|
||
return 1;
|
||
}
|
||
|
||
/* Add the libkvm interface to the list of all possible targets and
|
||
register CUPPLY_PCB as the architecture-specific process control
|
||
block interpreter. */
|
||
|
||
void
|
||
bsd_kvm_add_target (int (*supply_pcb)(struct regcache *, struct pcb *))
|
||
{
|
||
gdb_assert (bsd_kvm_supply_pcb == NULL);
|
||
bsd_kvm_supply_pcb = supply_pcb;
|
||
|
||
bsd_kvm_ops.to_shortname = "kvm";
|
||
bsd_kvm_ops.to_longname = _("Kernel memory interface");
|
||
bsd_kvm_ops.to_doc = _("Use a kernel virtual memory image as a target.\n\
|
||
Optionally specify the filename of a core dump.");
|
||
bsd_kvm_ops.to_open = bsd_kvm_open;
|
||
bsd_kvm_ops.to_close = bsd_kvm_close;
|
||
bsd_kvm_ops.to_fetch_registers = bsd_kvm_fetch_registers;
|
||
bsd_kvm_ops.to_xfer_partial = bsd_kvm_xfer_partial;
|
||
bsd_kvm_ops.to_files_info = bsd_kvm_files_info;
|
||
bsd_kvm_ops.to_thread_alive = bsd_kvm_thread_alive;
|
||
bsd_kvm_ops.to_pid_to_str = bsd_kvm_pid_to_str;
|
||
bsd_kvm_ops.to_stratum = process_stratum;
|
||
bsd_kvm_ops.to_has_memory = bsd_kvm_return_one;
|
||
bsd_kvm_ops.to_has_stack = bsd_kvm_return_one;
|
||
bsd_kvm_ops.to_has_registers = bsd_kvm_return_one;
|
||
bsd_kvm_ops.to_magic = OPS_MAGIC;
|
||
|
||
add_target (&bsd_kvm_ops);
|
||
|
||
add_prefix_cmd ("kvm", class_obscure, bsd_kvm_cmd, _("\
|
||
Generic command for manipulating the kernel memory interface."),
|
||
&bsd_kvm_cmdlist, "kvm ", 0, &cmdlist);
|
||
|
||
#ifndef HAVE_STRUCT_THREAD_TD_PCB
|
||
add_cmd ("proc", class_obscure, bsd_kvm_proc_cmd,
|
||
_("Set current context from proc address"), &bsd_kvm_cmdlist);
|
||
#endif
|
||
add_cmd ("pcb", class_obscure, bsd_kvm_pcb_cmd,
|
||
/* i18n: PCB == "Process Control Block". */
|
||
_("Set current context from pcb address"), &bsd_kvm_cmdlist);
|
||
|
||
/* Some notes on the ptid usage on this target.
|
||
|
||
The pid field represents the kvm inferior instance. Currently,
|
||
we don't support multiple kvm inferiors, but we start at 1
|
||
anyway. The lwp field is set to != 0, in case the core wants to
|
||
refer to the whole kvm inferior with ptid(1,0,0).
|
||
|
||
If kvm is made to export running processes as gdb threads,
|
||
the following form can be used:
|
||
ptid (1, 1, 0) -> kvm inferior 1, in kernel
|
||
ptid (1, 1, 1) -> kvm inferior 1, process 1
|
||
ptid (1, 1, 2) -> kvm inferior 1, process 2
|
||
ptid (1, 1, n) -> kvm inferior 1, process n */
|
||
|
||
bsd_kvm_ptid = ptid_build (1, 1, 0);
|
||
}
|