mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-27 12:03:41 +08:00
a068643d69
Currently the target pid_to_str method returns a const char *, so many implementations have a static buffer that they update. This patch changes these methods to return a std::string instead. I think this is cleaner and avoids possible gotchas when calling pid_to_str on different ptids in a single statement. (Though no such calls exist currently.) This also updates various helper functions, and the gdbarch pid_to_str methods. I also made a best effort to fix all the callers, but I can't build some of the *-nat.c files. Tested by the buildbot. gdb/ChangeLog 2019-03-13 Tom Tromey <tromey@adacore.com> * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers) (i386_gnu_nat_target::store_registers): Update. * target-debug.h (target_debug_print_std_string): New macro. * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update. * windows-tdep.c (display_one_tib): Update. * tui/tui-stack.c (tui_make_status_line): Update. * top.c (print_inferior_quit_action): Update. * thread.c (thr_try_catch_cmd): Update. (add_thread_with_info): Update. (thread_target_id_str): Update. (thr_try_catch_cmd): Update. (thread_command): Update. (thread_find_command): Update. * record-btrace.c (record_btrace_target::info_record) (record_btrace_resume_thread, record_btrace_target::resume) (record_btrace_cancel_resume, record_btrace_step_thread) (record_btrace_target::wait, record_btrace_target::wait) (record_btrace_target::wait, record_btrace_target::stop): Update. * progspace.c (print_program_space): Update. * process-stratum-target.c (process_stratum_target::thread_address_space): Update. * linux-fork.c (linux_fork_mourn_inferior) (detach_checkpoint_command, info_checkpoints_command) (linux_fork_context): Update. (linux_fork_detach): Update. (class scoped_switch_fork_info): Update. (delete_checkpoint_command): Update. * infrun.c (follow_fork_inferior): Update. (follow_fork_inferior): Update. (proceed_after_vfork_done): Update. (handle_vfork_child_exec_or_exit): Update. (follow_exec): Update. (displaced_step_prepare_throw): Update. (displaced_step_restore): Update. (start_step_over): Update. (resume_1): Update. (clear_proceed_status_thread): Update. (proceed): Update. (print_target_wait_results): Update. (do_target_wait): Update. (context_switch): Update. (stop_all_threads): Update. (restart_threads): Update. (finish_step_over): Update. (handle_signal_stop): Update. (switch_back_to_stepped_thread): Update. (keep_going_pass_signal): Update. (print_exited_reason): Update. (normal_stop): Update. * inferior.c (inferior_pid_to_str): Change return type. (print_selected_inferior): Update. (add_inferior): Update. (detach_inferior): Update. * dummy-frame.c (fprint_dummy_frames): Update. * dcache.c (dcache_info_1): Update. * btrace.c (btrace_enable, btrace_disable, btrace_teardown) (btrace_fetch, btrace_clear): Update. * linux-tdep.c (linux_core_pid_to_str): Change return type. * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return type. * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type. * sol2-tdep.h (sol2_core_pid_to_str): Change return type. * sol2-tdep.c (sol2_core_pid_to_str): Change return type. * gdbarch.c, gdbarch.h: Rebuild. * gdbarch.sh (core_pid_to_str): Change return type. * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change return type. (windows_nat_target::pid_to_str): Change return type. (windows_delete_thread): Update. (windows_nat_target::attach): Update. (windows_nat_target::files_info): Update. * target-delegates.c: Rebuild. * sol-thread.c (class sol_thread_target) <pid_to_str>: Change return type. (sol_thread_target::pid_to_str): Change return type. * remote.c (class remote_target) <pid_to_str>: Change return type. (remote_target::pid_to_str): Change return type. (extended_remote_target::attach, remote_target::remote_stop_ns) (remote_target::remote_notif_remove_queued_reply) (remote_target::push_stop_reply, remote_target::disable_btrace): Update. (extended_remote_target::attach): Update. * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return type. (gdbsim_target::pid_to_str): Change return type. * ravenscar-thread.c (struct ravenscar_thread_target) <pid_to_str>: Change return type. (ravenscar_thread_target::pid_to_str): Change return type. * procfs.c (class procfs_target) <pid_to_str>: Change return type. (procfs_target::pid_to_str): Change return type. (procfs_target::attach): Update. (procfs_target::detach): Update. (procfs_target::fetch_registers): Update. (procfs_target::store_registers): Update. (procfs_target::wait): Update. (procfs_target::files_info): Update. * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type. * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change return type. (nto_procfs_target::pid_to_str): Change return type. (nto_procfs_target::files_info, nto_procfs_target::attach): Update. * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change return type. * linux-nat.c (linux_nat_target::pid_to_str): Change return type. (exit_lwp): Update. (attach_proc_task_lwp_callback, get_detach_signal) (detach_one_lwp, resume_lwp, linux_nat_target::resume) (linux_nat_target::resume, wait_lwp, stop_callback) (maybe_clear_ignore_sigint, stop_wait_callback, status_callback) (save_stop_reason, select_event_lwp, linux_nat_filter_event) (linux_nat_wait_1, resume_stopped_resumed_lwps) (linux_nat_target::wait, linux_nat_stop_lwp): Update. * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return type. (inf_ptrace_target::attach): Update. (inf_ptrace_target::files_info): Update. * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return type. (go32_nat_target::pid_to_str): Change return type. * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type. (gnu_nat_target::wait): Update. (gnu_nat_target::wait): Update. (gnu_nat_target::resume): Update. * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type. (fbsd_nat_target::wait): Update. * darwin-nat.c (darwin_nat_target::pid_to_str): Change return type. (darwin_nat_target::attach): Update. * corelow.c (class core_target) <pid_to_str>: Change return type. (core_target::pid_to_str): Change return type. * target.c (normal_pid_to_str): Change return type. (default_pid_to_str): Likewise. (target_pid_to_str): Change return type. (target_translate_tls_address): Update. (target_announce_detach): Update. * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change return type. (bsd_uthread_target::pid_to_str): Change return type. * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return type. (bsd_kvm_target::pid_to_str): Change return type. * aix-thread.c (class aix_thread_target) <pid_to_str>: Change return type. (aix_thread_target::pid_to_str): Change return type. * target.h (struct target_ops) <pid_to_str>: Change return type. (target_pid_to_str, normal_pid_to_str): Likewise. * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return type. * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return type. * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change return type. * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return type. * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return type. * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change return type.
417 lines
10 KiB
C
417 lines
10 KiB
C
/* BSD Kernel Data Access Library (libkvm) interface.
|
||
|
||
Copyright (C) 2004-2019 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#define _KMEMUSER
|
||
#include "defs.h"
|
||
#include "cli/cli-cmds.h"
|
||
#include "command.h"
|
||
#include "frame.h"
|
||
#include "regcache.h"
|
||
#include "target.h"
|
||
#include "process-stratum-target.h"
|
||
#include "value.h"
|
||
#include "gdbcore.h"
|
||
#include "inferior.h" /* for get_exec_file */
|
||
#include "gdbthread.h"
|
||
|
||
#include <fcntl.h>
|
||
#include <kvm.h>
|
||
#ifdef HAVE_NLIST_H
|
||
#include <nlist.h>
|
||
#endif
|
||
#include <paths.h>
|
||
#include "readline/readline.h"
|
||
#include <sys/param.h>
|
||
#include <sys/proc.h>
|
||
#ifdef HAVE_SYS_USER_H
|
||
#include <sys/user.h>
|
||
#endif
|
||
|
||
#include "bsd-kvm.h"
|
||
|
||
/* Kernel memory device file. */
|
||
static const char *bsd_kvm_corefile;
|
||
|
||
/* Kernel memory interface descriptor. */
|
||
static kvm_t *core_kd;
|
||
|
||
/* Address of process control block. */
|
||
static struct pcb *bsd_kvm_paddr;
|
||
|
||
/* Pointer to architecture-specific function that reconstructs the
|
||
register state from PCB and supplies it to REGCACHE. */
|
||
static int (*bsd_kvm_supply_pcb)(struct regcache *regcache, struct pcb *pcb);
|
||
|
||
/* This is the ptid we use while we're connected to kvm. The kvm
|
||
target currently doesn't export any view of the running processes,
|
||
so this represents the kernel task. */
|
||
static ptid_t bsd_kvm_ptid;
|
||
|
||
/* The libkvm target. */
|
||
|
||
static const target_info bsd_kvm_target_info = {
|
||
"kvm",
|
||
N_("Kernel memory interface"),
|
||
N_("Use a kernel virtual memory image as a target.\n\
|
||
Optionally specify the filename of a core dump.")
|
||
};
|
||
|
||
class bsd_kvm_target final : public process_stratum_target
|
||
{
|
||
public:
|
||
bsd_kvm_target () = default;
|
||
|
||
const target_info &info () const override
|
||
{ return bsd_kvm_target_info; }
|
||
|
||
void close () override;
|
||
|
||
void fetch_registers (struct regcache *, int) override;
|
||
enum target_xfer_status xfer_partial (enum target_object object,
|
||
const char *annex,
|
||
gdb_byte *readbuf,
|
||
const gdb_byte *writebuf,
|
||
ULONGEST offset, ULONGEST len,
|
||
ULONGEST *xfered_len) override;
|
||
|
||
void files_info () override;
|
||
bool thread_alive (ptid_t ptid) override;
|
||
std::string pid_to_str (ptid_t) override;
|
||
|
||
bool has_memory () override { return true; }
|
||
bool has_stack () override { return true; }
|
||
bool has_registers () override { return true; }
|
||
};
|
||
|
||
/* Target ops for libkvm interface. */
|
||
static bsd_kvm_target bsd_kvm_ops;
|
||
|
||
static void
|
||
bsd_kvm_target_open (const char *arg, int from_tty)
|
||
{
|
||
char errbuf[_POSIX2_LINE_MAX];
|
||
char *execfile = NULL;
|
||
kvm_t *temp_kd;
|
||
char *filename = NULL;
|
||
|
||
target_preopen (from_tty);
|
||
|
||
if (arg)
|
||
{
|
||
char *temp;
|
||
|
||
filename = tilde_expand (arg);
|
||
if (filename[0] != '/')
|
||
{
|
||
temp = concat (current_directory, "/", filename, (char *)NULL);
|
||
xfree (filename);
|
||
filename = temp;
|
||
}
|
||
}
|
||
|
||
execfile = get_exec_file (0);
|
||
temp_kd = kvm_openfiles (execfile, filename, NULL,
|
||
write_files ? O_RDWR : O_RDONLY, errbuf);
|
||
if (temp_kd == NULL)
|
||
error (("%s"), errbuf);
|
||
|
||
bsd_kvm_corefile = filename;
|
||
unpush_target (&bsd_kvm_ops);
|
||
core_kd = temp_kd;
|
||
push_target (&bsd_kvm_ops);
|
||
|
||
add_thread_silent (bsd_kvm_ptid);
|
||
inferior_ptid = bsd_kvm_ptid;
|
||
|
||
target_fetch_registers (get_current_regcache (), -1);
|
||
|
||
reinit_frame_cache ();
|
||
print_stack_frame (get_selected_frame (NULL), 0, SRC_AND_LOC, 1);
|
||
}
|
||
|
||
void
|
||
bsd_kvm_target::close ()
|
||
{
|
||
if (core_kd)
|
||
{
|
||
if (kvm_close (core_kd) == -1)
|
||
warning (("%s"), kvm_geterr(core_kd));
|
||
core_kd = NULL;
|
||
}
|
||
|
||
inferior_ptid = null_ptid;
|
||
discard_all_inferiors ();
|
||
}
|
||
|
||
static LONGEST
|
||
bsd_kvm_xfer_memory (CORE_ADDR addr, ULONGEST len,
|
||
gdb_byte *readbuf, const gdb_byte *writebuf)
|
||
{
|
||
ssize_t nbytes = len;
|
||
|
||
if (readbuf)
|
||
nbytes = kvm_read (core_kd, addr, readbuf, nbytes);
|
||
if (writebuf && nbytes > 0)
|
||
nbytes = kvm_write (core_kd, addr, writebuf, nbytes);
|
||
return nbytes;
|
||
}
|
||
|
||
enum target_xfer_status
|
||
bsd_kvm_target::xfer_partial (enum target_object object,
|
||
const char *annex, gdb_byte *readbuf,
|
||
const gdb_byte *writebuf,
|
||
ULONGEST offset, ULONGEST len, ULONGEST *xfered_len)
|
||
{
|
||
switch (object)
|
||
{
|
||
case TARGET_OBJECT_MEMORY:
|
||
{
|
||
LONGEST ret = bsd_kvm_xfer_memory (offset, len, readbuf, writebuf);
|
||
|
||
if (ret < 0)
|
||
return TARGET_XFER_E_IO;
|
||
else if (ret == 0)
|
||
return TARGET_XFER_EOF;
|
||
else
|
||
{
|
||
*xfered_len = (ULONGEST) ret;
|
||
return TARGET_XFER_OK;
|
||
}
|
||
}
|
||
|
||
default:
|
||
return TARGET_XFER_E_IO;
|
||
}
|
||
}
|
||
|
||
void
|
||
bsd_kvm_target::files_info ()
|
||
{
|
||
if (bsd_kvm_corefile && strcmp (bsd_kvm_corefile, _PATH_MEM) != 0)
|
||
printf_filtered (_("\tUsing the kernel crash dump %s.\n"),
|
||
bsd_kvm_corefile);
|
||
else
|
||
printf_filtered (_("\tUsing the currently running kernel.\n"));
|
||
}
|
||
|
||
/* Fetch process control block at address PADDR. */
|
||
|
||
static int
|
||
bsd_kvm_fetch_pcb (struct regcache *regcache, struct pcb *paddr)
|
||
{
|
||
struct pcb pcb;
|
||
|
||
if (kvm_read (core_kd, (unsigned long) paddr, &pcb, sizeof pcb) == -1)
|
||
error (("%s"), kvm_geterr (core_kd));
|
||
|
||
gdb_assert (bsd_kvm_supply_pcb);
|
||
return bsd_kvm_supply_pcb (regcache, &pcb);
|
||
}
|
||
|
||
void
|
||
bsd_kvm_target::fetch_registers (struct regcache *regcache, int regnum)
|
||
{
|
||
struct nlist nl[2];
|
||
|
||
if (bsd_kvm_paddr)
|
||
{
|
||
bsd_kvm_fetch_pcb (regcache, bsd_kvm_paddr);
|
||
return;
|
||
}
|
||
|
||
/* On dumping core, BSD kernels store the faulting context (PCB)
|
||
in the variable "dumppcb". */
|
||
memset (nl, 0, sizeof nl);
|
||
nl[0].n_name = "_dumppcb";
|
||
|
||
if (kvm_nlist (core_kd, nl) == -1)
|
||
error (("%s"), kvm_geterr (core_kd));
|
||
|
||
if (nl[0].n_value != 0)
|
||
{
|
||
/* Found dumppcb. If it contains a valid context, return
|
||
immediately. */
|
||
if (bsd_kvm_fetch_pcb (regcache, (struct pcb *) nl[0].n_value))
|
||
return;
|
||
}
|
||
|
||
/* Traditional BSD kernels have a process proc0 that should always
|
||
be present. The address of proc0's PCB is stored in the variable
|
||
"proc0paddr". */
|
||
|
||
memset (nl, 0, sizeof nl);
|
||
nl[0].n_name = "_proc0paddr";
|
||
|
||
if (kvm_nlist (core_kd, nl) == -1)
|
||
error (("%s"), kvm_geterr (core_kd));
|
||
|
||
if (nl[0].n_value != 0)
|
||
{
|
||
struct pcb *paddr;
|
||
|
||
/* Found proc0paddr. */
|
||
if (kvm_read (core_kd, nl[0].n_value, &paddr, sizeof paddr) == -1)
|
||
error (("%s"), kvm_geterr (core_kd));
|
||
|
||
bsd_kvm_fetch_pcb (regcache, paddr);
|
||
return;
|
||
}
|
||
|
||
#ifdef HAVE_STRUCT_THREAD_TD_PCB
|
||
/* In FreeBSD kernels for 5.0-RELEASE and later, the PCB no longer
|
||
lives in `struct proc' but in `struct thread'. The `struct
|
||
thread' for the initial thread for proc0 can be found in the
|
||
variable "thread0". */
|
||
|
||
memset (nl, 0, sizeof nl);
|
||
nl[0].n_name = "_thread0";
|
||
|
||
if (kvm_nlist (core_kd, nl) == -1)
|
||
error (("%s"), kvm_geterr (core_kd));
|
||
|
||
if (nl[0].n_value != 0)
|
||
{
|
||
struct pcb *paddr;
|
||
|
||
/* Found thread0. */
|
||
nl[0].n_value += offsetof (struct thread, td_pcb);
|
||
if (kvm_read (core_kd, nl[0].n_value, &paddr, sizeof paddr) == -1)
|
||
error (("%s"), kvm_geterr (core_kd));
|
||
|
||
bsd_kvm_fetch_pcb (regcache, paddr);
|
||
return;
|
||
}
|
||
#endif
|
||
|
||
/* i18n: PCB == "Process Control Block". */
|
||
error (_("Cannot find a valid PCB"));
|
||
}
|
||
|
||
|
||
/* Kernel memory interface commands. */
|
||
struct cmd_list_element *bsd_kvm_cmdlist;
|
||
|
||
static void
|
||
bsd_kvm_cmd (const char *arg, int fromtty)
|
||
{
|
||
/* ??? Should this become an alias for "target kvm"? */
|
||
}
|
||
|
||
#ifndef HAVE_STRUCT_THREAD_TD_PCB
|
||
|
||
static void
|
||
bsd_kvm_proc_cmd (const char *arg, int fromtty)
|
||
{
|
||
CORE_ADDR addr;
|
||
|
||
if (arg == NULL)
|
||
error_no_arg (_("proc address"));
|
||
|
||
if (core_kd == NULL)
|
||
error (_("No kernel memory image."));
|
||
|
||
addr = parse_and_eval_address (arg);
|
||
#ifdef HAVE_STRUCT_LWP
|
||
addr += offsetof (struct lwp, l_addr);
|
||
#else
|
||
addr += offsetof (struct proc, p_addr);
|
||
#endif
|
||
|
||
if (kvm_read (core_kd, addr, &bsd_kvm_paddr, sizeof bsd_kvm_paddr) == -1)
|
||
error (("%s"), kvm_geterr (core_kd));
|
||
|
||
target_fetch_registers (get_current_regcache (), -1);
|
||
|
||
reinit_frame_cache ();
|
||
print_stack_frame (get_selected_frame (NULL), 0, SRC_AND_LOC, 1);
|
||
}
|
||
|
||
#endif
|
||
|
||
static void
|
||
bsd_kvm_pcb_cmd (const char *arg, int fromtty)
|
||
{
|
||
if (arg == NULL)
|
||
/* i18n: PCB == "Process Control Block". */
|
||
error_no_arg (_("pcb address"));
|
||
|
||
if (core_kd == NULL)
|
||
error (_("No kernel memory image."));
|
||
|
||
bsd_kvm_paddr = (struct pcb *)(u_long) parse_and_eval_address (arg);
|
||
|
||
target_fetch_registers (get_current_regcache (), -1);
|
||
|
||
reinit_frame_cache ();
|
||
print_stack_frame (get_selected_frame (NULL), 0, SRC_AND_LOC, 1);
|
||
}
|
||
|
||
bool
|
||
bsd_kvm_target::thread_alive (ptid_t ptid)
|
||
{
|
||
return true;
|
||
}
|
||
|
||
std::string
|
||
bsd_kvm_target::pid_to_str (ptid_t ptid)
|
||
{
|
||
return "<kvm>";
|
||
}
|
||
|
||
/* Add the libkvm interface to the list of all possible targets and
|
||
register CUPPLY_PCB as the architecture-specific process control
|
||
block interpreter. */
|
||
|
||
void
|
||
bsd_kvm_add_target (int (*supply_pcb)(struct regcache *, struct pcb *))
|
||
{
|
||
gdb_assert (bsd_kvm_supply_pcb == NULL);
|
||
bsd_kvm_supply_pcb = supply_pcb;
|
||
|
||
add_target (bsd_kvm_target_info, bsd_kvm_target_open);
|
||
|
||
add_prefix_cmd ("kvm", class_obscure, bsd_kvm_cmd, _("\
|
||
Generic command for manipulating the kernel memory interface."),
|
||
&bsd_kvm_cmdlist, "kvm ", 0, &cmdlist);
|
||
|
||
#ifndef HAVE_STRUCT_THREAD_TD_PCB
|
||
add_cmd ("proc", class_obscure, bsd_kvm_proc_cmd,
|
||
_("Set current context from proc address"), &bsd_kvm_cmdlist);
|
||
#endif
|
||
add_cmd ("pcb", class_obscure, bsd_kvm_pcb_cmd,
|
||
/* i18n: PCB == "Process Control Block". */
|
||
_("Set current context from pcb address"), &bsd_kvm_cmdlist);
|
||
|
||
/* Some notes on the ptid usage on this target.
|
||
|
||
The pid field represents the kvm inferior instance. Currently,
|
||
we don't support multiple kvm inferiors, but we start at 1
|
||
anyway. The lwp field is set to != 0, in case the core wants to
|
||
refer to the whole kvm inferior with ptid(1,0,0).
|
||
|
||
If kvm is made to export running processes as gdb threads,
|
||
the following form can be used:
|
||
ptid (1, 1, 0) -> kvm inferior 1, in kernel
|
||
ptid (1, 1, 1) -> kvm inferior 1, process 1
|
||
ptid (1, 1, 2) -> kvm inferior 1, process 2
|
||
ptid (1, 1, n) -> kvm inferior 1, process n */
|
||
|
||
bsd_kvm_ptid = ptid_t (1, 1, 0);
|
||
}
|