mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-11 03:13:35 +08:00
cb1e4e32c2
Currently, with:
(gdb) catch catch
Catchpoint 1 (catch)
(gdb) catch throw
Catchpoint 2 (throw)
(gdb) catch rethrow
Catchpoint 3 (rethrow)
You get:
(gdb) info breakpoints
Num Type Disp Enb Address What
1 breakpoint keep y 0x0000000000b122af exception catch
2 breakpoint keep y 0x0000000000b1288d exception throw
3 breakpoint keep y 0x0000000000b12931 exception rethrow
I think it doesn't make much sense usability-wise, to show a
catchpoint as a breakpoint. The fact that GDB sets a breakpoint at
some magic address in the C++ run time is an implementation detail,
IMO. And as seen in the previous patch, such a catchpoint can end up
with more than one location/address even, so showing a single address
isn't entirely accurate.
This commit hides the addresses from view, and makes GDB show
"catchpoint" for type as well:
(gdb) info breakpoints
Num Type Disp Enb Address What
1 catchpoint keep y exception catch
2 catchpoint keep y exception throw
3 catchpoint keep y exception rethrow
This comment in the code seems telling:
/* We need to reset 'type' in order for code in breakpoint.c to do
the right thing. */
cp->type = bp_breakpoint;
It kind of suggests that the reason catchpoints end up shown as
breakpoints was that it was easier to implement them that way, rather
than a desired property.
This commit fixes things up to make it possible to have bp_catch
breakpoints have software/hardware breakpoint locations, thus
eliminating the need for that hack:
- redo breakpoint_address_is_meaningful in terms of the location's
type rather than breakpoint type.
- teach bpstat_what about stepping over the catchpoint locations.
- install a allocate_location method for "catch catch/throw/rethrow",
one that forces the location type.
Note that this also reverts the gdb hunk from:
commit
|
||
---|---|---|
.. | ||
.gitignore | ||
a4rc.sed | ||
agentexpr.texi | ||
all-cfg.texi | ||
annotate.texinfo | ||
ChangeLog | ||
doxy-index.in | ||
Doxyfile-base.in | ||
Doxyfile-gdb-api.in | ||
Doxyfile-gdb-xref.in | ||
Doxyfile-gdbserver.in | ||
fdl.texi | ||
filter-for-doxygen | ||
filter-params.pl | ||
gdb.texinfo | ||
gpl.texi | ||
guile.texi | ||
lpsrc.sed | ||
Makefile.in | ||
psrc.sed | ||
python.texi | ||
refcard.tex | ||
stabs.texinfo | ||
stack_frame.eps | ||
stack_frame.pdf | ||
stack_frame.png | ||
stack_frame.svg | ||
stack_frame.txt |