mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-29 04:53:56 +08:00
192b62ce0b
This introduces a new specialization of gdb::ref_ptr that can be used to manage BFD reference counts. Then it changes most places in gdb to use this new class, rather than explicit reference-counting or cleanups. This patch removes make_cleanup_bfd_unref. If you look you will see a couple of spots using "release" where a use of gdb_bfd_ref_ptr would be cleaner. These will be fixed in the next patch. I think this patch fixes some latent bugs. For example, it seems to me that previously objfpy_add_separate_debug_file leaked a BFD. I'm not 100% certain that the macho_symfile_read_all_oso change is correct. The existing code here is hard for me to follow. One goal of this sort of automated reference counting, though, is to make it more difficult to make logic errors; so hopefully the code is clear now. 2017-01-10 Tom Tromey <tom@tromey.com> * windows-tdep.c (windows_xfer_shared_library): Update. * windows-nat.c (windows_make_so): Update. * utils.h (make_cleanup_bfd_unref): Remove. * utils.c (do_bfd_close_cleanup, make_cleanup_bfd_unref): Remove. * symfile.h (symfile_bfd_open) (find_separate_debug_file_in_section): Return gdb_bfd_ref_ptr. * symfile.c (read_symbols, symbol_file_add) (separate_debug_file_exists): Update. (symfile_bfd_open): Return gdb_bfd_ref_ptr. (generic_load, reread_symbols): Update. * symfile-mem.c (symbol_file_add_from_memory): Update. * spu-linux-nat.c (spu_bfd_open): Return gdb_bfd_ref_ptr. (spu_symbol_file_add_from_memory): Update. * solist.h (struct target_so_ops) <bfd_open>: Return gdb_bfd_ref_ptr. (solib_bfd_fopen, solib_bfd_open): Return gdb_bfd_ref_ptr. * solib.c (solib_bfd_fopen, solib_bfd_open): Return gdb_bfd_ref_ptr. (solib_map_sections, reload_shared_libraries_1): Update. * solib-svr4.c (enable_break): Update. * solib-spu.c (spu_bfd_fopen): Return gdb_bfd_ref_ptr. * solib-frv.c (enable_break2): Update. * solib-dsbt.c (enable_break): Update. * solib-darwin.c (gdb_bfd_mach_o_fat_extract): Return gdb_bfd_ref_ptr. (darwin_solib_get_all_image_info_addr_at_init): Update. (darwin_bfd_open): Return gdb_bfd_ref_ptr. * solib-aix.c (solib_aix_bfd_open): Return gdb_bfd_ref_ptr. * record-full.c (record_full_save): Update. * python/py-objfile.c (objfpy_add_separate_debug_file): Update. * procfs.c (insert_dbx_link_bpt_in_file): Update. * minidebug.c (find_separate_debug_file_in_section): Return gdb_bfd_ref_ptr. * machoread.c (macho_add_oso_symfile): Change abfd to gdb_bfd_ref_ptr. (macho_symfile_read_all_oso): Update. (macho_check_dsym): Return gdb_bfd_ref_ptr. (macho_symfile_read): Update. * jit.c (bfd_open_from_target_memory): Return gdb_bfd_ref_ptr. (jit_bfd_try_read_symtab): Update. * gdb_bfd.h (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr) (gdb_bfd_openw, gdb_bfd_openr_iovec) (gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return gdb_bfd_ref_ptr. (gdb_bfd_ref_policy): New struct. (gdb_bfd_ref_ptr): New typedef. * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr) (gdb_bfd_openw, gdb_bfd_openr_iovec) (gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return gdb_bfd_ref_ptr. * gcore.h (create_gcore_bfd): Return gdb_bfd_ref_ptr. * gcore.c (create_gcore_bfd): Return gdb_bfd_ref_ptr. (gcore_command): Update. * exec.c (exec_file_attach): Update. * elfread.c (elf_symfile_read): Update. * dwarf2read.c (dwarf2_get_dwz_file): Update. (try_open_dwop_file, open_dwo_file): Return gdb_bfd_ref_ptr. (open_and_init_dwo_file): Update. (open_dwp_file): Return gdb_bfd_ref_ptr. (open_and_init_dwp_file): Update. * corelow.c (core_open): Update. * compile/compile-object-load.c (compile_object_load): Update. * common/gdb_ref_ptr.h (ref_ptr::operator->): New operator. * coffread.c (coff_symfile_read): Update. * cli/cli-dump.c (bfd_openr_or_error, bfd_openw_or_error): Return gdb_bfd_ref_ptr. Rename. (dump_bfd_file, restore_command): Update. * build-id.h (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr. * build-id.c (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr. (find_separate_debug_file_by_buildid): Update.
196 lines
7.7 KiB
C
196 lines
7.7 KiB
C
/* Shared library declarations for GDB, the GNU Debugger.
|
|
Copyright (C) 1990-2017 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef SOLIST_H
|
|
#define SOLIST_H
|
|
|
|
#define SO_NAME_MAX_PATH_SIZE 512 /* FIXME: Should be dynamic */
|
|
/* For domain_enum domain. */
|
|
#include "symtab.h"
|
|
#include "gdb_bfd.h"
|
|
|
|
/* Forward declaration for target specific link map information. This
|
|
struct is opaque to all but the target specific file. */
|
|
struct lm_info;
|
|
|
|
struct so_list
|
|
{
|
|
/* The following fields of the structure come directly from the
|
|
dynamic linker's tables in the inferior, and are initialized by
|
|
current_sos. */
|
|
|
|
struct so_list *next; /* next structure in linked list */
|
|
|
|
/* A pointer to target specific link map information. Often this
|
|
will be a copy of struct link_map from the user process, but
|
|
it need not be; it can be any collection of data needed to
|
|
traverse the dynamic linker's data structures. */
|
|
struct lm_info *lm_info;
|
|
|
|
/* Shared object file name, exactly as it appears in the
|
|
inferior's link map. This may be a relative path, or something
|
|
which needs to be looked up in LD_LIBRARY_PATH, etc. We use it
|
|
to tell which entries in the inferior's dynamic linker's link
|
|
map we've already loaded. */
|
|
char so_original_name[SO_NAME_MAX_PATH_SIZE];
|
|
|
|
/* Shared object file name, expanded to something GDB can open. */
|
|
char so_name[SO_NAME_MAX_PATH_SIZE];
|
|
|
|
/* Program space this shared library belongs to. */
|
|
struct program_space *pspace;
|
|
|
|
/* The following fields of the structure are built from
|
|
information gathered from the shared object file itself, and
|
|
are set when we actually add it to our symbol tables.
|
|
|
|
current_sos must initialize these fields to 0. */
|
|
|
|
bfd *abfd;
|
|
char symbols_loaded; /* flag: symbols read in yet? */
|
|
|
|
/* objfile with symbols for a loaded library. Target memory is read from
|
|
ABFD. OBJFILE may be NULL either before symbols have been loaded, if
|
|
the file cannot be found or after the command "nosharedlibrary". */
|
|
struct objfile *objfile;
|
|
|
|
struct target_section *sections;
|
|
struct target_section *sections_end;
|
|
|
|
/* Record the range of addresses belonging to this shared library.
|
|
There may not be just one (e.g. if two segments are relocated
|
|
differently); but this is only used for "info sharedlibrary". */
|
|
CORE_ADDR addr_low, addr_high;
|
|
};
|
|
|
|
struct target_so_ops
|
|
{
|
|
/* Adjust the section binding addresses by the base address at
|
|
which the object was actually mapped. */
|
|
void (*relocate_section_addresses) (struct so_list *so,
|
|
struct target_section *);
|
|
|
|
/* Free the link map info and any other private data structures
|
|
associated with a so_list entry. */
|
|
void (*free_so) (struct so_list *so);
|
|
|
|
/* Reset private data structures associated with SO.
|
|
This is called when SO is about to be reloaded.
|
|
It is also called before free_so when SO is about to be freed. */
|
|
void (*clear_so) (struct so_list *so);
|
|
|
|
/* Reset or free private data structures not associated with
|
|
so_list entries. */
|
|
void (*clear_solib) (void);
|
|
|
|
/* Target dependent code to run after child process fork. */
|
|
void (*solib_create_inferior_hook) (int from_tty);
|
|
|
|
/* Construct a list of the currently loaded shared objects. This
|
|
list does not include an entry for the main executable file.
|
|
|
|
Note that we only gather information directly available from the
|
|
inferior --- we don't examine any of the shared library files
|
|
themselves. The declaration of `struct so_list' says which fields
|
|
we provide values for. */
|
|
struct so_list *(*current_sos) (void);
|
|
|
|
/* Find, open, and read the symbols for the main executable. If
|
|
FROM_TTYP dereferences to a non-zero integer, allow messages to
|
|
be printed. This parameter is a pointer rather than an int
|
|
because open_symbol_file_object is called via catch_errors and
|
|
catch_errors requires a pointer argument. */
|
|
int (*open_symbol_file_object) (void *from_ttyp);
|
|
|
|
/* Determine if PC lies in the dynamic symbol resolution code of
|
|
the run time loader. */
|
|
int (*in_dynsym_resolve_code) (CORE_ADDR pc);
|
|
|
|
/* Find and open shared library binary file. */
|
|
gdb_bfd_ref_ptr (*bfd_open) (char *pathname);
|
|
|
|
/* Optional extra hook for finding and opening a solib.
|
|
If TEMP_PATHNAME is non-NULL: If the file is successfully opened a
|
|
pointer to a malloc'd and realpath'd copy of SONAME is stored there,
|
|
otherwise NULL is stored there. */
|
|
int (*find_and_open_solib) (const char *soname,
|
|
unsigned o_flags, char **temp_pathname);
|
|
|
|
/* Hook for looking up global symbols in a library-specific way. */
|
|
struct block_symbol (*lookup_lib_global_symbol)
|
|
(struct objfile *objfile,
|
|
const char *name,
|
|
const domain_enum domain);
|
|
|
|
/* Given two so_list objects, one from the GDB thread list
|
|
and another from the list returned by current_sos, return 1
|
|
if they represent the same library.
|
|
Falls back to using strcmp on so_original_name field when set
|
|
to NULL. */
|
|
int (*same) (struct so_list *gdb, struct so_list *inferior);
|
|
|
|
/* Return whether a region of memory must be kept in a core file
|
|
for shared libraries loaded before "gcore" is used to be
|
|
handled correctly when the core file is loaded. This only
|
|
applies when the section would otherwise not be kept in the
|
|
core file (in particular, for readonly sections). */
|
|
int (*keep_data_in_core) (CORE_ADDR vaddr,
|
|
unsigned long size);
|
|
|
|
/* Enable or disable optional solib event breakpoints as
|
|
appropriate. This should be called whenever
|
|
stop_on_solib_events is changed. This pointer can be
|
|
NULL, in which case no enabling or disabling is necessary
|
|
for this target. */
|
|
void (*update_breakpoints) (void);
|
|
|
|
/* Target-specific processing of solib events that will be
|
|
performed before solib_add is called. This pointer can be
|
|
NULL, in which case no specific preprocessing is necessary
|
|
for this target. */
|
|
void (*handle_event) (void);
|
|
};
|
|
|
|
/* Free the memory associated with a (so_list *). */
|
|
void free_so (struct so_list *so);
|
|
|
|
/* Return address of first so_list entry in master shared object list. */
|
|
struct so_list *master_so_list (void);
|
|
|
|
/* Find main executable binary file. */
|
|
extern char *exec_file_find (const char *in_pathname, int *fd);
|
|
|
|
/* Find shared library binary file. */
|
|
extern char *solib_find (const char *in_pathname, int *fd);
|
|
|
|
/* Open BFD for shared library file. */
|
|
extern gdb_bfd_ref_ptr solib_bfd_fopen (char *pathname, int fd);
|
|
|
|
/* Find solib binary file and open it. */
|
|
extern gdb_bfd_ref_ptr solib_bfd_open (char *in_pathname);
|
|
|
|
/* FIXME: gdbarch needs to control this variable. */
|
|
extern struct target_so_ops *current_target_so_ops;
|
|
|
|
/* Handler for library-specific global symbol lookup in solib.c. */
|
|
struct block_symbol solib_global_lookup (struct objfile *objfile,
|
|
const char *name,
|
|
const domain_enum domain);
|
|
|
|
#endif
|