binutils-gdb/gdb/regcache.h
Simon Marchi 98994c7a18 gdb: make regcache::raw_update switch to right inferior
With the following patch, which teaches the amd-dbgapi target to handle
inferiors that fork, we end up with target stacks in the following
state, when an inferior that does not use the GPU forks an inferior that
eventually uses the GPU.

    inf 1            inf 2
    -----            -----
                     amd-dbgapi
    linux-nat        linux-nat
    exec             exec

When a GPU thread from inferior 2 hits a breakpoint, the following
sequence of events would happen, if it was not for the current patch.

 - we start with inferior 1 as current
 - do_target_wait_1 makes inferior 2 current, does a target_wait, which
   returns a stop event for an amd-dbgapi wave (thread).
 - do_target_wait's scoped_restore_current_thread restores inferior 1 as
   current
 - fetch_inferior_event calls switch_to_target_no_thread with linux-nat
   as the process target, since linux-nat is officially the process
   target of inferior 2.  This makes inferior 1 the current inferior, as
   it's the first inferior with that target.
 - In handle_signal_stop, we have:

    ecs->event_thread->suspend.stop_pc
      = regcache_read_pc (get_thread_regcache (ecs->event_thread));

    context_switch (ecs);

   regcache_read_pc executes while inferior 1 is still the current one
   (because it's before the `context_switch`).  This is a problem,
   because the regcache is for a ptid managed by the amd-dbgapi target
   (e.g. (12345, 1, 1)), a ptid that does not make sense for the
   linux-nat target.  The fetch_registers target call goes directly
   to the linux-nat target, which gets confused.
 - We would then get an error like:

     Couldn't get extended state status: No such process.

   ... since linux-nat tries to do a ptrace call on tid 1.

GDB should switch to the inferior the ptid belongs to before doing the
target call to fetch registers, to make sure the call hits the right
target stack (it should be handled by the amd-dbgapi target in this
case).  In fact the following patch does this change, and it would be
enough to fix this specific problem.

However, I propose to change regcache to make it switch to the right
inferior, if needed, before doing target calls.  That makes the
interface as a whole more independent of the global context.

My first attempt at doing this was to find an inferior using the process
stratum target and the ptid that regcache already knows about:

      gdb::optional<scoped_restore_current_thread> restore_thread;
      inferior *inf = find_inferior_ptid (this->target (), this->ptid ());
      if (inf != current_inferior ())
	{
	  restore_thread.emplace ();
	  switch_to_inferior_no_thread (inf);
	}

However, this caused some failures in fork-related tests and gdbserver
boards.  When we detach a fork child, we may create a regcache for the
child, but there is no corresponding inferior.  For instance, to restore
the PC after a displaced step over the fork syscall.  So
find_inferior_ptid would return nullptr, and
switch_to_inferior_no_thread would hit a failed assertion.

So, this patch adds to regcache the information "the inferior to switch
to to makes target calls".  In typical cases, it will be the inferior
that matches the regcache's ptid.  But in some cases, like the detached
fork child one, it will be another inferior (in this example, it will be
the fork parent inferior).

The problem that we witnessed was in regcache::raw_update specifically,
but I looked for other regcache methods doing target calls, and added
the same inferior switching code to raw_write too.

In the regcache constructor and in get_thread_arch_aspace_regcache,
"inf_for_target_calls" replaces the process_stratum_target parameter.
We suppose that the process stratum target that would be passed
otherwise is the same that is in inf_for_target_calls's target stack, so
we don't need to pass both in parallel.  The process stratum target is
still used as a key in the `target_pid_ptid_regcache_map` map, but
that's it.

There is one spot that needs to be updated outside of the regcache code,
which is the path that handles the "restore PC after a displaced step in
a fork child we're about to detach" case mentioned above.

regcache_test_data needs to be changed to include full-fledged mock
contexts (because there now needs to be inferiors, not just targets).

Change-Id: Id088569ce106e1f194d9ae7240ff436f11c5e123
Reviewed-By: Pedro Alves <pedro@palves.net>
2023-04-17 13:47:13 -04:00

521 lines
17 KiB
C++

/* Cache and manage the values of registers for GDB, the GNU debugger.
Copyright (C) 1986-2023 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#ifndef REGCACHE_H
#define REGCACHE_H
#include "gdbsupport/common-regcache.h"
#include "gdbsupport/function-view.h"
struct regcache;
struct regset;
struct gdbarch;
struct address_space;
class thread_info;
struct process_stratum_target;
struct inferior;
extern struct regcache *get_current_regcache (void);
extern struct regcache *get_thread_regcache (process_stratum_target *target,
ptid_t ptid);
/* Get the regcache of THREAD. */
extern struct regcache *get_thread_regcache (thread_info *thread);
extern struct regcache *get_thread_arch_regcache
(process_stratum_target *targ, ptid_t, struct gdbarch *);
extern struct regcache *get_thread_arch_aspace_regcache
(inferior *inf_for_target_calls, ptid_t,
struct gdbarch *, struct address_space *);
extern enum register_status
regcache_raw_read_signed (struct regcache *regcache,
int regnum, LONGEST *val);
extern void regcache_raw_write_signed (struct regcache *regcache,
int regnum, LONGEST val);
extern void regcache_raw_write_unsigned (struct regcache *regcache,
int regnum, ULONGEST val);
/* Return the register's value in signed or throw if it's not
available. */
extern LONGEST regcache_raw_get_signed (struct regcache *regcache,
int regnum);
/* Read a register as a signed/unsigned quantity. */
extern enum register_status
regcache_cooked_read_signed (struct regcache *regcache,
int regnum, LONGEST *val);
extern enum register_status
regcache_cooked_read_unsigned (struct regcache *regcache,
int regnum, ULONGEST *val);
extern void regcache_cooked_write_signed (struct regcache *regcache,
int regnum, LONGEST val);
extern void regcache_cooked_write_unsigned (struct regcache *regcache,
int regnum, ULONGEST val);
/* Special routines to read/write the PC. */
/* For regcache_read_pc see gdbsupport/common-regcache.h. */
extern void regcache_write_pc (struct regcache *regcache, CORE_ADDR pc);
/* Mapping between register numbers and offsets in a buffer, for use
in the '*regset' functions below and with traditional frame caches.
In an array of 'regcache_map_entry' each element is interpreted
like follows:
- If 'regno' is a register number: Map register 'regno' to the
current offset (starting with 0) and increase the current offset
by 'size' (or the register's size, if 'size' is zero). Repeat
this with consecutive register numbers up to 'regno+count-1'.
For each described register, if 'size' is larger than the
register's size, the register's value is assumed to be stored in
the first N (where N is the register size) bytes at the current
offset. The remaining 'size' - N bytes are filled with zeroes by
'regcache_collect_regset' and ignored by other consumers.
If 'size' is smaller than the register's size, only the first
'size' bytes of a register's value are assumed to be stored at
the current offset. 'regcache_collect_regset' copies the first
'size' bytes of a register's value to the output buffer.
'regcache_supply_regset' copies the bytes from the input buffer
into the first 'size' bytes of the register's value leaving the
remaining bytes of the register's value unchanged. Frame caches
read the 'size' bytes from the stack frame and zero extend them
to generate the register's value.
- If 'regno' is REGCACHE_MAP_SKIP: Add 'count*size' to the current
offset.
- If count=0: End of the map. */
struct regcache_map_entry
{
int count;
int regno;
int size;
};
/* Special value for the 'regno' field in the struct above. */
enum
{
REGCACHE_MAP_SKIP = -1,
};
/* Calculate and return the total size of all the registers in a
regcache_map_entry. */
static inline int
regcache_map_entry_size (const struct regcache_map_entry *map)
{
int size = 0;
for (int i = 0; map[i].count != 0; i++)
size += (map[i].count * map[i].size);
return size;
}
/* Transfer a set of registers (as described by REGSET) between
REGCACHE and BUF. If REGNUM == -1, transfer all registers
belonging to the regset, otherwise just the register numbered
REGNUM. The REGSET's 'regmap' field must point to an array of
'struct regcache_map_entry'.
These functions are suitable for the 'regset_supply' and
'regset_collect' fields in a regset structure. */
extern void regcache_supply_regset (const struct regset *regset,
struct regcache *regcache,
int regnum, const void *buf,
size_t size);
extern void regcache_collect_regset (const struct regset *regset,
const struct regcache *regcache,
int regnum, void *buf, size_t size);
/* Return true if a set of registers contains the value of the
register numbered REGNUM. The size of the set of registers is
given in SIZE, and the layout of the set of registers is described
by MAP. */
extern bool regcache_map_supplies (const struct regcache_map_entry *map,
int regnum, struct gdbarch *gdbarch,
size_t size);
/* The type of a register. This function is slightly more efficient
then its gdbarch vector counterpart since it returns a precomputed
value stored in a table. */
extern struct type *register_type (struct gdbarch *gdbarch, int regnum);
/* Return the size of register REGNUM. All registers should have only
one size. */
extern int register_size (struct gdbarch *gdbarch, int regnum);
typedef gdb::function_view<register_status (int regnum, gdb_byte *buf)>
register_read_ftype;
/* A (register_number, register_value) pair. */
struct cached_reg_t
{
int num;
gdb_byte *data;
};
/* Buffer of registers. */
class reg_buffer : public reg_buffer_common
{
public:
reg_buffer (gdbarch *gdbarch, bool has_pseudo);
DISABLE_COPY_AND_ASSIGN (reg_buffer);
/* Return regcache's architecture. */
gdbarch *arch () const;
/* See gdbsupport/common-regcache.h. */
enum register_status get_register_status (int regnum) const override;
/* See gdbsupport/common-regcache.h. */
void raw_collect (int regnum, void *buf) const override;
/* Collect register REGNUM from REGCACHE. Store collected value as an integer
at address ADDR, in target endian, with length ADDR_LEN and sign IS_SIGNED.
If ADDR_LEN is greater than the register size, then the integer will be
sign or zero extended. If ADDR_LEN is smaller than the register size, then
the most significant bytes of the integer will be truncated. */
void raw_collect_integer (int regnum, gdb_byte *addr, int addr_len,
bool is_signed) const;
/* Collect register REGNUM from REGCACHE, starting at OFFSET in register,
reading only LEN. */
void raw_collect_part (int regnum, int offset, int len, gdb_byte *out) const;
/* See gdbsupport/common-regcache.h. */
void raw_supply (int regnum, const void *buf) override;
void raw_supply (int regnum, const reg_buffer &src)
{
raw_supply (regnum, src.register_buffer (regnum));
}
/* Supply register REGNUM to REGCACHE. Value to supply is an integer stored
at address ADDR, in target endian, with length ADDR_LEN and sign IS_SIGNED.
If the register size is greater than ADDR_LEN, then the integer will be
sign or zero extended. If the register size is smaller than the integer,
then the most significant bytes of the integer will be truncated. */
void raw_supply_integer (int regnum, const gdb_byte *addr, int addr_len,
bool is_signed);
/* Supply register REGNUM with zeroed value to REGCACHE. This is not the same
as calling raw_supply with NULL (which will set the state to
unavailable). */
void raw_supply_zeroed (int regnum);
/* Supply register REGNUM to REGCACHE, starting at OFFSET in register, writing
only LEN, without editing the rest of the register. */
void raw_supply_part (int regnum, int offset, int len, const gdb_byte *in);
void invalidate (int regnum);
virtual ~reg_buffer () = default;
/* See gdbsupport/common-regcache.h. */
bool raw_compare (int regnum, const void *buf, int offset) const override;
protected:
/* Assert on the range of REGNUM. */
void assert_regnum (int regnum) const;
int num_raw_registers () const;
gdb_byte *register_buffer (int regnum) const;
/* Save a register cache. The set of registers saved into the
regcache determined by the save_reggroup. COOKED_READ returns
zero iff the register's value can't be returned. */
void save (register_read_ftype cooked_read);
struct regcache_descr *m_descr;
bool m_has_pseudo;
/* The register buffers. */
std::unique_ptr<gdb_byte[]> m_registers;
/* Register cache status. */
std::unique_ptr<register_status[]> m_register_status;
friend class regcache;
friend class detached_regcache;
};
/* An abstract class which only has methods doing read. */
class readable_regcache : public reg_buffer
{
public:
readable_regcache (gdbarch *gdbarch, bool has_pseudo)
: reg_buffer (gdbarch, has_pseudo)
{}
/* Transfer a raw register [0..NUM_REGS) from core-gdb to this regcache,
return its value in *BUF and return its availability status. */
enum register_status raw_read (int regnum, gdb_byte *buf);
template<typename T, typename = RequireLongest<T>>
enum register_status raw_read (int regnum, T *val);
/* Partial transfer of raw registers. Return the status of the register. */
enum register_status raw_read_part (int regnum, int offset, int len,
gdb_byte *buf);
/* Make certain that the register REGNUM is up-to-date. */
virtual void raw_update (int regnum) = 0;
/* Transfer a raw register [0..NUM_REGS+NUM_PSEUDO_REGS) from core-gdb to
this regcache, return its value in *BUF and return its availability status. */
enum register_status cooked_read (int regnum, gdb_byte *buf);
template<typename T, typename = RequireLongest<T>>
enum register_status cooked_read (int regnum, T *val);
/* Partial transfer of a cooked register. */
enum register_status cooked_read_part (int regnum, int offset, int len,
gdb_byte *buf);
/* Read register REGNUM from the regcache and return a new value. This
will call mark_value_bytes_unavailable as appropriate. */
struct value *cooked_read_value (int regnum);
protected:
/* Perform a partial register transfer using a read, modify, write
operation. Will fail if register is currently invalid. */
enum register_status read_part (int regnum, int offset, int len,
gdb_byte *out, bool is_raw);
};
/* Buffer of registers, can be read and written. */
class detached_regcache : public readable_regcache
{
public:
detached_regcache (gdbarch *gdbarch, bool has_pseudo)
: readable_regcache (gdbarch, has_pseudo)
{}
void raw_update (int regnum) override
{}
DISABLE_COPY_AND_ASSIGN (detached_regcache);
};
class readonly_detached_regcache;
/* The register cache for storing raw register values. */
class regcache : public detached_regcache
{
public:
DISABLE_COPY_AND_ASSIGN (regcache);
/* Return REGCACHE's address space. */
const address_space *aspace () const
{
return m_aspace;
}
/* Restore 'this' regcache. The set of registers restored into
the regcache determined by the restore_reggroup.
Writes to regcache will go through to the target. SRC is a
read-only register cache. */
void restore (readonly_detached_regcache *src);
/* Update the value of raw register REGNUM (in the range [0..NUM_REGS)) and
transfer its value to core-gdb. */
void raw_write (int regnum, const gdb_byte *buf);
template<typename T, typename = RequireLongest<T>>
void raw_write (int regnum, T val);
/* Transfer of pseudo-registers. */
void cooked_write (int regnum, const gdb_byte *buf);
template<typename T, typename = RequireLongest<T>>
void cooked_write (int regnum, T val);
void raw_update (int regnum) override;
/* Partial transfer of raw registers. Perform read, modify, write style
operations. */
void raw_write_part (int regnum, int offset, int len, const gdb_byte *buf);
/* Partial transfer of a cooked register. Perform read, modify, write style
operations. */
void cooked_write_part (int regnum, int offset, int len,
const gdb_byte *buf);
/* Transfer a set of registers (as described by REGSET) between
REGCACHE and BUF. If REGNUM == -1, transfer all registers
belonging to the regset, otherwise just the register numbered
REGNUM. The REGSET's 'regmap' field must point to an array of
'struct regcache_map_entry'. The valid register numbers in each
entry in 'struct regcache_map_entry' are offset by REGBASE. */
void supply_regset (const struct regset *regset, int regbase,
int regnum, const void *buf, size_t size);
void collect_regset (const struct regset *regset, int regbase, int regnum,
void *buf, size_t size) const;
/* Same as the above, but with REGBASE == 0. */
void supply_regset (const struct regset *regset,
int regnum, const void *buf, size_t size)
{
supply_regset (regset, 0, regnum, buf, size);
}
void collect_regset (const struct regset *regset, int regnum,
void *buf, size_t size) const
{
collect_regset (regset, 0, regnum, buf, size);
}
/* Return REGCACHE's ptid. */
ptid_t ptid () const
{
gdb_assert (m_ptid != minus_one_ptid);
return m_ptid;
}
void set_ptid (const ptid_t ptid)
{
this->m_ptid = ptid;
}
/* Dump the contents of a register from the register cache to the target
debug. */
void debug_print_register (const char *func, int regno);
protected:
regcache (inferior *inf_for_target_calls, gdbarch *gdbarch,
const address_space *aspace);
private:
/* Helper function for transfer_regset. Copies across a single register. */
void transfer_regset_register (struct regcache *out_regcache, int regnum,
const gdb_byte *in_buf, gdb_byte *out_buf,
int slot_size, int offs) const;
/* Transfer a single or all registers belonging to a certain register
set to or from a buffer. This is the main worker function for
regcache_supply_regset and regcache_collect_regset. */
void transfer_regset (const struct regset *regset, int regbase,
struct regcache *out_regcache,
int regnum, const gdb_byte *in_buf,
gdb_byte *out_buf, size_t size) const;
/* Perform a partial register transfer using a read, modify, write
operation. */
enum register_status write_part (int regnum, int offset, int len,
const gdb_byte *in, bool is_raw);
/* The address space of this register cache (for registers where it
makes sense, like PC or SP). */
const address_space * const m_aspace;
/* The inferior to switch to, to make target calls.
This may not be the inferior of thread M_PTID. For instance, this
regcache might be for a fork child we are about to detach, so there will
never be an inferior for that thread / process. Nevertheless, we need to
be able to switch to the target stack that can handle register reads /
writes for this regcache, and that's what this inferior is for. */
inferior *m_inf_for_target_calls;
/* If this is a read-write cache, which thread's registers is
it connected to? */
ptid_t m_ptid;
friend struct regcache *
get_thread_arch_aspace_regcache (inferior *inf_for_target_calls, ptid_t ptid,
struct gdbarch *gdbarch,
struct address_space *aspace);
};
using regcache_up = std::unique_ptr<regcache>;
class readonly_detached_regcache : public readable_regcache
{
public:
readonly_detached_regcache (regcache &src);
/* Create a readonly regcache by getting contents from COOKED_READ. */
readonly_detached_regcache (gdbarch *gdbarch, register_read_ftype cooked_read)
: readable_regcache (gdbarch, true)
{
save (cooked_read);
}
DISABLE_COPY_AND_ASSIGN (readonly_detached_regcache);
void raw_update (int regnum) override
{}
};
extern void registers_changed (void);
extern void registers_changed_ptid (process_stratum_target *target,
ptid_t ptid);
/* Indicate that registers of THREAD may have changed, so invalidate
the cache. */
extern void registers_changed_thread (thread_info *thread);
/* An abstract base class for register dump. */
class register_dump
{
public:
void dump (ui_file *file);
virtual ~register_dump () = default;
protected:
register_dump (gdbarch *arch)
: m_gdbarch (arch)
{}
/* Dump the register REGNUM contents. If REGNUM is -1, print the
header. */
virtual void dump_reg (ui_file *file, int regnum) = 0;
gdbarch *m_gdbarch;
};
#endif /* REGCACHE_H */