mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 21:33:29 +08:00
59b59f08f6
This patch addresses PR gdb/27133. Before it, the following succession of commands would cause gdb to crash: set logging redirect on set logging debugredirect on set logging on The problem eventually comes down to a use after free. The function cli_interp_base::set_logging is called with a unique_ptr argument that holds a pointer to the redirection file. In the problematic use case, no-one ever took ownership of that pointer (as far as unique_ptr is concerned), so the call to its dtor at the end of the function causes the file object to be deleted. Any later use of the pointer to the redirection file is therefore an error. This patch ensures that the unique_ptr is released when required (so it does not assume ownership anymore). The internal logic of cli_interp_base::set_logging takes care of freeing the ui_file when it is not necessary anymore using the saved_output.file_to_delete field. gdb/ChangeLog: PR gdb/27133 * cli/cli-interp.c (cli_interp_base::set_logging): Ensure the unique_ptr is released when the wrapped pointer is kept for later use. gdb/testsuite/ChangeLog: PR gdb/27133 * gdb.base/ui-redirect.exp: Add test case that ensures that redirecting both logging and debug does not cause gdb to crash. |
||
|---|---|---|
| .. | ||
| cli-cmds.c | ||
| cli-cmds.h | ||
| cli-decode.c | ||
| cli-decode.h | ||
| cli-dump.c | ||
| cli-interp.c | ||
| cli-interp.h | ||
| cli-logging.c | ||
| cli-option.c | ||
| cli-option.h | ||
| cli-script.c | ||
| cli-script.h | ||
| cli-setshow.c | ||
| cli-setshow.h | ||
| cli-style.c | ||
| cli-style.h | ||
| cli-utils.c | ||
| cli-utils.h | ||