binutils-gdb/gdbserver/linux-riscv-low.cc
Andrew Burgess 1048062a3f gdbserver: pass osabi to GDB in more target descriptions
Problem Description
-------------------

On a Windows machine I built gdbserver, configured for the target
'x86_64-w64-mingw32', then on a GNU/Linux machine I built GDB with
support for all target (--enable-targets=all).

On the Windows machine I start gdbserver with a small test binary:

  $ gdbserver 192.168.129.25:54321 C:\some\directory\executable.exe

On the GNU/Linux machine I start GDB without the test binary, and
connect to gdbserver.

As I have not given GDB the test binary, my expectation is that GDB
would connect to gdbserver and then download the file over the remote
protocol, but instead I was presented with this message:

  (gdb) target remote 192.168.129.25:54321
  Remote debugging using 192.168.129.25:54321
  warning: C:\some\directory\executable.exe: No such file or directory.
  0x00007ffa3e1e1741 in ?? ()
  (gdb)

What I found is that if I told GDB where to find the binary, like
this:

  (gdb) file target:C:/some/directory/executable.exe
  A program is being debugged already.
  Are you sure you want to change the file? (y or n) y
  Reading C:/some/directory/executable.exe from remote target...
  warning: File transfers from remote targets can be slow. Use "set sysroot" to access files locally instead.
  Reading C:/some/directory/executable.exe from remote target...
  Reading symbols from target:C:/some/directory/executable.exe...
  (gdb)

then GDB would download the executable.

The Actual Issue
----------------

I tracked the problem down to exec_file_find (solib.c).  The remote
target was passing an absolute Windows filename (beginning with "C:/"
in this case), but in exec_file_find GDB was failing the
IS_TARGET_ABSOLUTE_PATH call, and so was treating the filename as
relative.

The IS_TARGET_ABSOLUTE_PATH call was failing because GDB thought that
the file system kind was "unix", and as the filename didn't start with
a "/" it assumed the filename was not absolute.

But I'm connecting to a Windows target and 'target-file-system-kind'
was set to "auto", so GDB should be figuring out that the target
file-system is "dos-based".

Looking in effective_target_file_system_kind (filesystem.c), we find
that the logic of "auto" is delegated to the current gdbarch.  However
in windows-tdep.c we see:

  set_gdbarch_has_dos_based_file_system (gdbarch, 1);

So if we are using a Windows gdbarch we should have "dos-based"
filesystems.  What this means is that after connecting to the remote
target GDB has selected the wrong gdbarch.

What's happening is that the target description sent back by the
remote target only includes the x86-64 registers.  There's no
information about which OS we're on.  As a consequence, GDB picks the
first x86-64 gdbarch which can handle the provided register set, which
happens to be a GNU/Linux gdbarch.

And indeed, there doesn't appear to be anywhere in gdbserver that sets
the osabi on the target descriptions. Some target descriptions do have
their osabi set when the description is created, e.g. in:

  gdb/arch/amd64.c	- Sets GNU/Linux osabi when appropriate.
  gdb/arch/i386.c	- Likewise.
  gdb/arch/tic6x.c	- Always set GNU/Linux osabi.

There are also some cases in gdb/features/*.c where the tdesc is set,
but these locations are only called from GDB, not from gdbserver.

This means that many target descriptions are created without an osabi,
gdbserver does nothing to fix this, and the description is returned to
GDB without an osabi included.  This leaves GDB having to guess what
the target osabi is, and in some cases, GDB can get this wrong.

Proposed Solution
-----------------

I propose to change init_target_desc so that it requires an gdb_osabi
to be passed in, this will then be used to set the target_desc osabi
field.

I believe that within gdbserver init_target_desc is called for every
target_desc, so this should mean that every target_desc has an
opportunity to set the osabi to something sane.

I did consider passing the osabi into the code which creates the
target_desc objects, but that would require updating far more code, as
each target has its own code for creating target descriptions.
The approach taken here requires minimal changes and forces every
user of init_target_desc to think about what the correct osabi is.

In some cases, e.g. amd64, where the osabi is already set when the
target_desc is created, the init_target_desc call will override the
current value, however, we should always be replacing it with the same
actual value.  i.e. if the target_desc is created with the osabi set
to GNU/Linux, then this should only happen when gdbserver is built for
GNU/Linux, in which case the init_target_desc should also be setting
the osabi to GNU/Linux.

The Tricky Bits
---------------

Some targets, like amd64, use a features based approach for creating
target_desc objects, there's a function in arch/amd64.c which creates
a target_desc, adds features too it, and returns the new target_desc.
This target_desc is then passed to an init_target_desc call within
gdbserver.  This is the easy case to handle.

Then there are other targets which instead have a fixed set of xml
files, each of which is converted into a .dat file, which is then used
to generate a .cc file, which is compiled into gdbserver.  The
generated .cc file creates the target_desc object and calls
init_target_desc on it.  In this case though the target description
that is sent to GDB isn't generated from the target_desc object, but
is instead the contents of the fixed xml file.  For this case the
osabi which we pass to init_target_desc should match the osabi that
exists in the fixed xml file.

Luckily, in the previous commit I copied the osabi information from
the fixed xml files into the .dat files.  So in this commit I have
extended regdat.sh to read the osabi from the .dat file and use it in
the generated init_target_desc call.

The problem with some of these .dat base targets is that their fixed
xml files don't currently contain any osabi information, and the file
names don't indicate that they are Linux only (despite them currently
only being used from gdbserver for Linux targets), so I don't
currently feel confident adding any osabi information to these files.
An example would be features/rs6000/powerpc-64.xml.  For now I've just
ignored these cases.  The init_target_desc will use GDB_OSABI_UNKNOWN
which is the default.  This means that for these targets nothing
changes from the current behaviour.  But many other targets do now
pass the osabi back.  Targets that do pass the osabi back are
improved with this commit.

Conclusion
----------

Now when I connect to the Windows remote the target description
returned includes the osabi name.  With this extra information GDB
selects the correct gdbarch object, which means that GDB understands
the target has a "dos-based" file-system.  With that correct GDB
understands that the filename it was given is absolute, and so fetches
the file from the remote as we'd like.

Reviewed-By: Kevin Buettner <kevinb@redhat.com>
2024-11-12 12:51:36 +00:00

325 lines
8.6 KiB
C++

/* GNU/Linux/RISC-V specific low level interface, for the remote server
for GDB.
Copyright (C) 2020-2024 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "linux-low.h"
#include "tdesc.h"
#include "elf/common.h"
#include "nat/riscv-linux-tdesc.h"
#include "opcode/riscv.h"
/* Work around glibc header breakage causing ELF_NFPREG not to be usable. */
#ifndef NFPREG
# define NFPREG 33
#endif
/* Linux target op definitions for the RISC-V architecture. */
class riscv_target : public linux_process_target
{
public:
const regs_info *get_regs_info () override;
int breakpoint_kind_from_pc (CORE_ADDR *pcptr) override;
const gdb_byte *sw_breakpoint_from_kind (int kind, int *size) override;
protected:
void low_arch_setup () override;
bool low_cannot_fetch_register (int regno) override;
bool low_cannot_store_register (int regno) override;
bool low_fetch_register (regcache *regcache, int regno) override;
bool low_supports_breakpoints () override;
CORE_ADDR low_get_pc (regcache *regcache) override;
void low_set_pc (regcache *regcache, CORE_ADDR newpc) override;
bool low_breakpoint_at (CORE_ADDR pc) override;
};
/* The singleton target ops object. */
static riscv_target the_riscv_target;
bool
riscv_target::low_cannot_fetch_register (int regno)
{
gdb_assert_not_reached ("linux target op low_cannot_fetch_register "
"is not implemented by the target");
}
bool
riscv_target::low_cannot_store_register (int regno)
{
gdb_assert_not_reached ("linux target op low_cannot_store_register "
"is not implemented by the target");
}
/* Implementation of linux target ops method "low_arch_setup". */
void
riscv_target::low_arch_setup ()
{
static const char *expedite_regs[] = { "sp", "pc", NULL };
const riscv_gdbarch_features features
= riscv_linux_read_features (current_thread->id.lwp ());
target_desc_up tdesc = riscv_create_target_description (features);
if (tdesc->expedite_regs.empty ())
{
init_target_desc (tdesc.get (), expedite_regs, GDB_OSABI_LINUX);
gdb_assert (!tdesc->expedite_regs.empty ());
}
current_process ()->tdesc = tdesc.release ();
}
/* Collect GPRs from REGCACHE into BUF. */
static void
riscv_fill_gregset (struct regcache *regcache, void *buf)
{
const struct target_desc *tdesc = regcache->tdesc;
elf_gregset_t *regset = (elf_gregset_t *) buf;
int regno = find_regno (tdesc, "zero");
int i;
collect_register_by_name (regcache, "pc", *regset);
for (i = 1; i < ARRAY_SIZE (*regset); i++)
collect_register (regcache, regno + i, *regset + i);
}
/* Supply GPRs from BUF into REGCACHE. */
static void
riscv_store_gregset (struct regcache *regcache, const void *buf)
{
const elf_gregset_t *regset = (const elf_gregset_t *) buf;
const struct target_desc *tdesc = regcache->tdesc;
int regno = find_regno (tdesc, "zero");
int i;
supply_register_by_name (regcache, "pc", *regset);
supply_register_zeroed (regcache, regno);
for (i = 1; i < ARRAY_SIZE (*regset); i++)
supply_register (regcache, regno + i, *regset + i);
}
/* Collect FPRs from REGCACHE into BUF. */
static void
riscv_fill_fpregset (struct regcache *regcache, void *buf)
{
const struct target_desc *tdesc = regcache->tdesc;
int regno = find_regno (tdesc, "ft0");
int flen = register_size (regcache->tdesc, regno);
gdb_byte *regbuf = (gdb_byte *) buf;
int i;
for (i = 0; i < ELF_NFPREG - 1; i++, regbuf += flen)
collect_register (regcache, regno + i, regbuf);
collect_register_by_name (regcache, "fcsr", regbuf);
}
/* Supply FPRs from BUF into REGCACHE. */
static void
riscv_store_fpregset (struct regcache *regcache, const void *buf)
{
const struct target_desc *tdesc = regcache->tdesc;
int regno = find_regno (tdesc, "ft0");
int flen = register_size (regcache->tdesc, regno);
const gdb_byte *regbuf = (const gdb_byte *) buf;
int i;
for (i = 0; i < ELF_NFPREG - 1; i++, regbuf += flen)
supply_register (regcache, regno + i, regbuf);
supply_register_by_name (regcache, "fcsr", regbuf);
}
/* RISC-V/Linux regsets. FPRs are optional and come in different sizes,
so define multiple regsets for them marking them all as OPTIONAL_REGS
rather than FP_REGS, so that "regsets_fetch_inferior_registers" picks
the right one according to size. */
static struct regset_info riscv_regsets[] = {
{ PTRACE_GETREGSET, PTRACE_SETREGSET, NT_PRSTATUS,
sizeof (elf_gregset_t), GENERAL_REGS,
riscv_fill_gregset, riscv_store_gregset },
{ PTRACE_GETREGSET, PTRACE_SETREGSET, NT_FPREGSET,
sizeof (struct __riscv_mc_q_ext_state), OPTIONAL_REGS,
riscv_fill_fpregset, riscv_store_fpregset },
{ PTRACE_GETREGSET, PTRACE_SETREGSET, NT_FPREGSET,
sizeof (struct __riscv_mc_d_ext_state), OPTIONAL_REGS,
riscv_fill_fpregset, riscv_store_fpregset },
{ PTRACE_GETREGSET, PTRACE_SETREGSET, NT_FPREGSET,
sizeof (struct __riscv_mc_f_ext_state), OPTIONAL_REGS,
riscv_fill_fpregset, riscv_store_fpregset },
NULL_REGSET
};
/* RISC-V/Linux regset information. */
static struct regsets_info riscv_regsets_info =
{
riscv_regsets, /* regsets */
0, /* num_regsets */
NULL, /* disabled_regsets */
};
/* Definition of linux_target_ops data member "regs_info". */
static struct regs_info riscv_regs =
{
NULL, /* regset_bitmap */
NULL, /* usrregs */
&riscv_regsets_info,
};
/* Implementation of linux target ops method "get_regs_info". */
const regs_info *
riscv_target::get_regs_info ()
{
return &riscv_regs;
}
/* Implementation of linux target ops method "low_fetch_register". */
bool
riscv_target::low_fetch_register (regcache *regcache, int regno)
{
const struct target_desc *tdesc = regcache->tdesc;
if (regno != find_regno (tdesc, "zero"))
return false;
supply_register_zeroed (regcache, regno);
return true;
}
bool
riscv_target::low_supports_breakpoints ()
{
return true;
}
/* Implementation of linux target ops method "low_get_pc". */
CORE_ADDR
riscv_target::low_get_pc (regcache *regcache)
{
elf_gregset_t regset;
if (sizeof (regset[0]) == 8)
return linux_get_pc_64bit (regcache);
else
return linux_get_pc_32bit (regcache);
}
/* Implementation of linux target ops method "low_set_pc". */
void
riscv_target::low_set_pc (regcache *regcache, CORE_ADDR newpc)
{
elf_gregset_t regset;
if (sizeof (regset[0]) == 8)
linux_set_pc_64bit (regcache, newpc);
else
linux_set_pc_32bit (regcache, newpc);
}
/* Correct in either endianness. */
static const uint16_t riscv_ibreakpoint[] = { 0x0073, 0x0010 };
static const uint16_t riscv_cbreakpoint = 0x9002;
/* Implementation of target ops method "breakpoint_kind_from_pc". */
int
riscv_target::breakpoint_kind_from_pc (CORE_ADDR *pcptr)
{
union
{
gdb_byte bytes[2];
uint16_t insn;
}
buf;
if (target_read_memory (*pcptr, buf.bytes, sizeof (buf.insn)) == 0
&& riscv_insn_length (buf.insn == sizeof (riscv_ibreakpoint)))
return sizeof (riscv_ibreakpoint);
else
return sizeof (riscv_cbreakpoint);
}
/* Implementation of target ops method "sw_breakpoint_from_kind". */
const gdb_byte *
riscv_target::sw_breakpoint_from_kind (int kind, int *size)
{
*size = kind;
switch (kind)
{
case sizeof (riscv_ibreakpoint):
return (const gdb_byte *) &riscv_ibreakpoint;
default:
return (const gdb_byte *) &riscv_cbreakpoint;
}
}
/* Implementation of linux target ops method "low_breakpoint_at". */
bool
riscv_target::low_breakpoint_at (CORE_ADDR pc)
{
union
{
gdb_byte bytes[2];
uint16_t insn;
}
buf;
if (target_read_memory (pc, buf.bytes, sizeof (buf.insn)) == 0
&& (buf.insn == riscv_cbreakpoint
|| (buf.insn == riscv_ibreakpoint[0]
&& target_read_memory (pc + sizeof (buf.insn), buf.bytes,
sizeof (buf.insn)) == 0
&& buf.insn == riscv_ibreakpoint[1])))
return true;
else
return false;
}
/* The linux target ops object. */
linux_process_target *the_linux_target = &the_riscv_target;
/* Initialize the RISC-V/Linux target. */
void
initialize_low_arch ()
{
initialize_regsets_info (&riscv_regsets_info);
}