mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-23 01:53:38 +08:00
8480a37e14
We currently pass frames to function by value, as `frame_info_ptr`.
This is somewhat expensive:
- the size of `frame_info_ptr` is 64 bytes, which is a bit big to pass
by value
- the constructors and destructor link/unlink the object in the global
`frame_info_ptr::frame_list` list. This is an `intrusive_list`, so
it's not so bad: it's just assigning a few points, there's no memory
allocation as if it was `std::list`, but still it's useless to do
that over and over.
As suggested by Tom Tromey, change many function signatures to accept
`const frame_info_ptr &` instead of `frame_info_ptr`.
Some functions reassign their `frame_info_ptr` parameter, like:
void
the_func (frame_info_ptr frame)
{
for (; frame != nullptr; frame = get_prev_frame (frame))
{
...
}
}
I wondered what to do about them, do I leave them as-is or change them
(and need to introduce a separate local variable that can be
re-assigned). I opted for the later for consistency. It might not be
clear why some functions take `const frame_info_ptr &` while others take
`frame_info_ptr`. Also, if a function took a `frame_info_ptr` because
it did re-assign its parameter, I doubt that we would think to change it
to `const frame_info_ptr &` should the implementation change such that
it doesn't need to take `frame_info_ptr` anymore. It seems better to
have a simple rule and apply it everywhere.
Change-Id: I59d10addef687d157f82ccf4d54f5dde9a963fd0
Approved-By: Andrew Burgess <aburgess@redhat.com>
91 lines
3.0 KiB
C
91 lines
3.0 KiB
C
/* Target-dependent header for the Nios II architecture, for GDB.
|
|
Copyright (C) 2012-2024 Free Software Foundation, Inc.
|
|
Contributed by Mentor Graphics, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef NIOS2_TDEP_H
|
|
#define NIOS2_TDEP_H
|
|
|
|
#include "gdbarch.h"
|
|
|
|
/* Nios II ISA specific encodings and macros. */
|
|
#include "opcode/nios2.h"
|
|
|
|
/* Registers. */
|
|
#define NIOS2_Z_REGNUM 0 /* Zero */
|
|
#define NIOS2_R2_REGNUM 2 /* used for return value */
|
|
#define NIOS2_R3_REGNUM 3 /* used for return value */
|
|
/* Used for hidden zero argument to store ptr to struct return value. */
|
|
#define NIOS2_R4_REGNUM 4
|
|
#define NIOS2_R7_REGNUM 7
|
|
#define NIOS2_GP_REGNUM 26 /* Global Pointer */
|
|
#define NIOS2_SP_REGNUM 27 /* Stack Pointer */
|
|
#define NIOS2_FP_REGNUM 28 /* Frame Pointer */
|
|
#define NIOS2_EA_REGNUM 29 /* Exception address */
|
|
#define NIOS2_BA_REGNUM 30 /* Breakpoint return address */
|
|
#define NIOS2_RA_REGNUM 31 /* Return address */
|
|
#define NIOS2_PC_REGNUM 32
|
|
|
|
/* Control registers. */
|
|
#define NIOS2_STATUS_REGNUM 33
|
|
#define NIOS2_ESTATUS_REGNUM 34
|
|
#define NIOS2_BSTATUS_REGNUM 35
|
|
#define NIOS2_IENABLE_REGNUM 36
|
|
#define NIOS2_IPENDING_REGNUM 37
|
|
#define NIOS2_CPUID_REGNUM 38
|
|
#define NIOS2_EXCEPTION_REGNUM 40
|
|
#define NIOS2_PTEADDR_REGNUM 41
|
|
#define NIOS2_TLBACC_REGNUM 42
|
|
#define NIOS2_TLBMISC_REGNUM 43
|
|
#define NIOS2_ECCINJ_REGNUM 44
|
|
#define NIOS2_BADADDR_REGNUM 45
|
|
#define NIOS2_CONFIG_REGNUM 46
|
|
#define NIOS2_MPUBASE_REGNUM 47
|
|
#define NIOS2_MPUACC_REGNUM 48
|
|
|
|
/* R4-R7 are used for argument passing. */
|
|
#define NIOS2_FIRST_ARGREG NIOS2_R4_REGNUM
|
|
#define NIOS2_LAST_ARGREG NIOS2_R7_REGNUM
|
|
|
|
/* Number of all registers. */
|
|
#define NIOS2_NUM_REGS 49
|
|
|
|
/* Size of an instruction, in bytes. */
|
|
#define NIOS2_OPCODE_SIZE 4
|
|
#define NIOS2_CDX_OPCODE_SIZE 2
|
|
|
|
/* Target-dependent structure in gdbarch. */
|
|
struct nios2_gdbarch_tdep : gdbarch_tdep_base
|
|
{
|
|
/* Assumes FRAME is stopped at a syscall (trap) instruction; returns
|
|
the expected next PC. */
|
|
CORE_ADDR (*syscall_next_pc) (const frame_info_ptr &frame,
|
|
const struct nios2_opcode *op) = nullptr;
|
|
|
|
/* Returns true if PC points to a kernel helper function. */
|
|
bool (*is_kernel_helper) (CORE_ADDR pc) = nullptr;
|
|
|
|
/* Offset to PC value in jump buffer.
|
|
If this is negative, longjmp support will be disabled. */
|
|
int jb_pc = 0;
|
|
};
|
|
|
|
extern const struct target_desc *tdesc_nios2_linux;
|
|
extern const struct target_desc *tdesc_nios2;
|
|
|
|
#endif /* NIOS2_TDEP_H */
|