binutils-gdb/gdb/extract-store-integer.h
Tom Tromey 6eb63917ce Handle "info symbol" in Rust language mode
When I changed the Rust parser to handle 128-bit ints, this
inadvertently broke some other gdb commands.  For example, "info
symbol 0xffffffffffffffff" now fails, because the resulting value is
128 bits, but this is rejected by extract_integer.

This patch fixes the problem by changing extract_integer to allow
over-long integers as long as the high bytes are either 0, or (for
signed types) 0xff.

Regression tested on x86-64 Fedora 38.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31565
Approved-By: Andrew Burgess <aburgess@redhat.com>
2024-06-20 10:45:05 -06:00

111 lines
3.3 KiB
C++

/* Copyright (C) 1986-2024 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#ifndef GDB_EXTRACT_STORE_INTEGER_H
#define GDB_EXTRACT_STORE_INTEGER_H
#include <type_traits>
template<typename T, typename = std::is_integral<T>>
T extract_integer (gdb::array_view<const gdb_byte>, enum bfd_endian byte_order);
static inline LONGEST
extract_signed_integer (gdb::array_view<const gdb_byte> buf,
enum bfd_endian byte_order)
{
return extract_integer<LONGEST> (buf, byte_order);
}
static inline LONGEST
extract_signed_integer (const gdb_byte *addr, int len,
enum bfd_endian byte_order)
{
return extract_signed_integer (gdb::array_view<const gdb_byte> (addr, len),
byte_order);
}
static inline ULONGEST
extract_unsigned_integer (gdb::array_view<const gdb_byte> buf,
enum bfd_endian byte_order)
{
return extract_integer<ULONGEST> (buf, byte_order);
}
static inline ULONGEST
extract_unsigned_integer (const gdb_byte *addr, int len,
enum bfd_endian byte_order)
{
return extract_unsigned_integer (gdb::array_view<const gdb_byte> (addr, len),
byte_order);
}
extern CORE_ADDR extract_typed_address (const gdb_byte *buf,
struct type *type);
/* All 'store' functions accept a host-format integer and store a
target-format integer at ADDR which is LEN bytes long. */
template<typename T, typename = RequireLongest<T>>
extern void store_integer (gdb::array_view<gdb_byte> dst,
bfd_endian byte_order, T val);
template<typename T>
static inline void
store_integer (gdb_byte *addr, int len, bfd_endian byte_order, T val)
{
return store_integer (gdb::make_array_view (addr, len), byte_order, val);
}
static inline void
store_signed_integer (gdb::array_view<gdb_byte> dst, bfd_endian byte_order,
LONGEST val)
{
return store_integer (dst, byte_order, val);
}
static inline void
store_signed_integer (gdb_byte *addr, int len, bfd_endian byte_order,
LONGEST val)
{
return store_signed_integer (gdb::make_array_view (addr, len), byte_order,
val);
}
static inline void
store_unsigned_integer (gdb::array_view<gdb_byte> dst, bfd_endian byte_order,
ULONGEST val)
{
return store_integer (dst, byte_order, val);
}
static inline void
store_unsigned_integer (gdb_byte *addr, int len, bfd_endian byte_order,
ULONGEST val)
{
return store_unsigned_integer (gdb::make_array_view (addr, len), byte_order,
val);
}
extern void store_typed_address (gdb_byte *buf, struct type *type,
CORE_ADDR addr);
extern void copy_integer_to_size (gdb_byte *dest, int dest_size,
const gdb_byte *source, int source_size,
bool is_signed, enum bfd_endian byte_order);
#endif /* GDB_EXTRACT_STORE_INTEGER_H */