mirrors/binutils-gdb
1
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-24 02:24:46 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

gdb/testsuite/gdb.rocm: Check value returned by hipDeviceSynchronize

Browse Source 
Functions of the hip runtime returning a hipError_t can be marked
nodiscard depending on the configuration[1] (when compiled with C++17).

This patch makes sure that we always check the value returned by
hipDeviceSynchronize and friends, and print an error message when
appropriate.  This avoid a wall of warnings when running the testsuite
if the compiler defaults to using C++17.

It is always a good practice to check the return values anyway.

[1] https://github.com/ROCm-Developer-Tools/HIP/blob/docs/5.7.1/include/hip/hip_runtime_api.h#L203-L218

Change-Id: I2a819a8ac45f4bcf814efe9a2ff12c6a7ad22f97
Approved-By: Simon Marchi <simon.marchi@efficios.com>
This commit is contained in:
Lancelot Six 2023-10-17 15:45:45 +00:00
parent 0f79aa900f
commit fded0fb898
6 changed files with 52 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
gdb/testsuite/gdb.rocm/fork-exec-gpu-to-non-gpu-execer.cpp
View File

@ -18,6 +18,17 @@
#include <hip/hip_runtime.h>
#include <unistd.h>
#define CHECK(cmd) \
{ \
hipError_t error = cmd; \
if (error != hipSuccess) \
{ \
fprintf (stderr, "error: '%s'(%d) at %s:%d\n", \
hipGetErrorString (error), error, __FILE__, __LINE__); \
exit (EXIT_FAILURE); \
} \
}
__global__ static void
kernel1 ()
{}
@ -50,6 +61,6 @@ main ()
kernel2<<<1, 1>>> ();
hipDeviceSynchronize ();
CHECK (hipDeviceSynchronize ());
return 0;
}

14
gdb/testsuite/gdb.rocm/fork-exec-non-gpu-to-gpu-execee.cpp
View File

@ -17,6 +17,18 @@
#include <hip/hip_runtime.h>
#define CHECK(cmd) \
{ \
hipError_t error = cmd; \
if (error != hipSuccess) \
{ \
fprintf (stderr, "error: '%s'(%d) at %s:%d\n", \
hipGetErrorString (error), error, __FILE__, __LINE__); \
exit (EXIT_FAILURE); \
} \
}
__device__ static void
break_here_execee ()
{}
@ -31,6 +43,6 @@ int
main ()
{
kernel<<<1, 1>>> ();
hipDeviceSynchronize ();
CHECK (hipDeviceSynchronize ());
return 0;
}

2
gdb/testsuite/gdb.rocm/multi-inferior-gpu.cpp
View File

@ -95,7 +95,7 @@ child (int argc, char **argv)
CHECK (hipSetDevice (dev_number));
kern<<<1, 1>>> ();
hipDeviceSynchronize ();
CHECK (hipDeviceSynchronize ());
return 0;
}

13
gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.cpp
View File

@ -17,6 +17,17 @@
#include <hip/hip_runtime.h>
#define CHECK(cmd) \
{ \
hipError_t error = cmd; \
if (error != hipSuccess) \
{ \
fprintf (stderr, "error: '%s'(%d) at %s:%d\n", \
hipGetErrorString (error), error, __FILE__, __LINE__); \
exit (EXIT_FAILURE); \
} \
}
__global__ void
kernel ()
{
@ -28,6 +39,6 @@ int
main (int argc, char* argv[])
{
kernel<<<1, 1>>> ();
hipDeviceSynchronize ();
CHECK (hipDeviceSynchronize ());
return 0;
}

13
gdb/testsuite/gdb.rocm/precise-memory.cpp
View File

@ -17,6 +17,17 @@
#include <hip/hip_runtime.h>
#define CHECK(cmd) \
{ \
hipError_t error = cmd; \
if (error != hipSuccess) \
{ \
fprintf (stderr, "error: '%s'(%d) at %s:%d\n", \
hipGetErrorString (error), error, __FILE__, __LINE__); \
exit (EXIT_FAILURE); \
} \
}
__global__ void
kernel ()
{
@ -27,6 +38,6 @@ int
main (int argc, char* argv[])
{
kernel<<<1, 1>>> ();
hipDeviceSynchronize ();
CHECK (hipDeviceSynchronize ());
return 0;
}

3
gdb/testsuite/lib/rocm.exp
View File

@ -93,7 +93,8 @@ gdb_caching_proc allow_hipcc_tests {} {
main ()
{
kern<<<1, 1>>> ();
hipDeviceSynchronize ();
if (hipDeviceSynchronize () != hipSuccess)
return -1;
return 0;
}
} executable $flags]} {