mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-01-24 17:04:02 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

gdb/testsuite: link some dwarf2 tests with nopie

Browse Source 
I noticed some gdb.dwarf2 tests not running on my machine because of
this:

    Running /home/simark/src/binutils-gdb/gdb/testsuite/gdb.dwarf2/dw2-single-line-discriminators.exp ...
    gdb compile failed, /usr/bin/ld: /home/simark/build/binutils-gdb/gdb/testsuite/outputs/gdb.dwarf2/dw2-single-line-discriminators/dw2-single-line-discriminators0.o: relocation R_X86_64_32S against
     symbol `x' can not be used when making a PIE object; recompile with -fPIE
    collect2: error: ld returned 1 exit status

We get this when the target toolchain produces position-independent
executables by default.  These tests are built from some assembly which
produces some relocations incompatible with position-independent
executables.

Add `nopie` to the compilation flags of these tests to force the
toolchain to produce non-position-independent executables.  With this,
the changed tests run successfully on my machine.

gdb/ChangeLog:

	* gdb.dwarf2/clztest.exp, gdb.dwarf2/dw2-common-block.exp,
	gdb.dwarf2/dw2-dup-frame.exp, gdb.dwarf2/dw2-reg-undefined.exp,
	gdb.dwarf2/dw2-single-line-discriminators.exp,
	dw2-undefined-ret-addr.exp: Pass nopie to compilation options.

Change-Id: Ie06c946f8e56a6030be247d1c57f416fa8b67e4c
This commit is contained in:
Simon Marchi 2020-08-05 17:38:28 -04:00 committed by Simon Marchi
parent 57d02173a2
commit ea946b861c
7 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2020-08-05 Simon Marchi <simon.marchi@polymtl.ca>
* gdb.dwarf2/clztest.exp, gdb.dwarf2/dw2-common-block.exp,
gdb.dwarf2/dw2-dup-frame.exp, gdb.dwarf2/dw2-reg-undefined.exp,
gdb.dwarf2/dw2-single-line-discriminators.exp,
dw2-undefined-ret-addr.exp: Pass nopie to compilation options.
2020-08-05 Tom Tromey <tromey@adacore.com>
PR rust/26197:

3
gdb/testsuite/gdb.dwarf2/clztest.exp
View File

@ -28,7 +28,8 @@ if {![istarget x86_64-*] || ![is_lp64_target]} {
return 0
}
if { [prepare_for_testing "failed to prepare" "${test}" ${test}.S {nodebug additional_flags=-nostdlib}] } {
if { [prepare_for_testing "failed to prepare" "${test}" ${test}.S \
{nodebug nopie additional_flags=-nostdlib}] } {
return -1
}

2
gdb/testsuite/gdb.dwarf2/dw2-common-block.exp
View File

@ -33,7 +33,7 @@ if {[skip_fortran_tests]} {
standard_testfile .S
if { [prepare_for_testing "failed to prepare" "${testfile}" $srcfile \
{nodebug f90}] } {
{nodebug nopie f90}] } {
return -1
}

2
gdb/testsuite/gdb.dwarf2/dw2-dup-frame.exp
View File

@ -26,7 +26,7 @@ if {![istarget "x86_64-*-*"] || ![is_lp64_target]} {
standard_testfile .S
if { [prepare_for_testing "failed to prepare" $testfile $srcfile {nodebug}] } {
if { [prepare_for_testing "failed to prepare" $testfile $srcfile {nodebug nopie}] } {
return -1
}

2
gdb/testsuite/gdb.dwarf2/dw2-reg-undefined.exp
View File

@ -26,7 +26,7 @@ if {![istarget "x86_64-*-*"] || ![is_lp64_target]} {
standard_testfile .S
if { [prepare_for_testing "failed to prepare" $testfile $srcfile {nodebug}] } {
if { [prepare_for_testing "failed to prepare" $testfile $srcfile {nodebug nopie}] } {
return -1
}

2
gdb/testsuite/gdb.dwarf2/dw2-single-line-discriminators.exp
View File

@ -31,7 +31,7 @@ if {![istarget x86_64-*] || ![is_lp64_target]} {
standard_testfile .S
set csrcfile ${testfile}.c
if { [prepare_for_testing "failed to prepare" "${testfile}" $srcfile {nodebug}] } {
if { [prepare_for_testing "failed to prepare" "${testfile}" $srcfile {nodebug nopie}] } {
return -1
}

2
gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp
View File

@ -26,7 +26,7 @@ if {![istarget x86_64-*] || ![is_lp64_target]} {
return 0
}
if {[prepare_for_testing "failed to prepare" "$testfile" $srcfile {nodebug}]} {
if {[prepare_for_testing "failed to prepare" "$testfile" $srcfile {nodebug nopie}]} {
return -1
}