mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-28 20:43:45 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add space between program name and file for objcopy/strip/objdump messages

Browse Source 
The GNU coding standard does indicate there should be no space in
messages like these, but we tend to put a space in all other
messages.  This patch cures the inconsistency in:

$ binutils/strip-new -F elf32-little -N .text -o pr25200 pr25200.bin
binutils/strip-new: pr25200: R_X86_64_PLT32 unsupported
binutils/strip-new:pr25200: sorry, cannot handle this file

	* bucomm.c (bfd_nonfatal_message): Add a space between program
	name and file.
This commit is contained in:
Alan Modra 2019-11-19 08:06:24 +10:30
parent 0b8dbf3f1c
commit df56ecde8a
2 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
binutils/ChangeLog
View File

@ -1,3 +1,8 @@
2019-11-19 Alan Modra <amodra@gmail.com>
* bucomm.c (bfd_nonfatal_message): Add a space between program
name and file.
2019-11-18 Alan Modra <amodra@gmail.com>
PR 25198

12
binutils/bucomm.c
View File

@ -64,10 +64,10 @@ bfd_nonfatal (const char *string)
bfd error message is printed. In summary, error messages are of
one of the following forms:
PROGRAM:file: bfd-error-message
PROGRAM:file[section]: bfd-error-message
PROGRAM:file: printf-message: bfd-error-message
PROGRAM:file[section]: printf-message: bfd-error-message. */
PROGRAM: file: bfd-error-message
PROGRAM: file[section]: bfd-error-message
PROGRAM: file: printf-message: bfd-error-message
PROGRAM: file[section]: printf-message: bfd-error-message. */
void
bfd_nonfatal_message (const char *filename,
@ -97,9 +97,9 @@ bfd_nonfatal_message (const char *filename,
section_name = bfd_section_name (section);
}
if (section_name)
fprintf (stderr, ":%s[%s]", filename, section_name);
fprintf (stderr, ": %s[%s]", filename, section_name);
else
fprintf (stderr, ":%s", filename);
fprintf (stderr, ": %s", filename);
if (format)
{