mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-27 12:03:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

add -Wold-style-definition

Browse Source 
This adds -Wold-style-definition to gdb's list of warnings.  This
found a couple of spots where "()" was used where "(void)" is more
correct.

Tested by rebuilding on x86-64 Fedora 18.

	* configure.ac (build_warnings): Add -Wold-style-definition.
	* configure: Rebuild.
	* machoread.c (_initialize_machoread): Use "(void)".
	* macrocmd.c (macro_inform_no_debuginfo): Fix formatting;
	use "(void)".
This commit is contained in:
Tom Tromey 2013-07-01 19:52:32 +00:00
parent 44d100c3b9
commit dd9aa0484e
5 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/ChangeLog
View File

@ -1,3 +1,11 @@
2013-07-01 Tom Tromey <tromey@redhat.com>
* configure.ac (build_warnings): Add -Wold-style-definition.
* configure: Rebuild.
* machoread.c (_initialize_machoread): Use "(void)".
* macrocmd.c (macro_inform_no_debuginfo): Fix formatting;
use "(void)".
2013-07-01 Tom Tromey <tromey@redhat.com>
* configure.ac (build_warnings): Add -Wold-style-declaration.

2
gdb/configure vendored
View File

@ -12471,7 +12471,7 @@ build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \
-Wno-unused -Wunused-value -Wunused-function \
-Wno-switch -Wno-char-subscripts -Wmissing-prototypes \
-Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type \
-Wold-style-declaration"
-Wold-style-declaration -Wold-style-definition"
# Enable -Wno-format by default when using gcc on mingw since many
# GCC versions complain about %I64.

2
gdb/configure.ac
View File

@ -1941,7 +1941,7 @@ build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \
-Wno-unused -Wunused-value -Wunused-function \
-Wno-switch -Wno-char-subscripts -Wmissing-prototypes \
-Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type \
-Wold-style-declaration"
-Wold-style-declaration -Wold-style-definition"
# Enable -Wno-format by default when using gcc on mingw since many
# GCC versions complain about %I64.

2
gdb/machoread.c
View File

@ -1037,7 +1037,7 @@ static const struct sym_fns macho_sym_fns = {
extern initialize_file_ftype _initialize_machoread;
void
_initialize_machoread ()
_initialize_machoread (void)
{
add_symtab_fns (&macho_sym_fns);

3
gdb/macrocmd.c
View File

@ -47,7 +47,8 @@ macro_command (char *arg, int from_tty)
/* Prints an informational message regarding the lack of macro information. */
static void macro_inform_no_debuginfo()
static void
macro_inform_no_debuginfo (void)
{
puts_filtered ("GDB has no preprocessor macro information for that code.\n");
}