mirrors/binutils-gdb
1
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-24 18:44:20 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

* symtab.c (decode_line_1): Add comment about use of

Browse Source 
return_to_top_level directly instead of error.  Add comment saying
	that the '' should not be needed--that the completer should be fixed.
This commit is contained in:
Jim Kingdon 1993-11-19 21:16:16 +00:00
parent 4961ce5b9c
commit dbdf5a2a04
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
Fri Nov 19 15:08:47 1993 Jim Kingdon (kingdon@lioth.cygnus.com)
* symtab.c (decode_line_1): Add comment about use of
return_to_top_level directly instead of error. Add comment saying
that the '' should not be needed--that the completer should be fixed.
Fri Nov 19 11:00:33 1993 Kung Hsu (kung@cirdan.cygnus.com)
* symtab.c(decode_line_1): fix the inconsistency of setting

7
gdb/symtab.c
View File

@ -1644,6 +1644,11 @@ build_canonical_line_spec (sal, symname, canonical)
if no file is validly specified. Callers must check that.
Also, the line number returned may be invalid. */
/* We allow single quotes in various places. This is a hideous
kludge, which exists because the completer can't yet deal with the
lack of single quotes. FIXME: write a linespec_completer which we
can use as appropriate instead of make_symbol_completion_list. */
struct symtabs_and_lines
decode_line_1 (argptr, funfirstline, default_symtab, default_line, canonical)
char **argptr;
@ -1742,6 +1747,8 @@ decode_line_1 (argptr, funfirstline, default_symtab, default_line, canonical)
while(!++p && *p != '>');
if (!p)
{
/* FIXME: Why warning() and then return_to_top_level?
What's wrong with error()? */
warning("non-matching '<' and '>' in command");
return_to_top_level (RETURN_ERROR);
}