mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-27 03:54:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use bool for agent_expr::tracing

Browse Source 
This changese agent_expr::tracing to have type bool, allowing inline
initialization and cleaning up the code a little.

Reviewed-by: John Baldwin <jhb@FreeBSD.org>
This commit is contained in:
Tom Tromey 2023-06-17 12:56:54 -06:00
parent b0b5ba6b7f
commit da25448d52
2 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gdb/ax-gdb.c
View File

@ -2335,7 +2335,7 @@ gen_trace_for_var (CORE_ADDR scope, struct gdbarch *gdbarch,
agent_expr_up ax (new agent_expr (gdbarch, scope));
struct axs_value value;
ax->tracing = 1;
ax->tracing = true;
ax->trace_string = trace_string;
gen_var_ref (ax.get (), &value, var);
@ -2368,7 +2368,7 @@ gen_trace_for_expr (CORE_ADDR scope, struct expression *expr,
agent_expr_up ax (new agent_expr (expr->gdbarch, scope));
struct axs_value value;
ax->tracing = 1;
ax->tracing = true;
ax->trace_string = trace_string;
value.optimized_out = 0;
expr->op->generate_ax (expr, ax.get (), &value);
@ -2395,7 +2395,7 @@ gen_eval_for_expr (CORE_ADDR scope, struct expression *expr)
agent_expr_up ax (new agent_expr (expr->gdbarch, scope));
struct axs_value value;
ax->tracing = 0;
ax->tracing = false;
value.optimized_out = 0;
expr->op->generate_ax (expr, ax.get (), &value);
@ -2414,7 +2414,7 @@ gen_trace_for_return_address (CORE_ADDR scope, struct gdbarch *gdbarch,
agent_expr_up ax (new agent_expr (gdbarch, scope));
struct axs_value value;
ax->tracing = 1;
ax->tracing = true;
ax->trace_string = trace_string;
gdbarch_gen_return_address (gdbarch, ax.get (), &value, scope);
@ -2443,7 +2443,7 @@ gen_printf (CORE_ADDR scope, struct gdbarch *gdbarch,
int tem;
/* We're computing values, not doing side effects. */
ax->tracing = 0;
ax->tracing = false;
/* Evaluate and push the args on the stack in reverse order,
for simplicity of collecting them on the target side. */

7
gdb/ax.h
View File

@ -83,8 +83,7 @@ struct agent_expr
/* Construct an empty agent expression. */
agent_expr (struct gdbarch *gdbarch, CORE_ADDR scope)
: gdbarch (gdbarch),
scope (scope),
tracing (0)
scope (scope)
{ }
/* The bytes of the expression. */
@ -132,10 +131,10 @@ struct agent_expr
be available when the user later tries to evaluate the expression
in GDB.
Setting the flag 'tracing' to non-zero enables the code that
Setting the flag 'tracing' to true enables the code that
emits the trace bytecodes at the appropriate points. */
unsigned int tracing : 1;
bool tracing = false;
/* This indicates that pointers to chars should get an added
tracenz bytecode to record nonzero bytes, up to a length that