From d3eaaf662248d48238dfae07cefb4e9008b852e2 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Mon, 23 Sep 2013 16:48:43 +0000 Subject: [PATCH] In regcache use print_hex_chars. https://sourceware.org/ml/gdb-patches/2013-09/msg00815.html gdb/ChangeLog * regcache.c: Add include of valprint.h. (dump_endian_bytes): Delete. (regcache_dump): Use print_hex_chars not dump_endian_bytes. --- gdb/ChangeLog | 6 ++++++ gdb/regcache.c | 38 +++++++------------------------------- 2 files changed, 13 insertions(+), 31 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b016136ad2d..c0ec10fbc1c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2013-09-23 Andrew Burgess + + * regcache.c: Add include of valprint.h. + (dump_endian_bytes): Delete. + (regcache_dump): Use print_hex_chars not dump_endian_bytes. + 2013-09-23 Andrew Burgess * sh64-tdep.c (sh64_do_fp_register): Use print_hex_chars. diff --git a/gdb/regcache.c b/gdb/regcache.c index 57d29e4b643..7ec75c80944 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -30,6 +30,7 @@ #include "observer.h" #include "exceptions.h" #include "remote.h" +#include "valprint.h" /* * DATA STRUCTURE @@ -1090,27 +1091,6 @@ reg_flush_command (char *command, int from_tty) printf_filtered (_("Register cache flushed.\n")); } -static void -dump_endian_bytes (struct ui_file *file, enum bfd_endian endian, - const gdb_byte *buf, long len) -{ - int i; - - switch (endian) - { - case BFD_ENDIAN_BIG: - for (i = 0; i < len; i++) - fprintf_unfiltered (file, "%02x", buf[i]); - break; - case BFD_ENDIAN_LITTLE: - for (i = len - 1; i >= 0; i--) - fprintf_unfiltered (file, "%02x", buf[i]); - break; - default: - internal_error (__FILE__, __LINE__, _("Bad switch")); - } -} - enum regcache_dump_what { regcache_dump_none, regcache_dump_raw, @@ -1258,10 +1238,9 @@ regcache_dump (struct regcache *regcache, struct ui_file *file, else { regcache_raw_read (regcache, regnum, buf); - fprintf_unfiltered (file, "0x"); - dump_endian_bytes (file, - gdbarch_byte_order (gdbarch), buf, - regcache->descr->sizeof_register[regnum]); + print_hex_chars (file, buf, + regcache->descr->sizeof_register[regnum], + gdbarch_byte_order (gdbarch)); } } @@ -1280,12 +1259,9 @@ regcache_dump (struct regcache *regcache, struct ui_file *file, else if (status == REG_UNAVAILABLE) fprintf_unfiltered (file, ""); else - { - fprintf_unfiltered (file, "0x"); - dump_endian_bytes (file, - gdbarch_byte_order (gdbarch), buf, - regcache->descr->sizeof_register[regnum]); - } + print_hex_chars (file, buf, + regcache->descr->sizeof_register[regnum], + gdbarch_byte_order (gdbarch)); } }