mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-27 03:54:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

gdb/

Browse Source 
Code cleanup - constify struct lval_funcs.
	* dwarf2loc.c (pieced_value_funcs): Make it const.
	* infrun.c (siginfo_value_funcs): Likewise.
	* opencl-lang.c (opencl_value_funcs): Likewise.
	* valops.c (value_assign, value_ind): Make the funcs variable const.
	* value.c (struct value): Make location.computed.funcs target const.
	Rearrange the comments.
	(allocate_computed_value): Make the funcs parameter target const.
	(value_computed_funcs): Return the funcs target const.
	(value_free, value_copy, set_value_component_location): Make the funcs
	variable const.
	* value.h (allocate_computed_value): Make the funcs parameter target
	const.
	(value_computed_funcs): Return the funcs target const.
	* windows-tdep.c (tlb_value_funcs): Make it const.
This commit is contained in:
Jan Kratochvil 2011-07-14 15:00:20 +00:00
parent 3b80b9cef9
commit c8f2448ab7
8 changed files with 37 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
gdb/ChangeLog
View File

@ -1,3 +1,21 @@
2011-07-14 Jan Kratochvil <jan.kratochvil@redhat.com>
Code cleanup - constify struct lval_funcs.
* dwarf2loc.c (pieced_value_funcs): Make it const.
* infrun.c (siginfo_value_funcs): Likewise.
* opencl-lang.c (opencl_value_funcs): Likewise.
* valops.c (value_assign, value_ind): Make the funcs variable const.
* value.c (struct value): Make location.computed.funcs target const.
Rearrange the comments.
(allocate_computed_value): Make the funcs parameter target const.
(value_computed_funcs): Return the funcs target const.
(value_free, value_copy, set_value_component_location): Make the funcs
variable const.
* value.h (allocate_computed_value): Make the funcs parameter target
const.
(value_computed_funcs): Return the funcs target const.
* windows-tdep.c (tlb_value_funcs): Make it const.
2011-07-14 Hui Zhu <teawater@gmail.com>
* remote.c (remote_get_trace_status): Initialize p.

2
gdb/dwarf2loc.c
View File

@ -1051,7 +1051,7 @@ free_pieced_value_closure (struct value *v)
}
/* Functions for accessing a variable described by DW_OP_piece. */
static struct lval_funcs pieced_value_funcs = {
static const struct lval_funcs pieced_value_funcs = {
read_pieced_value,
write_pieced_value,
check_pieced_value_validity,

2
gdb/infrun.c
View File

@ -6394,7 +6394,7 @@ siginfo_value_write (struct value *v, struct value *fromval)
error (_("Unable to write siginfo"));
}
static struct lval_funcs siginfo_value_funcs =
static const struct lval_funcs siginfo_value_funcs =
{
siginfo_value_read,
siginfo_value_write

2
gdb/opencl-lang.c
View File

@ -354,7 +354,7 @@ lval_func_free_closure (struct value *v)
}
}
static struct lval_funcs opencl_value_funcs =
static const struct lval_funcs opencl_value_funcs =
{
lval_func_read,
lval_func_write,

4
gdb/valops.c
View File

@ -1377,7 +1377,7 @@ value_assign (struct value *toval, struct value *fromval)
case lval_computed:
{
struct lval_funcs *funcs = value_computed_funcs (toval);
const struct lval_funcs *funcs = value_computed_funcs (toval);
funcs->write (toval, fromval);
}
@ -1740,7 +1740,7 @@ value_ind (struct value *arg1)
if (VALUE_LVAL (arg1) == lval_computed)
{
struct lval_funcs *funcs = value_computed_funcs (arg1);
const struct lval_funcs *funcs = value_computed_funcs (arg1);
if (funcs->indirect)
{

17
gdb/value.c
View File

@ -194,8 +194,11 @@ struct value
for them to use. */
struct
{
struct lval_funcs *funcs; /* Functions to call. */
void *closure; /* Closure for those functions to use. */
/* Functions to call. */
const struct lval_funcs *funcs;
/* Closure for those functions to use. */
void *closure;
} computed;
} location;
@ -716,7 +719,7 @@ allocate_repeat_value (struct type *type, int count)
struct value *
allocate_computed_value (struct type *type,
struct lval_funcs *funcs,
const struct lval_funcs *funcs,
void *closure)
{
struct value *v = allocate_value_lazy (type);
@ -1059,7 +1062,7 @@ set_value_pointed_to_offset (struct value *value, int val)
value->pointed_to_offset = val;
}
struct lval_funcs *
const struct lval_funcs *
value_computed_funcs (struct value *v)
{
gdb_assert (VALUE_LVAL (v) == lval_computed);
@ -1175,7 +1178,7 @@ value_free (struct value *val)
if (VALUE_LVAL (val) == lval_computed)
{
struct lval_funcs *funcs = val->location.computed.funcs;
const struct lval_funcs *funcs = val->location.computed.funcs;
if (funcs->free_closure)
funcs->free_closure (val);
@ -1319,7 +1322,7 @@ value_copy (struct value *arg)
value_incref (val->parent);
if (VALUE_LVAL (val) == lval_computed)
{
struct lval_funcs *funcs = val->location.computed.funcs;
const struct lval_funcs *funcs = val->location.computed.funcs;
if (funcs->copy_closure)
val->location.computed.closure = funcs->copy_closure (val);
@ -1359,7 +1362,7 @@ set_value_component_location (struct value *component,
component->location = whole->location;
if (whole->lval == lval_computed)
{
struct lval_funcs *funcs = whole->location.computed.funcs;
const struct lval_funcs *funcs = whole->location.computed.funcs;
if (funcs->copy_closure)
component->location.computed.closure = funcs->copy_closure (whole);

6
gdb/value.h
View File

@ -204,14 +204,14 @@ struct lval_funcs
and closure CLOSURE. */
extern struct value *allocate_computed_value (struct type *type,
struct lval_funcs *funcs,
void *closure);
const struct lval_funcs *funcs,
void *closure);
extern struct value *allocate_optimized_out_value (struct type *type);
/* If VALUE is lval_computed, return its lval_funcs structure. */
extern struct lval_funcs *value_computed_funcs (struct value *value);
extern const struct lval_funcs *value_computed_funcs (struct value *value);
/* If VALUE is lval_computed, return its closure. The meaning of the
returned value depends on the functions VALUE uses. */

2
gdb/windows-tdep.c
View File

@ -256,7 +256,7 @@ tlb_value_write (struct value *v, struct value *fromval)
error (_("Impossible to change the Thread Local Base"));
}
static struct lval_funcs tlb_value_funcs =
static const struct lval_funcs tlb_value_funcs =
{
tlb_value_read,
tlb_value_write