mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-26 19:44:11 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

gdb: remove target_ops::commit_resume implementation in record-{btrace, full}.c

Browse Source 
The previous patch made the commit_resume implementations in the record
targets unnecessary, as the remote target's commit_resume implementation
won't commit-resume threads for which it didn't see a resume.  This
patch removes them.

gdb/ChangeLog:

	* record-btrace.c (class record_btrace_target): Remove.
	(record_btrace_target::commit_resume): Remove.
	* record-full.c (class record_full_target): Remove.
	(record_full_target::commit_resume): Remove.

Change-Id: I3a68d3d726fb09d8b7165b4edefc330d27803b27
This commit is contained in:
Simon Marchi 2021-01-13 20:25:58 -05:00 committed by Simon Marchi
parent c9d220893e
commit bd497355ea
3 changed files with 7 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2021-01-13 Simon Marchi <simon.marchi@efficios.com>
* record-btrace.c (class record_btrace_target): Remove.
(record_btrace_target::commit_resume): Remove.
* record-full.c (class record_full_target): Remove.
(record_full_target::commit_resume): Remove.
2021-01-13 Simon Marchi <simon.marchi@efficios.com>
* remote.c (enum class resume_state): New.

11
gdb/record-btrace.c
View File

@ -116,7 +116,6 @@ public:
const struct frame_unwind *get_tailcall_unwinder () override;
void commit_resume () override;
void resume (ptid_t, int, enum gdb_signal) override;
ptid_t wait (ptid_t, struct target_waitstatus *, target_wait_flags) override;
@ -2206,16 +2205,6 @@ record_btrace_target::resume (ptid_t ptid, int step, enum gdb_signal signal)
}
}
/* The commit_resume method of target record-btrace. */
void
record_btrace_target::commit_resume ()
{
if ((::execution_direction != EXEC_REVERSE)
&& !record_is_replaying (minus_one_ptid))
beneath ()->commit_resume ();
}
/* Cancel resuming TP. */
static void

10
gdb/record-full.c
View File

@ -267,7 +267,6 @@ public:
const target_info &info () const override
{ return record_full_target_info; }
void commit_resume () override;
void resume (ptid_t, int, enum gdb_signal) override;
void disconnect (const char *, int) override;
void detach (inferior *, int) override;
@ -1103,15 +1102,6 @@ record_full_target::resume (ptid_t ptid, int step, enum gdb_signal signal)
target_async (1);
}
/* "commit_resume" method for process record target. */
void
record_full_target::commit_resume ()
{
if (!RECORD_FULL_IS_REPLAY)
beneath ()->commit_resume ();
}
static int record_full_get_sig = 0;
/* SIGINT signal handler, registered by "wait" method. */