mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-12-18 23:03:29 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

PR23235, make check uses system installed ld

Browse Source 
This patch doesn't stop the build-id and debuglink tests using the
installed ld, it just prevents a compiler failure from resulting in a
test fail.  We could move the tests to the ld testsuite but it doesn't
seem all that important.

	PR 23235
	* testsuite/binutils-all/compress.exp (test_gnu_debuglink): Return
	unsupported rather than fail on compile errors.
	* testsuite/binutils-all/objdump.exp (test_build_id_debuglink):
	Likewise.  Save and restore CFLAGS_FOR_TARGET.
This commit is contained in:
Alan Modra 2018-05-28 16:30:23 +09:30
parent 46207bf3b5
commit bb3b531633
3 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
binutils/ChangeLog
View File

@ -1,3 +1,11 @@
2018-05-28 Alan Modra <amodra@gmail.com>
PR 23235
* testsuite/binutils-all/compress.exp (test_gnu_debuglink): Return
unsupported rather than fail on compile errors.
* testsuite/binutils-all/objdump.exp (test_build_id_debuglink):
Likewise. Save and restore CFLAGS_FOR_TARGET.
2018-05-18 Kito Cheng <kito.cheng@gmail.com> 2018-05-18 Kito Cheng <kito.cheng@gmail.com>
* readelf.c (get_machine_flags): Handle EF_RISCV_RVE. * readelf.c (get_machine_flags): Handle EF_RISCV_RVE.

2
binutils/testsuite/binutils-all/compress.exp
View File

@ -692,7 +692,7 @@ proc test_gnu_debuglink {} {
} }
if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog exectuable debug] != "" } { if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog exectuable debug] != "" } {
fail "$test (build)" unsupported "$test (build)"
return return
} }
set got [remote_exec host "$OBJDUMP -S tmpdir/testprog" "" "/dev/null" "tmpdir/testprog.dump"] set got [remote_exec host "$OBJDUMP -S tmpdir/testprog" "" "/dev/null" "tmpdir/testprog.dump"]

11
binutils/testsuite/binutils-all/objdump.exp
View File

@ -363,14 +363,21 @@ proc test_build_id_debuglink {} {
} }
# Use a fixed build-id. # Use a fixed build-id.
if { [info exists CFLAGS_FOR_TARGET] } {
set save_CFLAGS_FOR_TARGET $CFLAGS_FOR_TARGET
}
set CFLAGS_FOR_TARGET "-g -Wl,--build-id=0x12345678abcdef01" set CFLAGS_FOR_TARGET "-g -Wl,--build-id=0x12345678abcdef01"
if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog exectuable debug] != "" } { if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog exectuable debug] != "" } {
fail "$test (build)" unsupported "$test (build)"
return return
} }
# FIXME: Do we need to restore CFLAGS_FOR_TARGET to its old value ? if { [info exists save_CFLAGS_FOR_TARGET] } {
set CFLAGS_FOR_TARGET $save_CFLAGS_FOR_TARGET
} else {
unset CFLAGS_FOR_TARGET
}
if { [binutils_run $STRIP "--strip-debug --remove-section=.comment tmpdir/testprog -o tmpdir/testprog.strip"] != "" } { if { [binutils_run $STRIP "--strip-debug --remove-section=.comment tmpdir/testprog -o tmpdir/testprog.strip"] != "" } {
fail "$test (strip debug info)" fail "$test (strip debug info)"