mirrors/binutils-gdb
1
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-23 18:14:13 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Skip gc-sections if relocation is incompatible

Browse Source 
This patch skips gc-sections if input relocation is incompatible with
output.

bfd/

	PR ld/18160
	* elflink.c (elf_gc_sweep): Skip if relocation is incompatible.
	(bfd_elf_gc_sections): Likewise.

ld/testsuite/

	PR ld/18160
	* ld-x86-64/pr18160.d: New file.
	* ld-x86-64/pr18160.s: Likewise.
	* ld-x86-64/pr18160.t: Likewise.
	* ld-x86-64/x86-64.exp: Run pr18160.
This commit is contained in:
H.J. Lu 2015-03-26 08:22:08 -07:00
parent 20d35291fb
commit b19a8f8545
7 changed files with 57 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bfd/ChangeLog
View File

@ -1,3 +1,9 @@
2015-03-26 H.J. Lu <hongjiu.lu@intel.com>
PR ld/18160
* elflink.c (elf_gc_sweep): Skip if relocation is incompatible.
(bfd_elf_gc_sections): Likewise.
2015-03-25 Marcus Shawcroft <marcus.shawcroft@arm.com>
* elfnn-aarch64.c (_bfd_aarch64_resize_stubs): Adjust stub section

6
bfd/elflink.c
View File

@ -12159,7 +12159,8 @@ elf_gc_sweep (bfd *abfd, struct bfd_link_info *info)
{
asection *o;
if (bfd_get_flavour (sub) != bfd_target_elf_flavour)
if (bfd_get_flavour (sub) != bfd_target_elf_flavour
|| !(*bed->relocs_compatible) (sub->xvec, abfd->xvec))
continue;
for (o = sub->sections; o != NULL; o = o->next)
@ -12446,7 +12447,8 @@ bfd_elf_gc_sections (bfd *abfd, struct bfd_link_info *info)
{
asection *o;
if (bfd_get_flavour (sub) != bfd_target_elf_flavour)
if (bfd_get_flavour (sub) != bfd_target_elf_flavour
|| !(*bed->relocs_compatible) (sub->xvec, abfd->xvec))
continue;
/* Start at sections marked with SEC_KEEP (ref _bfd_elf_gc_keep).

8
ld/testsuite/ChangeLog
View File

@ -1,3 +1,11 @@
2015-03-26 H.J. Lu <hongjiu.lu@intel.com>
PR ld/18160
* ld-x86-64/pr18160.d: New file.
* ld-x86-64/pr18160.s: Likewise.
* ld-x86-64/pr18160.t: Likewise.
* ld-x86-64/x86-64.exp: Run pr18160.
---
2015-03-25 Marcus Shawcroft <marcus.shawcroft@arm.com>
* ld-aarch64/erratum835769.d: Adjust for initial branch over stub

14
ld/testsuite/ld-x86-64/pr18160.d Normal file
View File

@ -0,0 +1,14 @@
#as: --64
#ld: --gc-sections -melf_x86_64 -T pr18160.t
#objdump: -dw
.*: +file format elf32-i386
Disassembly of section .text:
0+ <start>:
[ ]*[a-f0-9]+: e9 00 00 00 00 jmp 5 <foo>
0+5 <foo>:
[ ]*[a-f0-9]+: c3 ret

16
ld/testsuite/ld-x86-64/pr18160.s Normal file
View File

@ -0,0 +1,16 @@
.section .text.start,"ax",@progbits
.globl start
.type start, @function
start:
.cfi_startproc
jmp foo
.cfi_endproc
.size start, .-start
.section .text.foo,"ax",@progbits
.globl foo
.type foo, @function
foo:
.cfi_startproc
ret
.cfi_endproc
.size foo, .-foo

8
ld/testsuite/ld-x86-64/pr18160.t Normal file
View File

@ -0,0 +1,8 @@
OUTPUT_FORMAT(elf32-i386)
ENTRY(start)
SECTIONS
{
.text : { *(.text*) }
.data : { *(.data.*) }
.bss : { *(.bss.*) }
}

1
ld/testsuite/ld-x86-64/x86-64.exp
View File

@ -317,6 +317,7 @@ run_dump_test "mov1c"
run_dump_test "mov1d"
run_dump_test "pr17935-1"
run_dump_test "pr17935-2"
run_dump_test "pr18160"
# Must be native with the C compiler
if { [isnative] && [which $CC] != 0 } {