mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-27 12:03:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

gas: document that get_symbol_name() can clobber the input buffer

Browse Source 
Callers which want to make further parsing attempts at the buffer passed
to the function need to be aware that due to the potential of string
concatenation the input buffer may be altered in ways beyond what can be
undone by putting back at *input_line_pointer the character that the
function returns.
This commit is contained in:
Jan Beulich 2023-04-19 11:43:44 +02:00
parent 4f0813127b
commit ac164fa854
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gas/expr.c
View File

@ -2388,12 +2388,17 @@ resolve_expression (expressionS *expressionP)
here lessens the crowd at read.c.
Assume input_line_pointer is at start of symbol name, or the
start of a double quote enclosed symbol name.
Advance input_line_pointer past symbol name.
Turn that character into a '\0', returning its former value,
which may be the closing double quote.
start of a double quote enclosed symbol name. Advance
input_line_pointer past symbol name. Turn that character into a '\0',
returning its former value, which may be the closing double quote.
This allows a string compare (RMS wants symbol names to be strings)
of the symbol name.
of the symbol name.
NOTE: The input buffer is further altered when adjacent strings are
concatenated by the function. Callers caring about the original buffer
contents will need to make a copy before calling here.
There will always be a char following symbol name, because all good
lines end in end-of-line. */