[ld, testsuite] Honor cflags when GCC used as linker driver

ld/
	* testsuite/lib/ld-lib.exp (run_ld_link_exec_tests): Append
	board_cflags as gcc is used as linker driver.
	* testsuite/ld-unique/unique.exp: Likewise
This commit is contained in:
Jiong Wang 2017-01-23 09:59:10 +00:00
parent dcd310a08c
commit 9966f7eece
3 changed files with 28 additions and 2 deletions

View File

@ -1,3 +1,9 @@
2017-01-23 Jiong Wang <jiong.wang@arm.com>
* testsuite/lib/ld-lib.exp (run_ld_link_exec_tests): Append
board_cflags as gcc is used as linker driver.
* testsuite/ld-unique/unique.exp: Likewise
2017-01-20 Jiong Wang <jiong.wang@arm.com> 2017-01-20 Jiong Wang <jiong.wang@arm.com>
* testsuite/ld-aarch64/aarch64-elf.exp (aarch64elflinktests): New tests. * testsuite/ld-aarch64/aarch64-elf.exp (aarch64elflinktests): New tests.

View File

@ -108,8 +108,17 @@ if ![ld_compile "$CC -c" "$srcdir/$subdir/unique_empty.s" "tmpdir/unique_empty.o
set fails [expr $fails + 1] set fails [expr $fails + 1]
} }
# When using GCC as the linker driver, we need to specify board cflags when
# linking because cflags may contain linker options. For example when linker
# options are included in GCC spec files then we need the -specs option.
if [board_info [target_info name] exists cflags] {
set board_cflags " [board_info [target_info name] cflags]"
} else {
set board_cflags ""
}
# Create executable containing unique symbol. # Create executable containing unique symbol.
if ![ld_link $CC "tmpdir/unique_prog" "tmpdir/unique.o"] { if ![ld_link "$CC $board_cflags" "tmpdir/unique_prog" "tmpdir/unique.o"] {
fail "Could not link a unique executable" fail "Could not link a unique executable"
set fails [expr $fails + 1] set fails [expr $fails + 1]
} }

View File

@ -1381,6 +1381,17 @@ proc run_ld_link_exec_tests { ldtests args } {
global CXXFLAGS global CXXFLAGS
global errcnt global errcnt
global exec_output global exec_output
global board_cflags
# When using GCC as the linker driver, we need to specify board cflags when
# linking because cflags may contain linker options. For example when
# linker options are included in GCC spec files then we need the -specs
# option.
if [board_info [target_info name] exists cflags] {
set board_cflags " [board_info [target_info name] cflags]"
} else {
set board_cflags ""
}
foreach testitem $ldtests { foreach testitem $ldtests {
foreach target $args { foreach target $args {
@ -1440,7 +1451,7 @@ proc run_ld_link_exec_tests { ldtests args } {
# compile only # compile only
pass $testname pass $testname
continue; continue;
} elseif ![$link_proc $link_cmd $binfile "-L$srcdir/$subdir $ld_options $objfiles"] { } elseif ![$link_proc $link_cmd $binfile "$board_cflags -L$srcdir/$subdir $ld_options $objfiles"] {
set failed 1 set failed 1
} }