mirrors/binutils-gdb
1
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-25 19:14:52 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid spurious readelf error status from decode_arm_unwind.

Browse Source 
readelf.c:decode_arm_unwind has a variable res that is used as a
return value, with FALSE meaning unsuccessful and TRUE meaning
successful.  This is initialized to FALSE (and then various code in
the function sets it to FALSE again on error), meaning that when the
function is successful, if it reaches returning res is still returns
FALSE, resulting eventually in exit status 1 from readelf without any
error message to indicate an error.

This patch fixes the initialization to use TRUE, so avoiding those
spurious errors.  I don't have a self-contained test for this issue;
it was observed as many prelink tests failing without the patch and
passing with it.

	* readelf.c (decode_arm_unwind): Initialize res to TRUE.
This commit is contained in:
Joseph Myers 2017-10-05 14:19:39 +00:00
parent 64f7152491
commit 97953bab05
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
binutils/ChangeLog
View File

@ -1,3 +1,7 @@
2017-10-05 Joseph Myers <joseph@codesourcery.com>
* readelf.c (decode_arm_unwind): Initialize res to TRUE.
2017-10-05 Nick Clifton <nickc@redhat.com>
PR 22260

2
binutils/readelf.c
View File

@ -8731,7 +8731,7 @@ decode_arm_unwind (struct arm_unw_aux_info * aux,
unsigned int more_words = 0;
struct absaddr addr;
bfd_vma sym_name = (bfd_vma) -1;
bfd_boolean res = FALSE;
bfd_boolean res = TRUE;
if (remaining == 0)
{