mirrors/binutils-gdb
1
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-23 18:14:13 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

gdb: check for groups with duplicate names in reggroups:add

Browse Source 
In the downstream ROCm GDB port, we would create multiple register
groups with duplicate names.  While it did not really hurt, it certainly
wasn't the intent.  And I don't think it ever makes sense to do so.

To catch these, change the assert in reggroups::add to check for
duplicate names.  It's no longer necessary to check for duplicate
reggroup pointers, because adding the same group twice would be caught
by the duplicate name check.

Change-Id: Id216a58acf91f1b314d3cba2d02de73656f8851d
Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Simon Marchi 2022-10-18 10:17:33 -04:00 committed by Simon Marchi
parent fd320c4c29
commit 9454c9ce88
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gdb/reggroups.c
View File

@ -71,8 +71,13 @@ struct reggroups
void add (const reggroup *group)
{
gdb_assert (group != nullptr);
gdb_assert (std::find (m_groups.begin(), m_groups.end(), group)
== m_groups.end());
auto find_by_name = [group] (const reggroup *g)
{
return streq (group->name (), g->name ());
};
gdb_assert (std::find_if (m_groups.begin (), m_groups.end (), find_by_name)
== m_groups.end ());
m_groups.push_back (group);
}