mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-26 19:44:11 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

section_by_target_index memory leak

Browse Source 
The rs6000 backend can call coff_section_from_bfd_index from its
object_p function via coff_set_alignment_hook.  If the object doesn't
match, or another target matches too, then the hash table needs to be
freed via a cleanup.

	* coffgen.c (coff_object_cleanup): New function.
	(coff_real_object_p): Return coff_object_cleanup, and call on
	failure path.  Move declaration to..
	* libcoff-in.h: ..here.
	(coff_object_cleanup): Declare.
	* coff-stgo32.c (go32exe_cleanup): Call coff_object_cleanup.
	(go32exe_check_format): Adjust assertion.
	* libcoff.h: Regenerate.
This commit is contained in:
Alan Modra 2023-05-30 20:05:38 +09:30
parent d18f60c747
commit 90fd5049bd
4 changed files with 28 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bfd/coff-stgo32.c
View File

@ -248,6 +248,7 @@ static void
go32exe_cleanup (bfd *abfd)
{
abfd->origin = 0;
coff_object_cleanup (abfd);
free (go32exe_temp_stub);
go32exe_temp_stub = NULL;
@ -323,7 +324,7 @@ go32exe_check_format (bfd *abfd)
bfd_cleanup cleanup = coff_object_p (abfd);
if (cleanup == NULL)
goto fail;
BFD_ASSERT (cleanup == _bfd_no_cleanup);
BFD_ASSERT (cleanup == coff_object_cleanup);
return go32exe_cleanup;

24
bfd/coffgen.c
View File

@ -281,14 +281,25 @@ make_a_section_from_file (bfd *abfd,
return result;
}
void
coff_object_cleanup (bfd *abfd)
{
if (bfd_family_coff (abfd) && bfd_get_format (abfd) == bfd_object)
{
struct coff_tdata *td = coff_data (abfd);
if (td != NULL)
{
if (td->section_by_index)
htab_delete (td->section_by_index);
if (td->section_by_target_index)
htab_delete (td->section_by_target_index);
}
}
}
/* Read in a COFF object and make it into a BFD. This is used by
ECOFF as well. */
bfd_cleanup
coff_real_object_p (bfd *,
unsigned,
struct internal_filehdr *,
struct internal_aouthdr *);
bfd_cleanup
coff_real_object_p (bfd *abfd,
unsigned nscns,
struct internal_filehdr *internal_f,
@ -358,9 +369,10 @@ coff_real_object_p (bfd *abfd,
}
_bfd_coff_free_symbols (abfd);
return _bfd_no_cleanup;
return coff_object_cleanup;
fail:
coff_object_cleanup (abfd);
_bfd_coff_free_symbols (abfd);
bfd_release (abfd, tdata);
fail2:

4
bfd/libcoff-in.h
View File

@ -331,6 +331,10 @@ struct decoration_hash_entry
};
/* Functions in coffgen.c. */
extern void coff_object_cleanup
(bfd *);
extern bfd_cleanup coff_real_object_p
(bfd *, unsigned, struct internal_filehdr *, struct internal_aouthdr *);
extern bfd_cleanup coff_object_p
(bfd *);
extern struct bfd_section *coff_section_from_bfd_index

4
bfd/libcoff.h
View File

@ -335,6 +335,10 @@ struct decoration_hash_entry
};
/* Functions in coffgen.c. */
extern void coff_object_cleanup
(bfd *);
extern bfd_cleanup coff_real_object_p
(bfd *, unsigned, struct internal_filehdr *, struct internal_aouthdr *);
extern bfd_cleanup coff_object_p
(bfd *);
extern struct bfd_section *coff_section_from_bfd_index