mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-27 20:14:06 +08:00
Fix and improve comment in gdb_remote_download
This patch fixes the current comment in gdb_remote_download, which is false (the "except if that's already where it is" part). It also improves it, by explaining why pass TOFILE through standard_output_file, even it is an absolute path. gdb/testsuite/ChangeLog: * lib/gdb.exp (gdb_remote_download): Fix and extend comment.
This commit is contained in:
parent
fd85a6a1f6
commit
8392fa22d6
@ -1,3 +1,7 @@
|
||||
2016-04-13 Simon Marchi <simon.marchi@ericsson.com>
|
||||
|
||||
* lib/gdb.exp (gdb_remote_download): Fix and extend comment.
|
||||
|
||||
2016-04-13 Simon Marchi <simon.marchi@ericsson.com>
|
||||
|
||||
* boards/gdbserver-base.exp (${board}_download): Copy source file to
|
||||
|
@ -4211,8 +4211,13 @@ proc gdb_remote_download {dest fromfile {tofile {}}} {
|
||||
|
||||
return $destname
|
||||
} else {
|
||||
# When the DEST is local, we copy the file to the test directory
|
||||
# (where the executable is), except if that's already where it is.
|
||||
# When the DEST is local, we copy the file to the test directory (where
|
||||
# the executable is).
|
||||
#
|
||||
# Note that we pass TOFILE through standard_output_file, regardless of
|
||||
# whether it is absolute or relative, because we don't want the tests
|
||||
# to be able to write outside their standard output directory.
|
||||
|
||||
set tofile [standard_output_file $tofile]
|
||||
|
||||
file copy -force $fromfile $tofile
|
||||
|
Loading…
Reference in New Issue
Block a user