mirrors/binutils-gdb
1
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-23 01:53:38 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

gdb: remove exact_match parameter from find_line_symtab

Browse Source 
struct symtab *find_line_symtab (struct symtab *, int, int *, bool *);

The last parameter is bool* that when set will receive information
if the match was exact. This parameter is never used by any callsite
and can therefore be removed.

This will become:

symtab *find_line_symtab (symtab *sym_tab, int line, int *index);

Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Klaus Gerlicher 2024-10-10 08:23:11 +00:00
parent 52a8387dfd
commit 7ea50bf94f
3 changed files with 15 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/linespec.c
View File

@ -4031,7 +4031,7 @@ decode_digits_list_mode (struct linespec_state *self,
set_current_program_space (pspace);
/* Simplistic search just for the list command. */
val.symtab = find_line_symtab (elt, val.line, NULL, NULL);
val.symtab = find_line_symtab (elt, val.line, nullptr);
if (val.symtab == NULL)
val.symtab = elt;
val.pspace = pspace;

19
gdb/symtab.c
View File

@ -3455,19 +3455,10 @@ find_pc_line_symtab (CORE_ADDR pc)
return sal.symtab;
}
/* Find line number LINE in any symtab whose name is the same as
SYMTAB.
/* See symtab.h. */
If found, return the symtab that contains the linetable in which it was
found, set *INDEX to the index in the linetable of the best entry
found, and set *EXACT_MATCH to true if the value returned is an
exact match.
If not found, return NULL. */
struct symtab *
find_line_symtab (struct symtab *sym_tab, int line,
int *index, bool *exact_match)
symtab *
find_line_symtab (symtab *sym_tab, int line, int *index)
{
int exact = 0; /* Initialized here to avoid a compiler warning. */
@ -3547,8 +3538,6 @@ done:
if (index)
*index = best_index;
if (exact_match)
*exact_match = (exact != 0);
return best_symtab;
}
@ -3609,7 +3598,7 @@ find_line_pc (struct symtab *symtab, int line, CORE_ADDR *pc)
if (symtab == 0)
return false;
symtab = find_line_symtab (symtab, line, &ind, NULL);
symtab = find_line_symtab (symtab, line, &ind);
if (symtab != NULL)
{
l = symtab->linetable ();

11
gdb/symtab.h
View File

@ -2510,7 +2510,16 @@ completion_skip_symbol (complete_symbol_mode mode, Symbol *sym)
bool matching_obj_sections (struct obj_section *, struct obj_section *);
extern struct symtab *find_line_symtab (struct symtab *, int, int *, bool *);
/* Find line number LINE in any symtab whose name is the same as
SYMTAB.
If found, return the symtab that contains the linetable in which it was
found, set *INDEX to the index in the linetable of the best entry
found. The returned index includes inexact matches.
If not found, return NULL. */
extern symtab *find_line_symtab (symtab *sym_tab, int line, int *index);
/* Given a function symbol SYM, find the symtab and line for the start
of the function. If FUNFIRSTLINE is true, we want the first line