mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-01-10 10:03:37 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

[testsuite patch] Fix new FAIL: py-frame.exp: test Frame.read_register(rip)

Browse Source 
for x86_64 -m32 run one gets:

+FAIL: gdb.python/py-frame.exp: test Frame.read_register(rip)

I do not have x32 OS here but the %rip test should PASS there I think.

On Sun, 11 Jan 2015 14:58:06 +0100, Yao Qi wrote:
With your patch applied, this test is skipped on 'x86_64 -m32'.  I
prefer to increasing the test coverage, so how about extending the test
for 'x86_64 -m32'?  I mean test Frame.read_register(eip)...

gdb/testsuite/ChangeLog
2015-01-12  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.python/py-frame.exp (test Frame.read_register(rip)): Use
	is_amd64_regs_target and is_x86_like_target.
This commit is contained in:
Jan Kratochvil 2015-01-12 11:02:46 +01:00
parent cb3b1e65a9
commit 7e67715dd3
2 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2015-01-12 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.python/py-frame.exp (test Frame.read_register(rip)): Use
is_amd64_regs_target and is_x86_like_target.
2015-01-11 Doug Evans <xdje42@gmail.com>
* lib/dwarf.exp (Dwarf): Flag an error if a numeric attribute value

16
gdb/testsuite/gdb.python/py-frame.exp
View File

@ -105,9 +105,15 @@ gdb_test "python print ('result = %s' % (f0.read_register('pc') == f0.pc()))" \
" = True" \
"test Frame.read_register(pc)"
# On x86-64, PC is in $rip register.
if {[istarget x86_64-*]} {
gdb_test "python print ('result = %s' % (f0.read_register('pc') == f0.read_register('rip')))" \
" = True" \
"test Frame.read_register(rip)"
# Test arch-specific register name.
set pc ""
if {[is_amd64_regs_target]} {
set pc "rip"
} elseif {[is_x86_like_target]} {
set pc "eip"
}
if { $pc != "" } {
gdb_test "python print ('result = %s' % (f0.read_register('pc') == f0.read_register('$pc')))" \
" = True" \
"test Frame.read_register($pc)"
}