mirrors/binutils-gdb
1
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-25 11:04:18 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

PR29892, Field file_table of struct module is uninitialized

Browse Source 
PR 29892
	* vms-alphs.c (new_module): Use bfd_zmalloc to alloc file_table.
	(parse_module): Rewrite file_table reallocation code and clear.
This commit is contained in:
Alan Modra 2022-12-12 19:01:08 +10:30
parent 77c225bdeb
commit 65cf035b8d
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
bfd/vms-alpha.c
View File

@ -4337,7 +4337,7 @@ new_module (bfd *abfd)
= (struct module *) bfd_zalloc (abfd, sizeof (struct module));
module->file_table_count = 16; /* Arbitrary. */
module->file_table
= bfd_malloc (module->file_table_count * sizeof (struct fileinfo));
= bfd_zmalloc (module->file_table_count * sizeof (struct fileinfo));
return module;
}
@ -4520,15 +4520,18 @@ parse_module (bfd *abfd, struct module *module, unsigned char *ptr,
src_ptr + DST_S_B_SRC_DF_FILENAME,
ptr + rec_length - (src_ptr + DST_S_B_SRC_DF_FILENAME));
while (fileid >= module->file_table_count)
if (fileid >= module->file_table_count)
{
module->file_table_count *= 2;
unsigned int old_count = module->file_table_count;
module->file_table_count += fileid;
module->file_table
= bfd_realloc_or_free (module->file_table,
module->file_table_count
* sizeof (struct fileinfo));
if (module->file_table == NULL)
return false;
memset (module->file_table + old_count, 0,
fileid * sizeof (struct fileinfo));
}
module->file_table [fileid].name = filename;