mirrors/binutils-gdb
1
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-23 18:14:13 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update binary_get_section_contents to seek using section's file position

Browse Source 
I have a patch for GDB which opens and reads from BFDs using the
"binary" target.  However, for it to work, we need to be able to get a
section's contents based from the file position of that section.

At the moment, reading a section's contents will always read from the
start of the file regardless of where that section is located.  While
this was fine for the original use of the "binary" target, it won't
work for my use case.  This change shouldn't impact any existing
callers due to the fact that the single .data section is initialized
with a filepos of 0.

bfd/ChangeLog:

	* binary.c (binary_get_section_contents): Seek using offset
	from section's file position.
This commit is contained in:
Kevin Buettner 2020-06-11 18:58:49 -07:00
parent 94c265d790
commit 5efb677960
2 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bfd/ChangeLog
View File

@ -1,3 +1,8 @@
2020-07-22 Kevin Buettner <kevinb@redhat.com>
* binary.c (binary_get_section_contents): Seek using offset
from section's file position.
2020-07-22 Kevin Buettner <kevinb@redhat.com>
* elf.c (_bfd_elf_make_section_from_phdr): Remove hack for GDB.

12
bfd/binary.c
View File

@ -19,10 +19,10 @@
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
MA 02110-1301, USA. */
/* This is a BFD backend which may be used to write binary objects.
It may only be used for output, not input. The intention is that
this may be used as an output format for objcopy in order to
generate raw binary data.
/* This is a BFD backend which may be used to read or write binary
objects. Historically, it was used as an output format for objcopy
in order to generate raw binary data, but is now used for other
purposes as well.
This is very simple. The only complication is that the real data
will start at some address X, and in some cases we will not want to
@ -97,12 +97,12 @@ binary_object_p (bfd *abfd)
static bfd_boolean
binary_get_section_contents (bfd *abfd,
asection *section ATTRIBUTE_UNUSED,
asection *section,
void * location,
file_ptr offset,
bfd_size_type count)
{
if (bfd_seek (abfd, offset, SEEK_SET) != 0
if (bfd_seek (abfd, section->filepos + offset, SEEK_SET) != 0
|| bfd_bread (location, count, abfd) != count)
return FALSE;
return TRUE;