gdb/python: avoid depending on the curses library

The commit:

  commit 29c7078711
  Date:   Sun Sep 8 07:46:09 2024 +0200

      [gdb/testsuite] Handle missing curses in gdb.python/py-missing-debug.exp

Highlighted that in some cases we might be running on a system with an
older version of Python (earlier than 3.7), and on a system for which
the curses library has not been installed.

In these circumstances the gdb.missing_debug module will not load as
it uses curses to provide isalnum() and isascii() functions.

To avoid this problem I propose that we copy the isalnum() and
isascii() from the Python curses library.  These functions are
basically trivial and removing the curses dependency means GDB will
work in more cases without increasing its dependencies.

I did consider keeping the uses of curses and only having the function
definitions be a fallback for when the curses library failed to load,
but this felt like overkill.  The function definitions are both tiny
and I think "obvious" given their specifications, so I figure we might
as well just use our own definitions if they are not available as
builtin methods on the str class.

For testing I changed this line:

  if sys.version_info >= (3, 7):

to

  if sys.version_info >= (3, 7) and False:

then reran gdb.python/py-missing-debug.exp, there were no failures.

Approved-By: Tom de Vries <tdevries@suse.de>
This commit is contained in:
Andrew Burgess 2024-09-09 17:33:54 +01:00
parent 258c81da3c
commit 5ddd0d7eef

View File

@ -31,9 +31,33 @@ if sys.version_info >= (3, 7):
return ch.isalnum() return ch.isalnum()
else: else:
# Fall back to curses.ascii.isascii() and curses.ascii.isalnum() for # Older version of Python doesn't have str.isascii() and
# earlier versions. # str.isalnum() so provide our own.
from curses.ascii import isalnum, isascii #
# We could import isalnum() and isascii() from the curses library,
# but that adds an extra dependency. Given these functions are
# both small and trivial lets implement them here.
#
# These definitions are based on those in the curses library, but
# simplified as we know C will always be a single character 'str'.
def isdigit(c):
return 48 <= ord(c) <= 57
def islower(c):
return 97 <= ord(c) <= 122
def isupper(c):
return 65 <= ord(c) <= 90
def isalpha(c):
return isupper(c) or islower(c)
def isalnum(c):
return isalpha(c) or isdigit(c)
def isascii(c):
return 0 <= ord(c) <= 127
def _validate_name(name): def _validate_name(name):