mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-27 12:03:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

gdbserver: convert have_ptrace_getregset to a tribool

Browse Source 
Convert the have_ptrace_getregset global within gdbserver to a
tribool.  This brings the flag into alignment with the corresponding
flag in GDB.

The gdbserver have_ptrace_getregset variable is already used as a
tribool, it just doesn't have the tribool type.

In a future commit I plan to share more code between GDB and
gdbserver, and having this variable be the same type in both code
bases will make the sharing much easier.

There should be no user visible changes after this commit.

Approved-By: John Baldwin <jhb@FreeBSD.org>
This commit is contained in:
Andrew Burgess 2024-01-25 14:10:42 +00:00
parent 874f4887f0
commit 5920765d75
4 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdbserver/linux-arm-low.cc
View File

@ -1007,9 +1007,9 @@ arm_target::low_arch_setup ()
/* Check if PTRACE_GETREGSET works. */
if (ptrace (PTRACE_GETREGSET, tid, NT_PRSTATUS, &iov) == 0)
have_ptrace_getregset = 1;
have_ptrace_getregset = TRIBOOL_TRUE;
else
have_ptrace_getregset = 0;
have_ptrace_getregset = TRIBOOL_FALSE;
}
bool
@ -1122,7 +1122,7 @@ arm_target::get_regs_info ()
{
const struct target_desc *tdesc = current_process ()->tdesc;
if (have_ptrace_getregset == 1
if (have_ptrace_getregset == TRIBOOL_TRUE
&& (is_aarch32_linux_description (tdesc)
|| arm_linux_get_tdesc_fp_type (tdesc) == ARM_FP_TYPE_VFPV3))
return &regs_info_aarch32;

2
gdbserver/linux-low.cc
View File

@ -135,7 +135,7 @@ typedef struct
#endif
/* Does the current host support PTRACE_GETREGSET? */
int have_ptrace_getregset = -1;
enum tribool have_ptrace_getregset = TRIBOOL_UNKNOWN;
/* Return TRUE if THREAD is the leader thread of the process. */

2
gdbserver/linux-low.h
View File

@ -951,7 +951,7 @@ void thread_db_notice_clone (struct thread_info *parent_thr, ptid_t child_ptid);
bool thread_db_thread_handle (ptid_t ptid, gdb_byte **handle, int *handle_len);
extern int have_ptrace_getregset;
extern enum tribool have_ptrace_getregset;
/* Search for the value with type MATCH in the auxv vector, with entries of
length WORDSIZE bytes, of process with pid PID. If found, store the

10
gdbserver/linux-x86-low.cc
View File

@ -899,7 +899,7 @@ x86_linux_read_description (void)
if (ptrace (PTRACE_GETFPXREGS, tid, 0, (long) &fpxregs) < 0)
{
have_ptrace_getfpxregs = 0;
have_ptrace_getregset = 0;
have_ptrace_getregset = TRIBOOL_FALSE;
return i386_linux_read_description (X86_XSTATE_X87);
}
else
@ -918,7 +918,7 @@ x86_linux_read_description (void)
return tdesc_i386_linux_no_xml.get ();
}
if (have_ptrace_getregset == -1)
if (have_ptrace_getregset == TRIBOOL_UNKNOWN)
{
uint64_t xstateregs[(X86_XSTATE_SSE_SIZE / sizeof (uint64_t))];
struct iovec iov;
@ -929,10 +929,10 @@ x86_linux_read_description (void)
/* Check if PTRACE_GETREGSET works. */
if (ptrace (PTRACE_GETREGSET, tid,
(unsigned int) NT_X86_XSTATE, (long) &iov) < 0)
have_ptrace_getregset = 0;
have_ptrace_getregset = TRIBOOL_FALSE;
else
{
have_ptrace_getregset = 1;
have_ptrace_getregset = TRIBOOL_TRUE;
/* Get XCR0 from XSAVE extended state. */
xcr0 = xstateregs[(I386_LINUX_XSAVE_XCR0_OFFSET
@ -955,7 +955,7 @@ x86_linux_read_description (void)
}
/* Check the native XCR0 only if PTRACE_GETREGSET is available. */
xcr0_features = (have_ptrace_getregset
xcr0_features = (have_ptrace_getregset == TRIBOOL_TRUE
&& (xcr0 & X86_XSTATE_ALL_MASK));
if (xcr0_features)